Confirmed users
325
edits
Code Review: Difference between revisions
Added tips for interdiff creation
(Added tips for interdiff creation) |
|||
| Line 29: | Line 29: | ||
* Add a 'low-priority' patch flag | * Add a 'low-priority' patch flag | ||
* Some integration with a formatting checker | * Some integration with a formatting checker | ||
== Tips and Tricks == | |||
* When responding to a review, rebase the patch first, then generate any responses to the review as a separate patch in mercurial. You can post that as the interdiff for the reviewer, and (when ready) hg qfold it into the original (rebased) patch. | |||
* hg diff -r qparent (perhaps aliased in .hgrc to qdiffall) is an easy way to get a rollup of all changes currently applied in the patch queue (such as base patch(es) plus interdiffs. | |||