234
edits
No edit summary |
No edit summary |
||
| Line 151: | Line 151: | ||
XXX frecency for 2745 [http://quality-drupal.stage.mozilla.com/community] is [3280] | XXX frecency for 2745 [http://quality-drupal.stage.mozilla.com/community] is [3280] | ||
XXX recalc for 2745 [http://quality-drupal.stage.mozilla.com/community] is 32800 vs 3280 and 164 vs 164 | XXX recalc for 2745 [http://quality-drupal.stage.mozilla.com/community] is 32800 vs 3280 and 164 vs 164 | ||
// not the same logic above, as a single visit could not both | // not the same logic above, as a single visit could not both | ||
| Line 169: | Line 168: | ||
pointsForSampledVisits = mFirstBucketWeight * ((bonus + 100.0) / 100.0); | pointsForSampledVisits = mFirstBucketWeight * ((bonus + 100.0) / 100.0); | ||
27) | |||
log bug about no star if something bookmarked and livemarked bug | |||
> // NOTE: because we are grouping by h.id, b.id and b.parent | |||
> // get collapsed, so if something is both a livemark and a bookmark | |||
> // we might not show it as a "star" if the parentId we return is | |||
> // the one for the livemark item, and not the bookmark item. | |||
> // XXX todo: log a spin off bug on this issue. | |||
28) had to move EnsureCurrentSchema() to after table creation, or we'd bomb with new profiles, and I've removed the transaction | |||
29) would like to order autocomplete by frecency DESC, typed DESC visit_count DESC to break ties, but this is slow, even with an index. (spin off bug) | |||
30) comment about why we add typed bonus to bookmark bonus for frecency of | |||
// not the same logic above, as a single visit could not both | |||
// a bookmark visit and a typed visit. but when estimating a frecency | |||
// for a place that doesn't have any visits, this will make it so | |||
// something bookmarked and typed will have a higher frecency than | |||
// something just typed or just bookmarked. | |||
if (aIsBookmarked) | |||
bonus = mUnvisitedBookmarkBonus; | |||
if (aTyped) | |||
bonus += mUnvisitedTypedBonus; | |||
31) | |||
'''todo''' | |||
x) figure out why with jay's profile, about:configxxx or any misses are slow to type. fix that! | x) figure out why with jay's profile, about:configxxx or any misses are slow to type. fix that! | ||
x) | x) after fx 2 / fx 3b2 migration, force a few idles? do a massive frecency recalc? how long does each take? do a few on a timer, not on idle to improve the first impression | ||
x) limit chunks to 20 or 40, as 20 is max results? | x) limit chunks to 20 or 40, as 20 is max results? | ||
| Line 215: | Line 234: | ||
x) | x) | ||
for the code that resets to -1, better to skip over | for the code that resets to -1, better to skip over livemarks, or fix it afterwards like I'm doing right now? | ||
x) | x) | ||
edits