264
edits
Calendar:Build: Difference between revisions
Jump to navigation
Jump to search
no edit summary
XFallenAngel (talk | contribs) No edit summary |
|||
| Line 158: | Line 158: | ||
=Debugging and Preferences= | =Debugging and Preferences= | ||
You should set up your debugging environment in the same way you would for extension development. A nice guide can be found [http://developer.mozilla.org/en/docs/Setting_up_extension_development_environment here]. | You should set up your debugging environment in the same way you would for extension development. A nice guide can be found [http://developer.mozilla.org/en/docs/Setting_up_extension_development_environment here]. | ||
=Creating a Patch= | |||
''General documentation [http://developer.mozilla.org/en/docs/Creating_a_patch here]''. | |||
After you have changed everything you wanted to, you should take a look at the [[Calendar:Style_Guide|Style Guide]], to make sure your code follow the calendar style guidelines we use. | |||
Next, you need to create the patch. The following command can be used to create a patch of all *changed* files. Additional commands are needed if you added new files. If possible, you should always do the diff inside the <code>$MOZILLA/calendar</code> directory, so its easy to apply the patch. | |||
<pre> | |||
cd $MOZILLA/calendar | |||
cvs diff -u -U8 -p > ~/my_first_bug.diff | |||
# To add a single new file to the patch | |||
diff -upN /dev/null base/content/path/to/file >> ~/my_first_bug.diff | |||
# To add all new files to the patch (advanced) | |||
for i in `cvs -n up 2>/dev/null | grep '^?' | awk '{print $2}'`; do diff -upN /dev/null $i >> ~/my_first_bug.diff; done | |||
</pre> | |||
Now take a final look at the patch if it contains everything you wanted it to contain. You are ready to upload the patch to the bug. If there is no bug for your patch yet, you can [https://bugzilla.mozilla.org/enter_bug.cgi?product=Calendar&rep_platform=All&op_sys=All create one]. | |||
You will need to request review from someone specific to make sure your patch is looked at. Take a look at the [[Calendar:Module_Ownership|Module Ownership]] page to find a reviewer. In general you can pick the first reviewer of the module you changed, but to be nice, you should take a look at each reviewer's [https://bugzilla.mozilla.org/request.cgi?action=queue&requester=&product=Calendar&type=review&requestee=&component=&group=requestee Request Queue] to find out who doesn't have too much to do. Note that some reviewers are not active, the module ownership page has the details though. | |||
If you changed UI, its always a good idea to add a screenshot and request ui-review from a ui-reviewer. See also the module ownership page. | |||
=Troubleshooting= | =Troubleshooting= | ||
If you are having trouble, feel free to ask in #calendar on irc.mozilla.org. If you find no help there, try #developers. Do read the [http://developer.mozilla.org/en/docs/Build_Documentation Mozilla documentation] before asking. | If you are having trouble, feel free to ask in #calendar on irc.mozilla.org. If you find no help there, try #developers. Do read the [http://developer.mozilla.org/en/docs/Build_Documentation Mozilla documentation] before asking. | ||