Changes

Changes to Working on mozbase require peer review is the same as working on any other part of a properly filed bugthe mozilla-central source tree. Here's See the following links for tips on getting set up with Mercurial and how to submit a workflow that will help you make changes to mozbase in isolation.patch:

* If there isn't one already on file, [https://bugzilladeveloper.mozilla.org/enter_bug.cgi?product=Testing&component=Mozbase&cc=:jhammel create a bug] corresponding to your issue in the mozbase bugzilla component.en-US/docs/Mercurial* Inside the mozbase checkout, create a local branch corresponding to your bughttps:  git checkout //developer.mozilla.org/en-b bug-xxxxxxxUS/docs/Installing_Mercurial* ''Develop your patch'' * If people commit work to the master branch while you're working on your patch, you can make things up to date by issuing the following commands from your checked out branchhttps:  git pull origin master git rebase master * When you're happy with your work, commit your changes, giving them a descriptive title from the bug summary:  Bug 706981 - Check for DistributionNotFound error * Generate a patch for your bug  git format-patch HEAD^ * Attach the patch to the bug and ask the appropriate person for review//developer. If further changes are required, you can amend changes to your patch by using 'git commit --amend'. When you're all done, ask someone with mozbase commit privileges to merge your changes into the mozilla mozbase repository. This is a recommended way of working with mozbase. In general the important things are:org/en-US/docs/Mercurial_Queues* having an bug filed in [https://bugzilladeveloper.mozilla.org bugzilla]/en-US/docs/Mercurial_FAQ* having a patch on bugzilla that applies against [https://githubdeveloper.mozilla.comorg/mozillaen-US/docs/Developer_Guide/mozbase the mozbase github repository] master 'HEAD' Please don't use github pull requests. This again requires us to do more work duplicating the pull request and associated patch in bugzillaHow_to_Submit_a_Patch