Changes

Jump to: navigation, search

Auto-tools/Projects/Mozbase

1,426 bytes removed, 16:50, 20 February 2014
Check-in policy
We currently run tests automatically on every mozilla-central commit. They are run as part of make check in the build job, but {{bug|966441}} tracks pulling them out into a separate job.
 
=== Check-in policy ===
 
==== Review Policy ====
 
'''All''' changes should be reviewed before landing. The one exception is version bumps. See https://wiki.mozilla.org/Auto-tools/Projects/MozBase#Versioning for how these are done.
 
If you have admin permissions to the upstream [https://github.com/mozilla/mozbase mozbase repository], you can land the reviewed patch on your own. Otherwise you should ask someone else to get the patch landed.
 
==== Landing the patch ====
 
'''Please never use the Github auto-merge feature!'''
 
To land the patch on the target branch make use of the '''git merge --squash''' command, which will land the patch as a single commit. After running this command you will have to issue a new commit message before being able to push the changes. Make sure that you add the right author if the patch wasn't created by yourself. Also use the right commit message format as shown below which includes the bug number and the list of reviewers.
 
Here an example how to land a patch from the '''feature''' branch onto '''master''':
 
* git pull origin master # make sure master is up to date
* git checkout feature
* git rebase master # make sure patch is a strict descendant of master
* '''TEST''' the patch by [https://wiki.mozilla.org/Auto-tools/Projects/MozBase#Running_the_tests running existent tests]
* git checkout master
* git merge feature
* git push git@github.com:mozilla/mozbase.git master
=== Versioning ===
Confirm
651
edits

Navigation menu