Confirmed users
1,008
edits
Sheriffing/How To/Landing patches: Difference between revisions
Jump to navigation
Jump to search
Sheriffing/How To/Landing patches (view source)
Revision as of 12:56, 24 February 2014
, 24 February 2014no edit summary
No edit summary |
No edit summary |
||
| Line 12: | Line 12: | ||
** Bug number | ** Bug number | ||
** Commit message (keeping in mind that the commit message should be a brief description of what the patch is <u>doing</u>) | ** Commit message (keeping in mind that the commit message should be a brief description of what the patch is <u>doing</u>) | ||
*** Format should be something like "Bug 123456 - Add a null check to XYZ to avoid a crash. r=somebody" | |||
* If a patch is missing commit information, remind the patch author to include it for future patches with a link to the [https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Mercurial FAQ page] that describes how to set it. | * If a patch is missing commit information, remind the patch author to include it for future patches with a link to the [https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Mercurial FAQ page] that describes how to set it. | ||
* When the patches are applied cleanly and the commit information is correct, push to the appropriate integration branch and mark the bugs via mcMerge. | * When the patches are applied cleanly and the commit information is correct, push to the appropriate integration branch and mark the bugs via mcMerge. | ||
** mcMerge will clear the checkin-needed bug keyword. You will need to manually clear checkin-needed if on the whiteboard or set checkin+ if the checkin? patch flag is set. | ** mcMerge will clear the checkin-needed bug keyword. You will need to manually clear checkin-needed if on the whiteboard or set checkin+ if the checkin? patch flag is set. | ||