TPE-Layout/2016-11-08

From MozillaWiki
Jump to: navigation, search

Weekly Summary

  • CSS Masking
  1. Mask shorthand support - bugs bug 1234485 and bug 1301638 are the only 2 remaining to be fixed before ship. Reviewing is ongoing and in good progress. Target to enable from the beginning of FF53. Intent to ship mail will be updated soon.
  2. Clip-path support - bugs bug 1246741 and bug 1313898 to be fixed before pref-ing on on nightly and aurora. Both bugs depend on bug 1234485, would be handled by CJ and target to enable on FF53.
  • CSS Shapes
  1. shape-outside - bug bug 1291110 and bug 1309467 are waiting for dbaron’s review, will get good progress since dbaron is in TPE office this week.
  • CSS Initial-letter
  1. initial-letter support - bug bug 1310106 is under review by :jfkthame. Meantime, a spec issue filed to ask for behavior definition when ‘initial-letter’ & ‘float’ both set to same element/pseudo-element.
  • Printing
  1. Studying how macOS is able to support PDF printing.
  2. Done the support matrix investigation across platforms.
  3. Problems to be addressed with Evelyne
    • Print preview support.
    • Embed element PDF support.
    • Platform windows EMF printing support.
    • PDF printing on linux & macOS.

Weekly Status

Astley Chen

  • bug 1301638 - Using runtime pref to enable/ disable CSS mask properties
    • r+ - use fail-if to handle relevant test cases.
  • bug 1304636 - [css-grid][css-flexbox] A {flex,grid} item's min-{width,height} "auto" value should be reported as "auto" in getComputedStyle()
    • WIP

Boris Chiou

Web Animations API

  • bug 1286150 - Support paced spacing for basic shapes
    • land
  • bug 1273784 - Implement keyframe effect copy constructors
    • land
  • bug 1286151 - Support paced spacing for filter property
    • study

CSS Transition

  • bug 1292001 - Make sure reversing an exist transition still works if the effect is removed/replaced
    • study

Animations

  • bug 1304886 - Assertion failure: "accumulateResult || prop.mProperty == eCSSProperty_filter (could not accumulate value)" with animate(...,{iterationComposite:"accumulate"})
    • review

Cameron McCormack

Stylo

  • bug 1288302 - Stylo: implement support for background-image: url()
    • r+ | land
  • bug 1310560 - stylo: support url() values in cursor
    • r+
  • bug 1315155 - use nsStyleImageRequest in nsStyleContentData
    • r+
  • working on mozilla-central -> incubator/stylo merge, which lead to the following bug:
  • bug 1315632 - stylo: leave old style on frames when nsChangeHint_ReconstructFrame was generated
    • r+ | land

Reviews

  • bug 1294299 - Stylo: Implement CSSStyleDeclaration for Element.style
    • r
  • bug 1303623 - Parsing mask-clip/mask-origin: fill-box|stroke-box|view-box|no-clip values
    • r

CJ Ku

  • bug 1234485 - Draw image mask onto mask layer
    • r?
  • bug 1305253 - In nsSVGIntegrationUtils::PaintMaskAndClipPath, manually pop up clip-path
    • r+
  • bug 1310575 - Intermittent file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/bugs/621253-2-externalFilter.html
    • land
  • bug 1310575 - Change the parameter of ValidateSVGFrame in nsSVGIntegrationUtils.cpp
    • land
  • bug 1313898 - Draw clip-path onto mask layer
    • WIP
  • bug 1313877 - Draw SVG mask onto mask layer
    • WIP
  • bug 1314001 - Implement pref:layers.paintMask
    • r+

Farmer Tseng

  • Mortar would like to generate emf file for Windows printing
    • Write a sample code to print emf file in Windows.
      • done
  • Mortar would like to generate PDF for Linux/MacOS printing
    • Study Mac OS x API and Write a sample code to print PDF in Mac OS
      • WIP

Jeremy Chen

Initial-letter

Servo

Shing Lyu

Stylo:

  • Submitted drop-shadow patch for review

Servo

  • Try to write the gfx part for drop-shadow filter, traced code
  • Write and tested basic path (content size only) case for flexbox min-size:auto
  • Submitted spec bug https://github.com/w3c/csswg-drafts/issues/671
  • Various patch fixes and rebases

Evangelism:

Tingyu Lin

shape-outside

AccessibleCaret

  • bug 1310509 - Opening new tab when text is selected does not properly dismiss the selection menu
    • land

MFBT

  • bug 1315624 - Delete operator|| and operator&& for CastableTypedEnumResult
    • r?

Tommy Kuo

  • bug 1313601 - Disable presentation mode when taps disconnect from Chromecast on Android Notification Bar.
    • land
  • bug 1295087 - [Presentation WebAPI] Implement PresentationDeviceProvider for Chromecast devices on Fennec.
    • r+
    • Write test case.
  • bug 1305352 - [Presentation API] Implement PresentationRequestUIGlue for Fennec.
    • r+

Team Affairs

  • David Baron visit from 11/7 ~ 11/11

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics

Status code combination rule
Combine status code with "|". For example

** OOAD|WIP

Which means you work on both OOAD and WIP in the last week.

land status code
If your patch is target for specific branch, instead of central, postfix branch version. For exp

** land(1.4)