From MozillaWiki
Jump to: navigation, search

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

Layout labeling

  • bug 1339343 - Label runnables in layout modules.
    • Break down to define scope and categorize all possible cases with a sense of difficulty.
  • bug 1340351 - Broken Fonts on macOS in Nightly
    • STR found and ni Jonathan Kew to follow up.

Boris Chiou

stylo animations

  • bug 1343753 - stylo: Update CSS transitions with servo's computed values instead of nsStyleContext
    • wip
  • bug 1339704 - stylo: Filter out the CascadeLevel which doesn't need to be styled in GetServoAnimationRule
    • r+ | land

Release Engineering - stylo

  • bug 1344144 - Trychooser: Add the option for linux64-stylo in TryChooser Syntax Builder
    • land


Cameron McCormack

Some sick leave, plus:


  • bug 1291786 - stylo: Deal with mismatch between Gecko's eRestyle_Subtree and servo's RESTYLE_SELF + RESTYLE_DESCENDANTS
    • r+ | land
  • bug 1346623 - anonymous content created with nsIDocument::InsertAnonymousContent can change from non-native to native AC
    • f+


  • bug 1330843 - Allow JS to create NAC pseudo-elements.
    • r+ (still needs some work though)

Stylo reviews

  • bug 1344619 - stylo: Introduce pre-traversal step to update a bunch of stuff that we shouldn't update during the parallel traversal
  • bug 1341985 - stylo: Mark element which needs to create/remove/modify CSS animations during traversal and create/remove/modify the animations after the parallel traversal
  • bug 1341705 - stylo: reenable the "289480.html#top" reftest
  • bug 1345362 - stylo: Make -moz-pagebreak anonymous boxes non-inheriting, so their style doesn't depend on their parent
  • bug 1345804 - Change mWillChange to hold list of nsIAtom rather than string
  • bug 1315601 - stylo: Implement access to CSSMediaRule
  • bug 1303229 - stylo: Supply correct viewport size when restyling (affects viewport units)
  • bug 1314045 - Stylo debug crash in layout/reftests/font-inflation/list-1.html: "ASSERTION: Bad loading table"
  • bug 1296477 - stylo: Implement content: {counter(..), counters(..), url(..), attr(..)}
  • bug 1346655 - stylo: Fill animation/transition properties that the length of the property is less than the length of animation-name

Other reviews

  • bug 1345052 - Remove EffectProperties::MightHaveNoneSVGMask
  • bug 1345356 - Update a few comments about animation handling
  • bug 1345377 - Implement URLValueData::HasRef()
  • bug 1343139 - Assertion failure: !preTransformOverflows (GetVisualOverflowRect() won't return the pre-effects rect!
  • bug 1345739 - In nsComputedDOMStyle::SetValueToStyleImage, use the URL stored in the nsStyleImage's mImageValue if we had some problem resolving the imgRequestProxy
  • bug 1305754 - Don't rebuild the path when resolving style with replacement.


Farmer Tseng

Mortar Printing

  • bug 1345710 - [Mortar] [Windows] Implement Emf, PDFEngineExports and PdfPrintHelperWin
    • r? Bug 1345710 - part1: implement Emf class to support Windows Enhance Metafile
    • r? Bug 1345710 - part2: implement PDFEngineExports to export pdfium functions
    • r? Bug 1345710 - part3: implement PdfPrintHelperWin to convert PDF to EMF
    • r? Bug 1345710 - fix nsWindowsGfx.cpp build break
  • bug 1345786 - [Mortar] [Windows] Convert PDF to EMF in plugin process and print EMF page by page in parent process
    • file
  • bug 1345783 - [Mortar] [Windows] Load PDF into pdfium library and return a number of total pages to parent process
    • file
  • bug 1346086 - [Mortar] [Windows] Using Windows GDI functions to create/save EMF DC in sandboxed plugin process
    • file

Jeremy Chen

CSS hyphens property

CSS text-justify property

  • bug 1345498 - stylo: implement/parse text-justify and its gecko glue
    • file | land

Label runnables in layout modules

  • bug 1342873 - Label runnables in layout/tables/
    • r+ | land


  • bug 1346321 - MozReview "virtual" commit-message file should not be returned by the "Download Diff" url.
    • investigate and provide feedback
  • #90 - git bz apply doesn't get the right authorship from mozreview
    • provide PR

Shing Lyu

Tingyu Lin


  • bug 1326409 - Implement the rendering of basic shape polygon() for CSS shape-outside
    • Land


  • bug 1345202 - Preemptively fix unified bustage in layout/svg
    • Review
  • bug 1344954 - Preemptively fix unified build bustage in layout/generic
    • Review
  • bug 1342994 - Convert nsPrintObject "mKids" array to use UniquePtr
    • Land


  • bug 1341588 - Long tapping in blank in a cell which only has a word and adjacent cells only has a replaced element causes selects the word and replaced elements on Android
    • Land
  • bug 1273045 - AccessibleCaret does not scroll together with the overflow:scroll div
    • feedback | WIP

Tommy Kuo

Layout Labeling

  • bug 1342867 - Label runnables of ScrollOnFocusEvent in nsTextControlFrame.cpp
    • WIP | debug
  • bug 1342863 - Label runnables in layout/base/
    • WIP | debug

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics