TPE-Layout/2017-05-16

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

Boris Chiou

  • bug 1365091 ASSIGNED:: stylo: Enable transition-and-animation-with-different-durations.html
    • Reviewed bug bug 1365091 - stylo: Enable transition-and-animation-with-different-durations.html
  • bug 1334036 ASSIGNED:: stylo: Support off-main-thread animations
    • Addressed reviewers' comments for bug bug 1334036 - stylo: Support off-main-thread animations
  • bug 1364004 RESOLVED::FIXED Rename css-timing-1 to css-timing
    • Filed bug bug 1364004 - Rename css-timing-1 to css-timing
    • Landed bug bug 1364004 - Rename css-timing-1 to css-timing
  • bug 1364795 RESOLVED::FIXED web platform tests for composite: 'accumulate'
    • Reviewed bug bug 1364795 - web platform tests for composite: 'accumulate'

Cameron McCormack

  • bug 1364361 ASSIGNED:: stylo: AllChildrenIterator doesn't find NAC created by non-primary frames of elements
    • Uploaded patch for bug bug 1364361
  • bug 16831 Invalid bug or security bug
  • bug 16806 Invalid bug or security bug
  • bug 1339629 NEW:: stylo: ServoStyleSheets don't handle modification in the presence of cloned inners correctly
    • Reviewed some of the patches in bug bug 1339629
  • bug 1361235 RESOLVED::FIXED stylo: <select> and other tags leak during shutdown after scrollbar sheet is enabled
    • Landed bug bug 1361235
    • Uploaded patches for bug bug 1361235
  • bug 1352306 NEW:: stylo: track the attributes and state that a DependencySet is sensitive to, and use it to cull snapshot creation
    • Landed bug bug 1352306
  • bug 1356916 RESOLVED::FIXED stylo: inline canvas width and height are not reflected
    • Reviewed bug bug 1356916
  • bug 1328319 NEW:: stylo: Implement @counter-style
    • Reviewed some more patches in bug bug 1328319
    • Reviewed some patches of bug bug 1328319
  • bug 1364589 RESOLVED::FIXED AppendDocumentLevelNativeAnonymousContentTo should include the custom content container
    • Reviewed bug bug 1364589
  • bug 1364845 NEW:: stylo: add support for a "re-run selector matching on children only" restyle hint
    • WIP patches for bug bug 1364845
  • bug 16824 Invalid bug or security bug
  • bug 1364412 NEW:: stylo: Support state selectors in pseudo-elements.
    • Reviewed one patch of bug 1364412
  • bug 1363572 RESOLVED::FIXED stylo: ServoStyleSet's mUniqueCountId needs to be 64-bit
    • Reviewed bug bug 1363572
  • bug 1363699 RESOLVED::FIXED Make named CounterStyle not refcounted
    • Reviewed bug bug 1363699
  • bug 1364338 RESOLVED::FIXED Negative CSS outline not rendering correctly when changed with JavaScript
    • Reviewed bug bug 1364338
  • bug 1289868 NEW:: stylo: Use the result of CalcStyleDifference to cull parallel DOM traversal
    • WIP patches for bug bug 1289868
  • bug 1363961 RESOLVED::FIXED stylo: AttrHasSubstring gets its strings backwards
    • Reviewed bug bug 1363961

CJ Ku

  • Try to understand matt's thought about retained display list(https://docs.google.com/document/u/1/d/1RxUl0z5ViwyAbcQgYvUoorjIQ38M5ZGwwjljBujgE7o/pub)
  • Try to understand the relationship among AGR ASR DisplayList and DisplayListBuilder
  • bug 1363855 RESOLVED::DUPLICATE transitions involving transformations inside of a masked region cause graphic glitches
    • Bug bug 1363855 working on patch
  • bug 1361180 RESOLVED::FIXED Graphics on Yahoo Finance not displaying properly
    • Bug bug 1361180 prepare uplift patch
  • bug 1343139 RESOLVED::FIXED Assertion failure: !preTransformOverflows (GetVisualOverflowRect() won't return the pre-effects rect!
    • Bug bug 1343139 land follow up
  • bug 1364273 RESOLVED::FIXED stylo: Initial value of mask-repeat should be repeat instead of no-repeat
    • Bug bug 1364273 create a pull request
  • bug 1362000 NEW:: New graphics compositor and SVG matrixes bug
    • Update patch for bug bug 1362000
  • bug 1350663 NEW:: [css-mask] mask-image failure at position: fixed
    • Bug bug 1350663 r?
    • Bug bug 1350663 update WIP
    • Figure out bug bug 1350663
  • bug 1310885 NEW:: stylo: keep CSS images alive while their corresponding rule is in the style sheet
    • Bug bug 1310885 create a pull request
    • Bug bug 1310885 fix test failure
  • bug 1356179 RESOLVED::FIXED SVG rendering: Thin lines not displayed
    • Bug bug 1356179 address mstange's comment
    • Bug bug 1356179 land
    • Bug bug 1356179 submit patches
  • bug 13506 VERIFIED::FIXED fix news connection cache
    • Bug bug 13506WIP

Eric Tsai

Farmer Tseng

  • Integrate mortar patches on new code base. Status: It could send PDF file path to plugin process.
  • bug 1329881 ASSIGNED:: [Mortar] [Windows] Create an interface to send PDF file name and printing setting to chrome process, then configure print job
    • Explain patches to Bruce and Louis, Bug bug 1329881
    • Upload patches on Bug bug 1329881
    • Upload patches on Bug bug 1329881
    • Verified patches, they work in e10s mode and non-e10s mode, Bug bug 1329881
  • bug 1359713 ASSIGNED:: [Mortar] [Windows] Implement LoadDocument by path in PDFiumEngineShim
    • Upload a patch on Bug bug 1359713.
  • bug 1345789 NEW:: [Mortar] [Windows] setup an IPC between parent process and plugin process
    • Handle multi-doc in printhelper, Bug bug 1345789
    • Integrate Louis's patch and test EMF printing, hit crash while sandbox level is set to 2, Bug bug 1345789
    • Integrate mortar patches on new code base. Status: It could send PDF file path to plugin process, Bug bug 1345789

Jeremy Chen

  • bug 1363295 RESOLVED::FIXED stylo: fix the serialization of image-orientation property
    • Relanded Bug bug 1363295
  • bug 1363000 RESOLVED::FIXED stylo: Using <select> elements in SVG documents causes leaks in crashtests
    • Got r+ in ~10secs and landed Bug bug 1363000
    • Uploaded a patch and pushed a try before asking for review [Bug bug 1363000]
  • bug 1363592 RESOLVED::FIXED stylo: {transition, animation}-duration should reject negative values
    • Reviewed Bug bug 1363592
  • bug 1364795 RESOLVED::FIXED web platform tests for composite: 'accumulate'
    • Reviewed Bug bug 1364795
  • bug 1355721 ASSIGNED:: stylo: Implement @font-feature-values rule support
    • Read spec and figure out the relationships between the font-variant-alternates property and the @font-feature-values rule [Bug bug 1355721]

Louis Chang

  • bug 1363291 - Handle save to file when printing pdf without e10s failed
    • file | r+ | land
  • bug 1358347 - Implement back-end part of find whole-word function
    • WIP
  • bug 1346882 - Set title to document name for print to file
    • ni Vance
  • bug 1347440 - Integrate building rpc.cc into mozbuild instead of checking it into m-c
    • addressed comments | resubmit patches
  • bug 1329881 - Create an interface to send PDF file name and printing setting to chrome process, then configure print job
    • f

Shing Lyu

Ting-Yu Lin

  • bug 1363640 NEW:: stylo: Enable stylo for XBL documents
    • File bug bug 1363640

Tommy Kuo

  • bug 1358993 ASSIGNED:: stylo: ServoStyleSheet::ParseSheet should disconnect child sheets / mRuleList, and re-use child sheets
    • Architecture design (bug bug 1358993)
    • Refactor LoaderReusableStyleSheets to store StyleSheet objects. (bug bug 1358993)

Ya-Chieh Wu

  • bug 1360494 NEW:: [Mortar] 'stage-package' failed after adding '--enable-mortar' configuration
    • Add mochitest for Bug bug 1360494
    • Bug bug 1360494 - [Mortar] 'stage-package' failed after adding '--enable-mortar' configuration. f+
    • R? for bug bug 1360494
    • Work on Bug bug 1360494
  • bug 1328543 NEW:: [jsplugins] colors are wrong while changing, resizing, scrolling pages on pdf
    • Bug bug 1328543 - [jsplugins] colors are wrong while changing, resizing, scrolling pages on pdf. f+
    • Bug bug 1328543 submit patch

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics