TPE-Layout/2017-11-28

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

Weekly Sharing

  • Astley Chen
    • Enable Apache, PHP on macOS
    • bug 1404468 - Various websites like GitHub load with flash of unstyled content (FOUC)
    • FOUC issues
      • Bug 712130 - Autofocus should apply after the styles are applied (some pages scroll down sometimes after loading, some pages have flash of unstyled content (fouc))
      • bug 1420362 - <iframe> is causing a flash of unstyled content (FOUC) issue

Weekly Status

Astley Chen

  • bug 1419786 RESOLVED::DUPLICATE Polygon position is shifted in http://razvancaliman.com/css-shapes-espresso/
    • Bug 1419786 - fired a bug in shapes highlighter
  • bug 1420362 NEW:: <iframe> is causing a flash of unstyled content (FOUC) issue
    • Bug 1420362 - filed a new FOUC case when a document has iframe within it.
  • bug 1404468 NEW:: Various websites like GitHub load with flash of unstyled content (FOUC)
    • Bug 1404468 - FOUC on Github page and easily reproducible on RDM with throttled network speed.

Boris Chiou

  • bug 1418806 ASSIGNED:: Crash in core::result::unwrap_failed<T> | geckoservo::glue::Servo_AnimationCompose
    • Investing bug 1418806 - Crash in core::result::unwrap_failed<T> | geckoservo::glue::Servo_AnimationCompose
    • Is still investing bug 1418806 - Crash in core::result::unwrap_failed<T> | geckoservo::glue::Servo_AnimationCompose
  • bug 1408310 ASSIGNED:: make WebKitCSSMatrix use Servo for parsing transform lists
    • Addressed reviewers' comments for bug 1408310 - make WebKitCSSMatrix use Servo for parsing transform lists
  • bug 1420791 RESOLVED::FIXED Tidy up animation_utils.js
    • Reviewed bug 1420791 - Tidy up animation_utils.js
  • bug 1408303 ASSIGNED:: make FontFaceSet and FontFace use Servo for parsing font descriptors and properties
    • Wrote patches for bug 1408303 - make FontFaceSet and FontFace use Servo for parsing font descriptors and properties
  • bug 1420774 RESOLVED::FIXED Drop virtual from some Animation methods
    • Reviewed bug 1420774 - Drop virtual from some Animation methods

Cameron McCormack

  • Reviewed https://github.com/servo/servo/pull/19341
  • Working on campus seeding quantum/rust presentation
  • bug 1420071 RESOLVED::FIXED stop using nsMediaExpression_Range in Rust code
    • Uploaded patch for bug 1420071
  • bug 1420113 RESOLVED::FIXED move nsCSSFontFaceRule and nsCSSCounterStyle rule definitions out of nsCSSRules.cpp
    • Uploaded patches for bug 1420113
  • bug 951793 RESOLVED::FIXED Add support for 'overscroll-behavior'
    • Reviewed a patch in bug 951793
  • bug 1419645 RESOLVED::FIXED make VerifyReflow work with stylo
    • Uploaded patch for bug 1419645
  • bug 1420026 ASSIGNED:: replace one more use of nsCSSParser::ParseColor with ServoCSSParser::ComputeColor
    • Uploaded patch for bug 1420026
  • bug 1420039 RESOLVED::INVALID GroupRuleRuleList::GetParentObject should return a ServoStyleSheet too
    • Uploaded patch for bug 1420039
  • bug 1417781 RESOLVED::FIXED Stylo: Hovering visited links doesn't use the color defined by site's sheet
    • Reviewed bug 1417781
  • bug 1420056 RESOLVED::FIXED MobileViewportManager and ZoomConstraintsClient constants clash due to unified build
    • Uploaded patch for bug 1420056
  • bug 1408310 ASSIGNED:: make WebKitCSSMatrix use Servo for parsing transform lists
    • Reviewed bug 1408310
  • bug 1417725 NEW:: Add a prefixed alias (behind a pref) for column-span property since all other multicol properties have a -moz- alias
    • Reviewed bug 1417725
  • bug 1419652 RESOLVED::FIXED remove HandleRefPtr
    • Uploaded patch for bug 1419652
  • bug 1420383 RESOLVED::FIXED move nsCSSProps::kParserVariantTable definition out of nsCSSParser.cpp
    • Uploaded patch for bug 1420383
  • bug 1420755 RESOLVED::FIXED Some dynamic changes to the stylesheet media list don't get reflected.
    • Reviewed bug 1420755
  • bug 1418963 RESOLVED::FIXED Expose -moz-os-version and related media queries in userChrome.css
    • Reviewed bug 1418963
  • bug 1420117 ASSIGNED:: replace uses of nsCSSParser in nsCSSCounterStyleRule.cpp with Servo parser calls
    • Uploaded patches for bug 1420117
  • bug 1418433 ASSIGNED:: stylo: window.getComputedStyle(element, null) would not get correct data for display: none element
    • Reviewed bug 1418433
  • bug 1417837 NEW:: de-scope the style sheets in aboutReader.html
  • bug 1417824 RESOLVED::FIXED stylo: both "Open with" and "Save File" radio buttons on file save dialog are highlighed on Mac
    • Reviewed bug 1417824
  • bug 1420713 RESOLVED::FIXED No live preview of userChrome.css changes with layout.css.servo.chrome.enabled = true
    • Reviewed bug 1420713
  • bug 1419709 RESOLVED::FIXED move a few more static methods out of nsRuleNode.h
    • Uploaded patch for bug 1419709
  • bug 1420379 ASSIGNED:: move css::Rule implementation to its own file
    • Uploaded patch for bug 1420379
  • bug 1418224 NEW:: stylo: support shape-outside: <image>
    • Reviewed bug 1418224
  • bug 1419554 RESOLVED::FIXED Assertion failure: !node->AsElement()->HasServoData(), at /src/dom/base/nsDocument.cpp:4271
    • Reviewed bug 1419554

CJ Ku

  • bug 1207734 Implement individual transform properties: the 'translate', 'scale', and 'rotate' properties
    • WIP

Eric Tsai

Jeremy Chen

  • bug 1420724 RESOLVED::FIXED fix unnecessary duplicated code in nsCSSFrameConstructor.h
    • Filed and Landed Bug 1420724
  • bug 1418433 ASSIGNED:: stylo: window.getComputedStyle(element, null) would not get correct data for display: none element
    • Debug bug 1418433
    • Investigated and updated some progress [Bug 1418433]
    • Landed Bug 1418433
    • Uploaded patches for review [bug 1418433]
  • bug 1283222 ASSIGNED:: Unwanted line-break opportunities at out-of-flow frames [was: Commas wrapped to beginning of line with text-align: justify]
    • Investigated and updated the progress [Bug 1283222]
    • Uploaded a reduced testcase to Bug 1283222

Louis Chang

  • bug 1417751 - Implement -moz-appearance: inner-spin-button which behave like -webkit-appearance: inner-spin-button
    • WIP

Ting-Yu Lin

  • Submitted https://github.com/servo/servo/pull/19312
  • bug 1420026 ASSIGNED:: replace one more use of nsCSSParser::ParseColor with ServoCSSParser::ComputeColor
    • Reviewed bug 1420026.
  • bug 1419337 RESOLVED::FIXED Remove aStyleContext parameter from nsFrameConstructorState::AddChild
    • Reviewed bug 1419337.
  • bug 1418245 RESOLVED::FIXED move @-moz-document matching function out of nsCSSRules.cpp
    • Reviewed bug 1418245.
  • bug 1404222 ASSIGNED:: Support shape-outside: <image>
    • Uploaded patches for bug 1404222.
  • bug 1419652 RESOLVED::FIXED remove HandleRefPtr
    • Reviewed bug 1419652.
  • bug 1418224 NEW:: stylo: support shape-outside: <image>
    • Addressed review comments for bug 1418224.
    • Uploaded patches for bug 1418224.

Tommy Kuo

  • <select> dropdown proto
    • Allow dropdown frame to find the correct parent frame when open devtools
    • Allow nsListControlFrame to receive mouse event
    • Attempt to make ListControlFrame be an absoulute frame in Stylo
    • Debug for the missing event on dropdown list
    • Figure out the reason that causes the crash when doing repaint after clicking an option
    • Fixed the width of dropdown menu and make it as same as the width of combobox
  • bug 1419247 RESOLVED::FIXED Allow Stringify() to support nsSize.
    • File bug and upload patch to ask review (Bug 1419247)
    • Land (bug 1419247)
  • bug 1419337 RESOLVED::FIXED Remove aStyleContext parameter from nsFrameConstructorState::AddChild
    • Land (bug 1419337)

Ya-Chieh Wu

  • bug 1405929 NEW:: [BC] rowspan on border-collapse is wrong.
    • R? bug 1405929
  • bug 752790 NEW:: Input padding covers text when the padding is greater than (TextHeight - InputHeight)/2
    • Debug Bug 752790

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics
Retrieved from "https://wiki.mozilla.org/index.php?title=TPE-Layout/2017-11-28&oldid=1184861"