Talk:DXR UI Refresh

From MozillaWiki
Jump to: navigation, search

Basic Search

Auto-checking case-sensitivity can be confusing, especially if that was a typo and the user later removes the upper case - not unchecking gives unexpected behaviour (adding and then removing isn't the same as nothing), but unchecking is also unexpected if the check was added manually. --Mook (talk) 22:35, 25 July 2013 (PDT)

I agree. I'm inclined to omit all that automatic magic and simply provide an accesskey for the case-sensitivity control. Based on talking with users, the default should be case-insensitive, which is different from current behavior. How does that sound? --Erikrose (talk) 10:23, 26 July 2013 (PDT)
Sounds good. Assuming a <label> to make the checkbox easy to click too. --Mook (talk) 22:55, 31 July 2013 (PDT)

Maybe move the advanced disclosure toggle to the right of the bottom of the logo (and have the status text go to the right of that), for a taller click area? I don't like to click targets less than about 20px tall... --Mook (talk) 22:35, 25 July 2013 (PDT)

Perhaps. What you see there is about the 5th iteration of the disclosure control. I have another that's pretty decent, and it's easier to target—about 20x60 px—but I felt it was visually confusing. Hmm, what if we made the area of the bar immediately around the "advanced" caption higher, as if it had a tab? That would combine the best of each. I'll sketch it up and see how it plays. --Erikrose (talk) 10:23, 26 July 2013 (PDT)
As long as it's decently tall and not really narrow, I'm happy. Think icon-sized. --Mook (talk) 22:55, 31 July 2013 (PDT)

If we really end up with >1000 results, do we still want to show all of them? (Contrast with what MXR does; this is mostly a "arghh my browser is too slow I should stop using Firefox" thing) --Mook (talk) 22:35, 25 July 2013 (PDT)

We don't show 1000 results at a time even now, for just that reason; I planned on continuing our current infinite-scroll thing, though there are also advantages to traditional pagination. Either way, that can be changed any time without affecting the rest of the UI. --Erikrose (talk) 10:23, 26 July 2013 (PDT)

Advanced Search

Yay for having the advanced UI always available (just initially hidden).

Would defaulting to searching in the current scope be useful? (The button can instead clear / reset the scope) --Mook (talk) 22:35, 25 July 2013 (PDT)

Where that becomes confusing is in the file view: when you're looking at a single source file, what folder are searches scoped to? Here's another possibility. I suspect that a common search-within-folder workflow is to first browse to the folder, then do a search. We could stick some kind of "search inside here" control in the file-browsing area, and that would add path:whatever to the search field (and the advanced form, of course). --Erikrose (talk) 10:23, 26 July 2013 (PDT)
I think I'll need to actually see this in action to figure things out, unfortunately. I was mostly thinking about directory views anyway. --Mook (talk) 22:55, 31 July 2013 (PDT)

File View

I find that the extra spacing between path components in the header makes it look nothing like a path; would it be possible to not have that excess padding, and rely only on text colour to make it look like the parts are clickable? The thing about copying is a good point though... but I'm personally more likely to copy from the address bar, on account of the keyboard hotkey to get there (I have no idea why I still use Alt+D) --Mook (talk) 22:35, 25 July 2013 (PDT)

Some people copy from the viewport area; the spacing was a requested feature from them. Now that I've reduced the font size, does it appear less confusing to you? --Erikrose (talk) 10:23, 26 July 2013 (PDT)
Yes! I guess it was only due to the actual width and not the relative width? --Mook (talk) 22:55, 31 July 2013 (PDT)

The path pinning - heck, maybe even the search box pinning - should be using CSS media queries, and don't pin if the window height is too small? --Mook (talk) 22:35, 25 July 2013 (PDT)

Actually, forget the pinning. Initially, I wanted to pin the search box, but I didn't write down my reasoning, and it seems like a bad idea now. There's nothing up there you'd constantly need to see while browsing results, and most other search engines don't pin. You can always get back to the top with a single Home press if you need to. --Erikrose (talk) 10:23, 26 July 2013 (PDT)
I was mostly using the pinning in MXR to get links to things like blame and tree-switching without losing the scroll position (because I'm likely to come back to the file page - blame is really, relaly horrible for actual code browsing). I'd be okay with the thing being behind a disclosure when scrolled off, though? (But this might be hard to implement.) --Mook (talk) 22:55, 31 July 2013 (PDT)