Personal tools

User:Bwinton/Commit Checklist

From MozillaWiki

Jump to: navigation, search

Contents

Pre-Commit Checklist

Mercurial

hg import "<url to bugzilla patch>"

Do a diff, and make sure what you're checking in is what you mean to check in.

hg commit (Don't forget the '-u "User Name <email@address">'!)

For the message, use:

Bug 123456 - Description of what the patch does.  ui-r=clarkbw, r=reviewer, sr=super-reviewer, a=approver.

Go to the bug, set the milestone to the version of Thunderbird that the patch landed in, and mark it RESOLVED - FIXED, with a message of:

Committed as http://hg.mozilla.org/comm-central/rev/<hg rev hash>

If the patch was backported to an earlier version of Thunderbird, set the appropriate status-thunderbirdX flag as "fixed"

Go to http://build.mozillamessaging.com/tinderboxpushlog/?tree=Thunderbird and wait for a successful run of your patch.


Subversion

curl -o new.patch "<url to bugzilla patch>"
patch -p 0 < new.patch

Do a diff, and make sure what you're checking in is what you mean to check in.

svn commit

For the message, use:

Bug 123456 - Description of what the patch does. p=patch-author, ui-r=clarkbw, r=reviewer, sr=super-reviewer, a=approver.

Go to the bug, and mark it RESOLVED - FIXED, with a message of:

Committed as http://viewvc.svn.mozilla.org/vc?view=revision&revision=<svn rev number>


CVS

You're on your own, sucker. ;)

Just kidding, but I don't commit stuff to CVS, so I'm going to leave this section blank for now, and hope one of you will help me fill it in.