Platform/HTML5 parser tasks: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Add recently filed P2 bugs)
Line 41: Line 41:
** [https://bugzilla.mozilla.org/show_bug.cgi?id=557197 557197] 
 in element content expands to CR and shows up as a non-collapsing space in layout  
** [https://bugzilla.mozilla.org/show_bug.cgi?id=557197 557197] 
 in element content expands to CR and shows up as a non-collapsing space in layout  
***''Time estimate'': Less than a day if hacked around in the parser. Unknown if fixed more properly in layout.
***''Time estimate'': Less than a day if hacked around in the parser. Unknown if fixed more properly in layout.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=558302 558302] <button> should not be scoping
***''Time estimate'': Trivial (flipping one boolean), but waiting for a spec change first.
*Security review.
*Security review.
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst

Revision as of 08:33, 12 April 2010

This page outlines what needs to be done to 1) enable the HTML5 parser by default on mozilla-central and 2) ship a release with the HTML5 parser enabled by default.

The HTML5 parser has been suitable for dogfooding for over a year and in the past couple of months there have been virtually no new site compat bugs. Thus, the parser is already alpha quality from a user POV but not from a zero test suite regressions POV.

Things that need to be done before turning the HTML5 parser on by default

  • The following are waiting for landings by others
    • 534458 test failure on css3.info selectors test with :checked{}
      • Waiting on lazy frame construction from Timothy Nikkel. (Patch needs updating to deal with unit test failures that have cropped up since the patch was posted for review.)
      • This test failure isn't in a tinderbox suite but on a notable Web site. Thus, turning the HTML5 parser on with this bug unfixed wouldn't result in tinderbox orange.
    • 543726 dom/tests/mochitest/ajax/offline/test_foreign.html fails
      • honzab has a fix.
      • Waiting for review comments getting addressed and super-review.
  • Review the unreviewed parser core code. (sicking)
  • Reviews on existing patches
    • 551344 Patches addressing sicking's review comments (sicking)

Things that need to be done before shipping the HTML5 parser in a final Firefox release

  • Fix "[HTML5]" bugs marked P2. (hsivonen)
    • 482913 Make sure document.write() order for nested scripts is right
      • Time estimate: Hixie's test cases for this can be run in less than a day. If something fails, working out what failed, why it failed and if we want to change code, tests or the spec will take multiple email round-trips through the WHATWG list spanning at least a week.
    • 483209 The HTML5 parser needs limits on internal buffer growth
      • Time estimate: Less than a day.
    • 531016 Make sure the namespace optimizations in 'in scope' algorithms is right
      • Time estimate: Less than a day.
    • 537948 The procedure to fix a <a> around a element is acting weird.
      • Time estimate: Less than a day to discover if this is a parser bug or a spec bug. If this is a spec bug, the time it takes to get a spec fix is unknown.
    • 539210 Revise the translator README to cover all makefile functionality
      • Time estimate: Less than a day.
    • 540480 [Evang?] Hootsuite.com dashboard not loading with HTML5 parser turned on
      • Time estimate: For the time being, I'm treating this as a probable evangelism issue. Site contacted. No idea if/when they react.
    • 548232 Fix the caching of document.written meta charset on wyciwyg channel
      • Time estimate: Unknown. Probably over a week (spanning other concurrent work). This one needs multi-vendor email discussion on the WHATWG list in order to decide what the desired fix should be.
    • 552908 Implement spec changes to SVG </a> and handling
      • Time estimate: Less than a day, provided that reviewers accept slightly ugly code. (A non-ugly solution would seem to require a dramatic refactoring.)
    • 552938 Implement the SVG load event in text/html
      • Time estimate: Less than a day.
    • 555906 </datalist> doesn't implicitly close an <option>
      • Time estimate: Less than a day.
    • 557197 &#13; in element content expands to CR and shows up as a non-collapsing space in layout
      • Time estimate: Less than a day if hacked around in the parser. Unknown if fixed more properly in layout.
    • 558302 <button> should not be scoping
      • Time estimate: Trivial (flipping one boolean), but waiting for a spec change first.
  • Security review.
    • Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
  • Create a "slow tp" test suite for exercising speculative parsing. (bnewman) **What if this suite reveals something bad?

Suspended items that may re-enter the list of release blockers

  • Suspended bugs that were previously P2
    • 482917 Make HTML5 parsing not regress stream data availability to extensions
      • There's now a patch but no way to test it.
      • Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
      • Time estimate: Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)