Platform/HTML5 parser tasks: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
 
(44 intermediate revisions by the same user not shown)
Line 1: Line 1:
This page outlines what needs to be done to 1) enable the HTML5 parser by default on mozilla-central and 2) ship a release with the HTML5 parser enabled by default.  
This page outlines what needs to be done to ship a release with the HTML5 parser enabled by default.  
 
== Things that need to be done before turning the HTML5 parser on by default ==
 
*Frequent timing-sensitive test failures on the real tinderbox
**[https://bugzilla.mozilla.org/show_bug.cgi?id=562328 562328] test_frames.html depends on SimpleTest.waitForFocus(), which makes the test timing-sensitive (I suggest disabling this test -- hsivonen)
*Less frequent unmasked random oranges on the real tinderbox
**[https://bugzilla.mozilla.org/show_bug.cgi?id=562319 562319] test_sibling-matching-parent.html and test_bug270414.html fail intermittently
**[https://bugzilla.mozilla.org/show_bug.cgi?id=562326 562326] bug451286_window.xul (used by test_bug451286_window.xul) fails randomly (I suggest leaving this on to see how often it happens and disabling the test if it happens often -- hsivonen)
*Per sicking's suggestion, make the first flush timer delay equally long to the subsequent delays.
*Waiting for review:
**[https://bugzilla.mozilla.org/show_bug.cgi?id=562631 562631] layout/generic/test/test_bug496275.html makes mochitest-plain time out when the HTML5 parser is enabled (mats) (introduced after the HTML5 parser was briefly turned on)
*Assumed to be fixed:
**[https://bugzilla.mozilla.org/show_bug.cgi?id=562333 562333] jsreftest.html randomly fails with "timed out waiting for onload to fire"


== Things that need to be done before shipping the HTML5 parser in a final Firefox release ==
== Things that need to be done before shipping the HTML5 parser in a final Firefox release ==


* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=482913 482913] Make sure document.write() order for nested scripts is right
** [https://bugzilla.mozilla.org/show_bug.cgi?id=569528 569528] <h5> inside <button> inside <p> implicitly closes the <p>
***Waiting for Hixie to respond to feedback about a test case looking broken.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=579846 579846] HTML5 parser regresses cache-control support in meta pragmas
***''Time estimate'': Hixie's test cases for this can be run in less than a day. If something fails, working out what failed, why it failed and if we want to change code, tests or the spec will take multiple email round-trips through the WHATWG list spanning at least a week.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=579867 579867] Implement July 2010 spec changes to SVG in HTML
** [https://bugzilla.mozilla.org/show_bug.cgi?id=483209 483209] The HTML5 parser needs limits on internal buffer growth
*** Related [https://bugzilla.mozilla.org/show_bug.cgi?id=577416 577416] [https://bugzilla.mozilla.org/show_bug.cgi?id=574884 574884] [https://bugzilla.mozilla.org/show_bug.cgi?id=577418 577418]
***''Time estimate'': Less than a day.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=564098 564098] "ASSERTION: Script global object not ready"
** [https://bugzilla.mozilla.org/show_bug.cgi?id=552908 552908] Implement spec changes to SVG </a> and </font> handling
** [https://bugzilla.mozilla.org/show_bug.cgi?id=577508 577508] Hide old document when new one pops a dialog
***Waiting for Hixie to resolve bugs discovered in the spec text while implementing this.
*Reviews on patches
** [https://bugzilla.mozilla.org/show_bug.cgi?id=552938 552938] Implement the SVG load event in text/html
** [https://bugzilla.mozilla.org/show_bug.cgi?id=574884 574884] &lt;math>&lt;/html> crashes (sicking)
***''Time estimate'': Less than a day, but waiting for the SVG WG to decide whether to remove this event instead.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=570309 570309] -- > closing comments breaks CNN Money (sicking)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=557197 557197] &#13; in element content expands to CR and shows up as a non-collapsing space in layout
** [https://bugzilla.mozilla.org/show_bug.cgi?id=575175 575175] Deal with Unicode decoder consuming -1 bytes (smontagu)
***''Time estimate'': Less than a day if hacked around in the parser. Unknown if fixed more properly in layout.
*Security review.
*Security review.
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
* [https://bugzilla.mozilla.org/show_bug.cgi?id=544994 544994]Create a "slow tp" test suite for exercising speculative parsing. (bnewman)
* [https://bugzilla.mozilla.org/show_bug.cgi?id=544994 544994]Create a "slow tp" test suite for exercising speculative parsing. (who owns this now?)
** ''What if this suite reveals something bad?''
** ''What if this suite reveals something bad?''


Line 40: Line 26:
***Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
***Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
***''Time estimate'': Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)
***''Time estimate'': Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)
==Notable evangelism bugs==
* Bugs that need site-side fixes
** [https://bugzilla.mozilla.org/show_bug.cgi?id=540480 540480] Hootsuite.com dashboard not loading with HTML5 parser turned on
** [https://bugzilla.mozilla.org/show_bug.cgi?id=540480 540480] Hootsuite.com dashboard not loading with HTML5 parser turned on
***Moved over to evangelism.
***Site contacted, contact acknowledged (hsivonen)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=537948 537948] The procedure to fix a <a> around a <tr> element is acting weird.
** [https://bugzilla.mozilla.org/show_bug.cgi?id=553795 553795] Blank page on weer.nl (Windows only)
***Spec issue. No indication so far on whether this is a problem for real-world sites. The HTML5 behavior seems well enough aligned with the IE8 behavior.
***''No owner''
***Bad browser sniffing leads to document.write without an insertion point
** [https://bugzilla.mozilla.org/show_bug.cgi?id=565689 565689] </script> in string literal breaks out of script early on wsecu.org
***Site contacted (mbrubeck)
***''Bank''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=565938 565938] Blank page on LinkedIn Recruiter
***Site rep CCed on the bug.
***Bad browser sniffing leads to document.write without an insertion point

Latest revision as of 15:44, 19 July 2010

This page outlines what needs to be done to ship a release with the HTML5 parser enabled by default.

Things that need to be done before shipping the HTML5 parser in a final Firefox release

  • Fix "[HTML5]" bugs marked P2. (hsivonen)
    • 569528 <h5> inside <button> inside <p> implicitly closes the <p>
    • 579846 HTML5 parser regresses cache-control support in meta pragmas
    • 579867 Implement July 2010 spec changes to SVG in HTML
    • 564098 "ASSERTION: Script global object not ready"
    • 577508 Hide old document when new one pops a dialog
  • Reviews on patches
    • 574884 <math></html> crashes (sicking)
    • 570309 -- > closing comments breaks CNN Money (sicking)
    • 575175 Deal with Unicode decoder consuming -1 bytes (smontagu)
  • Security review.
    • Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
  • 544994Create a "slow tp" test suite for exercising speculative parsing. (who owns this now?)
    • What if this suite reveals something bad?

Suspended items that may re-enter the list of release blockers

  • Suspended bugs that were previously P2
    • 482917 Make HTML5 parsing not regress stream data availability to extensions
      • There's now a patch but no way to test it.
      • Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
      • Time estimate: Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)

Notable evangelism bugs

  • Bugs that need site-side fixes
    • 540480 Hootsuite.com dashboard not loading with HTML5 parser turned on
      • Site contacted, contact acknowledged (hsivonen)
    • 553795 Blank page on weer.nl (Windows only)
      • No owner
      • Bad browser sniffing leads to document.write without an insertion point
    • 565689 </script> in string literal breaks out of script early on wsecu.org
      • Site contacted (mbrubeck)
      • Bank
    • 565938 Blank page on LinkedIn Recruiter
      • Site rep CCed on the bug.
      • Bad browser sniffing leads to document.write without an insertion point
Retrieved from "https://wiki.mozilla.org/index.php?title=Platform/HTML5_parser_tasks&oldid=239130"