Platform/HTML5 parser tasks: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Remove a done item)
 
(144 intermediate revisions by 5 users not shown)
Line 1: Line 1:
This page outlines what needs to be done to 1) enable the HTML5 parser by default on mozilla-central and 2) ship a release with the HTML5 parser enabled by default.  
This page outlines what needs to be done to ship a release with the HTML5 parser enabled by default.  


The HTML5 parser has been suitable for dogfooding for over a year and in the past couple of months there have been virtually no new site compat bugs. Thus, the parser is already alpha quality from a user POV but not from a zero test suite regressions POV.
== Things that need to be done before shipping the HTML5 parser in a final Firefox release ==


== Things that need to be done before turning the HTML5 parser on by default ==
* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=569528 569528] <h5> inside <button> inside <p> implicitly closes the <p>
** [https://bugzilla.mozilla.org/show_bug.cgi?id=579846 579846] HTML5 parser regresses cache-control support in meta pragmas
** [https://bugzilla.mozilla.org/show_bug.cgi?id=579867 579867] Implement July 2010 spec changes to SVG in HTML
*** Related [https://bugzilla.mozilla.org/show_bug.cgi?id=577416 577416] [https://bugzilla.mozilla.org/show_bug.cgi?id=574884 574884] [https://bugzilla.mozilla.org/show_bug.cgi?id=577418 577418]
** [https://bugzilla.mozilla.org/show_bug.cgi?id=564098 564098] "ASSERTION: Script global object not ready"
** [https://bugzilla.mozilla.org/show_bug.cgi?id=577508 577508] Hide old document when new one pops a dialog
*Reviews on patches
** [https://bugzilla.mozilla.org/show_bug.cgi?id=574884 574884] <math></html> crashes (sicking)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=570309 570309] -- > closing comments breaks CNN Money (sicking)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=575175 575175] Deal with Unicode decoder consuming -1 bytes (smontagu)
*Security review.
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
* [https://bugzilla.mozilla.org/show_bug.cgi?id=544994 544994]Create a "slow tp" test suite for exercising speculative parsing. (who owns this now?)
** ''What if this suite reveals something bad?''


*Get reviews on pending [https://bugzilla.mozilla.org/buglist.cgi?emailassigned_to1=1;query_format=advanced;short_desc=%5bHTML5%5d;field0-0-0=setters.login_name;bug_status=ASSIGNED;short_desc_type=allwordssubstr;email1=hsivonen%40iki.fi;type0-0-0=equals;value0-0-0=hsivonen%40iki.fi;emailtype1=exact patches]. (various people)
==Suspended items that may re-enter the list of release blockers==
*Make tp4 not [https://bugzilla.mozilla.org/show_bug.cgi?id=543458 regress]. (hsivonen)
**A first go at the fix is in hand but it failed unit tests miserably.
**Iterating on this will take at least a couple of days, because checking an iteration needs to go through the reftests and mochitests.
*Drive testsuite failures to zero. (hsivonen but help would be useful)
**[https://bugzilla.mozilla.org/show_bug.cgi?id=534458 534458]  test failure on css3.info selectors test with :checked{}
***Waiting on [https://bugzilla.mozilla.org/show_bug.cgi?id=502937 lazy frame construction] from Timothy Nikkel. (Seems reviewed and waiting landing.)
**[https://bugzilla.mozilla.org/show_bug.cgi?id=536097 536097]  spinning in nsHtml5TreeBuilder::startTag()?
***This will either be simple or so rare that it's not an alpha blocker after all.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=541040 541040]  Browser freezes in the v8 test suite
***The test suite is faulty and should be fixed in any case. However, the tp4 fix will likely hide this problem.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=541078 541078]  contentEditable reload: docshell/test/navigation/test_bug430624.html fails
***The way the editor attaches itself to the document is brittle.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543726 543726]  dom/tests/mochitest/ajax/offline/test_foreign.html fails
***Being investigated.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543689 543689]  toolkit/components/startup/tests/browser/browser_bug537449.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545661 545661]  browser_410196_paste_into_tags.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545662 545662]  browser_bookmarksProperties.js times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545663 545663]  browser_522545.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545664 545664]  browser_423515.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546381 546381]  browser_bug537449.js throws and times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546398 546398]  test_bug263683.html times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546636 546636]  [Editor] layout/generic/test/test_backspace_delete.xul fails
***If not dupe of bug 541078, probably needs help from the author of the test case.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546641 546641]  [Spec] layout/style/test/test_parse_rule.html fails
***Well understood and simple to fix.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547674 547674]  [Random?] content/xul/templates/tests/test_bug441785.xul fails
***Not understood.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547675 547675]  dom/tests/mochitest/general/test_domWindowUtils.html fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547688 547688]  toolkit/content/tests/widgets/test_radio.xul fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547928 547928]  Mochitest on XP leaks 184 instances of nsStringBuffer
***Not understood. Potentially hard to track down. Windows only.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547933 547933]  test_bug451286.xul times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547934 547934]  toolkit/content/tests/widgets/test_tooltip.xul times out
*Either [https://bugzilla.mozilla.org/show_bug.cgi?id=490665 change] form submission code to deal with IE-style isindex (hsivonen but help would be useful) or change the parser to use a Gecko-style isindex for now (hsivonen).
*[https://bugzilla.mozilla.org/show_bug.cgi?id=546635 Update] the html5lib test suite snapshot used by mochitest. (jgriffin)
*Review the unreviewed parser core code. (sicking?)
**Some more code documentation on the Java side would be useful. (hsivonen)
*Create a "slow tp" test suite for exercising speculative parsing. (bnewman) ''What if this suite reveals something bad?''


== Things that need to happen before shipping the HTML5 parser in a final Firefox release ==
* Suspended bugs that were previously P2
** [https://bugzilla.mozilla.org/show_bug.cgi?id=482917 482917] Make HTML5 parsing not regress stream data availability to extensions
***There's now a patch but no way to test it.
***Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
***''Time estimate'': Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)


* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
==Notable evangelism bugs==
 
* Bugs that need site-side fixes
** [https://bugzilla.mozilla.org/show_bug.cgi?id=540480 540480] Hootsuite.com dashboard not loading with HTML5 parser turned on
***Site contacted, contact acknowledged (hsivonen)
** [https://bugzilla.mozilla.org/show_bug.cgi?id=553795 553795] Blank page on weer.nl (Windows only)
***''No owner''
***Bad browser sniffing leads to document.write without an insertion point
** [https://bugzilla.mozilla.org/show_bug.cgi?id=565689 565689] </script> in string literal breaks out of script early on wsecu.org
***Site contacted (mbrubeck)
***''Bank''
** [https://bugzilla.mozilla.org/show_bug.cgi?id=565938 565938] Blank page on LinkedIn Recruiter
***Site rep CCed on the bug.
***Bad browser sniffing leads to document.write without an insertion point

Latest revision as of 15:44, 19 July 2010

This page outlines what needs to be done to ship a release with the HTML5 parser enabled by default.

Things that need to be done before shipping the HTML5 parser in a final Firefox release

  • Fix "[HTML5]" bugs marked P2. (hsivonen)
    • 569528 <h5> inside <button> inside <p> implicitly closes the <p>
    • 579846 HTML5 parser regresses cache-control support in meta pragmas
    • 579867 Implement July 2010 spec changes to SVG in HTML
    • 564098 "ASSERTION: Script global object not ready"
    • 577508 Hide old document when new one pops a dialog
  • Reviews on patches
    • 574884 <math></html> crashes (sicking)
    • 570309 -- > closing comments breaks CNN Money (sicking)
    • 575175 Deal with Unicode decoder consuming -1 bytes (smontagu)
  • Security review.
    • Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst
  • 544994Create a "slow tp" test suite for exercising speculative parsing. (who owns this now?)
    • What if this suite reveals something bad?

Suspended items that may re-enter the list of release blockers

  • Suspended bugs that were previously P2
    • 482917 Make HTML5 parsing not regress stream data availability to extensions
      • There's now a patch but no way to test it.
      • Suspended, because there are no known extensions that use the API in question and are compatible with Firefox 3.6.
      • Time estimate: Unknown. (Need to find an extension that actually uses this. The alternative is writing an extension just for testing.)

Notable evangelism bugs

  • Bugs that need site-side fixes
    • 540480 Hootsuite.com dashboard not loading with HTML5 parser turned on
      • Site contacted, contact acknowledged (hsivonen)
    • 553795 Blank page on weer.nl (Windows only)
      • No owner
      • Bad browser sniffing leads to document.write without an insertion point
    • 565689 </script> in string literal breaks out of script early on wsecu.org
      • Site contacted (mbrubeck)
      • Bank
    • 565938 Blank page on LinkedIn Recruiter
      • Site rep CCed on the bug.
      • Bad browser sniffing leads to document.write without an insertion point
Retrieved from "https://wiki.mozilla.org/index.php?title=Platform/HTML5_parser_tasks&oldid=239130"