Platform/HTML5 parser tasks: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
Line 7: Line 7:
*Get reviews on pending [https://bugzilla.mozilla.org/buglist.cgi?emailassigned_to1=1;query_format=advanced;short_desc=%5bHTML5%5d;field0-0-0=setters.login_name;bug_status=ASSIGNED;short_desc_type=allwordssubstr;email1=hsivonen%40iki.fi;type0-0-0=equals;value0-0-0=hsivonen%40iki.fi;emailtype1=exact patches]. (various people)
*Get reviews on pending [https://bugzilla.mozilla.org/buglist.cgi?emailassigned_to1=1;query_format=advanced;short_desc=%5bHTML5%5d;field0-0-0=setters.login_name;bug_status=ASSIGNED;short_desc_type=allwordssubstr;email1=hsivonen%40iki.fi;type0-0-0=equals;value0-0-0=hsivonen%40iki.fi;emailtype1=exact patches]. (various people)
*Make tp4 not [https://bugzilla.mozilla.org/show_bug.cgi?id=543458 regress]. (hsivonen)
*Make tp4 not [https://bugzilla.mozilla.org/show_bug.cgi?id=543458 regress]. (hsivonen)
**Potential fix for Linux and Windows in hand. Tuning needs tryserver round-trips, so can take a couple of days.
**Potential fix in hand.
**Mac is still a problem. No ETA.
**The fix interacts badly with speculative parsing on test cases that use sync XHR to control the test server.
**Tuning requires try server cycles and could, therefore, take a few days.
*Drive testsuite failures to zero. (hsivonen but help would be useful)
*Drive testsuite failures to zero. (hsivonen but help would be useful)
**[https://bugzilla.mozilla.org/show_bug.cgi?id=534458 534458]  test failure on css3.info selectors test with :checked{}
**[https://bugzilla.mozilla.org/show_bug.cgi?id=534458 534458]  test failure on css3.info selectors test with :checked{}
Line 17: Line 18:
***The test suite is faulty and should be fixed in any case. However, the tp4 fix will hide this problem.
***The test suite is faulty and should be fixed in any case. However, the tp4 fix will hide this problem.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=541078 541078]  contentEditable reload: docshell/test/navigation/test_bug430624.html fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=541078 541078]  contentEditable reload: docshell/test/navigation/test_bug430624.html fails
***The way the editor attaches itself to the document is brittle.
***Needs debugging.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543726 543726]  dom/tests/mochitest/ajax/offline/test_foreign.html fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543726 543726]  dom/tests/mochitest/ajax/offline/test_foreign.html fails
***honzab has a fix. Waiting for review.
***honzab has a fix. Waiting for review.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543689 543689]  toolkit/components/startup/tests/browser/browser_bug537449.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=543689 543689]  toolkit/components/startup/tests/browser/browser_bug537449.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545661 545661]  browser_410196_paste_into_tags.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545661 545661]  browser_410196_paste_into_tags.js fails
***Could be solved by the tp4 patch.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545662 545662]  browser_bookmarksProperties.js times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545662 545662]  browser_bookmarksProperties.js times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545663 545663]  browser_522545.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545663 545663]  browser_522545.js fails
***Could be solved by the tp4 patch.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545664 545664]  browser_423515.js fails
**[https://bugzilla.mozilla.org/show_bug.cgi?id=545664 545664]  browser_423515.js fails
***Could be solved by the tp4 patch.
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546381 546381]  browser_bug537449.js throws and times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546381 546381]  browser_bug537449.js throws and times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546398 546398]  test_bug263683.html times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=546398 546398]  test_bug263683.html times out
Line 37: Line 41:
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547933 547933]  test_bug451286.xul times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547933 547933]  test_bug451286.xul times out
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547934 547934]  toolkit/content/tests/widgets/test_tooltip.xul times out  
**[https://bugzilla.mozilla.org/show_bug.cgi?id=547934 547934]  toolkit/content/tests/widgets/test_tooltip.xul times out  
*Either [https://bugzilla.mozilla.org/show_bug.cgi?id=490665 change] form submission code to deal with IE-style isindex (hsivonen but help would be useful) or change the parser to use a Gecko-style isindex for now (hsivonen).
*[https://bugzilla.mozilla.org/show_bug.cgi?id=546635 Update] the html5lib test suite snapshot used by mochitest. (jgriffin)
*[https://bugzilla.mozilla.org/show_bug.cgi?id=546635 Update] the html5lib test suite snapshot used by mochitest. (jgriffin)
*Review the unreviewed parser core code. (sicking?)
*Review the unreviewed parser core code. (sicking?)
**Some more code documentation on the Java side would be useful. (hsivonen)
**Some more code documentation on the Java side would be useful. (hsivonen)
*Create a "slow tp" test suite for exercising speculative parsing. (bnewman) ''What if this suite reveals something bad?''
*Create a "slow tp" test suite for exercising speculative parsing. (bnewman) ''What if this suite reveals something bad?''
*Security review.


== Things that need to happen before shipping the HTML5 parser in a final Firefox release ==
== Things that need to happen before shipping the HTML5 parser in a final Firefox release ==


* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)

Revision as of 14:51, 2 March 2010

This page outlines what needs to be done to 1) enable the HTML5 parser by default on mozilla-central and 2) ship a release with the HTML5 parser enabled by default.

The HTML5 parser has been suitable for dogfooding for over a year and in the past couple of months there have been virtually no new site compat bugs. Thus, the parser is already alpha quality from a user POV but not from a zero test suite regressions POV.

Things that need to be done before turning the HTML5 parser on by default

  • Get reviews on pending patches. (various people)
  • Make tp4 not regress. (hsivonen)
    • Potential fix in hand.
    • The fix interacts badly with speculative parsing on test cases that use sync XHR to control the test server.
    • Tuning requires try server cycles and could, therefore, take a few days.
  • Drive testsuite failures to zero. (hsivonen but help would be useful)
    • 534458 test failure on css3.info selectors test with :checked{}
    • 536097 spinning in nsHtml5TreeBuilder::startTag()?
      • This will either be simple or so rare that it's not an alpha blocker after all.
    • 541040 Browser freezes in the v8 test suite
      • The test suite is faulty and should be fixed in any case. However, the tp4 fix will hide this problem.
    • 541078 contentEditable reload: docshell/test/navigation/test_bug430624.html fails
      • Needs debugging.
    • 543726 dom/tests/mochitest/ajax/offline/test_foreign.html fails
      • honzab has a fix. Waiting for review.
    • 543689 toolkit/components/startup/tests/browser/browser_bug537449.js fails
    • 545661 browser_410196_paste_into_tags.js fails
      • Could be solved by the tp4 patch.
    • 545662 browser_bookmarksProperties.js times out
    • 545663 browser_522545.js fails
      • Could be solved by the tp4 patch.
    • 545664 browser_423515.js fails
      • Could be solved by the tp4 patch.
    • 546381 browser_bug537449.js throws and times out
    • 546398 test_bug263683.html times out
    • 546636 [Editor] layout/generic/test/test_backspace_delete.xul fails
      • If not dupe of bug 541078, probably needs help from the author of the test case.
    • 546641 [Spec] layout/style/test/test_parse_rule.html fails
      • Well understood and simple to fix.
    • 547674 [Random?] content/xul/templates/tests/test_bug441785.xul fails
      • Not understood.
    • 547675 dom/tests/mochitest/general/test_domWindowUtils.html fails
    • 547688 toolkit/content/tests/widgets/test_radio.xul fails
    • 547933 test_bug451286.xul times out
    • 547934 toolkit/content/tests/widgets/test_tooltip.xul times out
  • Update the html5lib test suite snapshot used by mochitest. (jgriffin)
  • Review the unreviewed parser core code. (sicking?)
    • Some more code documentation on the Java side would be useful. (hsivonen)
  • Create a "slow tp" test suite for exercising speculative parsing. (bnewman) What if this suite reveals something bad?
  • Security review.

Things that need to happen before shipping the HTML5 parser in a final Firefox release

  • Fix "[HTML5]" bugs marked P2. (hsivonen)
Retrieved from "https://wiki.mozilla.org/index.php?title=Platform/HTML5_parser_tasks&oldid=205511"