Platform/HTML5 parser tasks: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
No edit summary
Line 24: Line 24:
*Review the unreviewed parser core code. (sicking)
*Review the unreviewed parser core code. (sicking)
*Create a "slow tp" test suite for exercising speculative parsing. (bnewman) ''What if this suite reveals something bad?''
*Create a "slow tp" test suite for exercising speculative parsing. (bnewman) ''What if this suite reveals something bad?''
*Security review.


== Things that need to happen before shipping the HTML5 parser in a final Firefox release ==
== Things that need to happen before shipping the HTML5 parser in a final Firefox release ==


* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
* Fix "[HTML5]" bugs marked [https://bugzilla.mozilla.org/buglist.cgi?priority=P2;short_desc=%5bHTML5%5d;field0-0-0=short_desc;query_format=advanced;bug_status=NEW;bug_status=ASSIGNED;short_desc_type=allwordssubstr;type0-0-0=notsubstring;value0-0-0=%5bPatch%5d P2]. (hsivonen)
*Security review.
** Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst

Revision as of 01:51, 11 March 2010

This page outlines what needs to be done to 1) enable the HTML5 parser by default on mozilla-central and 2) ship a release with the HTML5 parser enabled by default.

The HTML5 parser has been suitable for dogfooding for over a year and in the past couple of months there have been virtually no new site compat bugs. Thus, the parser is already alpha quality from a user POV but not from a zero test suite regressions POV.

Things that need to be done before turning the HTML5 parser on by default

  • Get reviews on hsivonen's pending patches. (various people)
  • 541078 contentEditable reload: docshell/test/navigation/test_bug430624.html fails
    • Review was denied. Need to develop another fix.
  • 536097 spinning in nsHtml5TreeBuilder::startTag()? (hsivonen)
    • This will either be simple or so rare that it's not an alpha blocker after all.
    • Need to reproduce this with debugger attached.
  • 281241 introduced a new reftest that doesn't pass when the HTML5 parsing algorithm is in use, because the DOM is different.
  • 381745 introduced a new reftest that doesn't wait for the load event for data: URLs properly
  • 546381 browser_bug537449.js fails
    • The connection to HTML parsing is unclear.
    • Requested help from dtownsend who is the author of the test case.
  • The following are waiting for landings by others
    • 534458 test failure on css3.info selectors test with :checked{}
    • 543726 dom/tests/mochitest/ajax/offline/test_foreign.html fails
      • honzab has a fix. Waiting for review.
  • Update the html5lib test suite snapshot used by mochitest. (jgriffin)
  • Review the unreviewed parser core code. (sicking)
  • Create a "slow tp" test suite for exercising speculative parsing. (bnewman) What if this suite reveals something bad?

Things that need to happen before shipping the HTML5 parser in a final Firefox release

  • Fix "[HTML5]" bugs marked P2. (hsivonen)
  • Security review.
    • Talked to dveditz about how to do the security review for the HTML5 parser, and it's not clear what the best format for the review would be. But we did decide that it's not something we need to do before turning the parser on by default, but we need to do it before we ship it. --jst