CycleCollector/CCStatus-2007-03-30: Difference between revisions
No edit summary |
No edit summary |
||
| Line 25: | Line 25: | ||
We're still missing javascript edges and that might cause leaks of windows. Igor has been working on a patch that makes the GC code and traversal code share the same code. So we automatically find all the javascript edges. | We're still missing javascript edges and that might cause leaks of windows. Igor has been working on a patch that makes the GC code and traversal code share the same code. So we automatically find all the javascript edges. | ||
* {{bug|375063}} (Leaking nsJSContexts and nsXBLDocGlobalObjects at shutdown): This is the bug that caused Igor to write the {{bug|375808}}. | * {{bug|375063}} (Leaking nsJSContexts and nsXBLDocGlobalObjects at shutdown): This is the bug that caused Igor to write the {{bug|375808}}. | ||
Revision as of 18:58, 30 March 2007
Agenda
- Discuss performance: Boris has filed two bugs (bug 373693 (addref) and bug 373694 (release). Status?
- dbaron on slow down he was encountering.
- Performance in general.
- Outcome of leaks tests?
- jst on status of landing the CC timing code (bug 374239).
- Discuss next steps.
Leak Numbers
Graydon:
I'm seeing all windows and documents not leaking.
David:
I'm still seeing significant leaks. I generally do run with leak gauge, but I only quit the browser once a week and thats by crashing.
Peterv:
Igor landed a patch that regressed the leaks a bit. See bug 375808
We're still missing javascript edges and that might cause leaks of windows. Igor has been working on a patch that makes the GC code and traversal code share the same code. So we automatically find all the javascript edges.
- bug 375063 (Leaking nsJSContexts and nsXBLDocGlobalObjects at shutdown): This is the bug that caused Igor to write the bug 375808.
- bug 375075 (Stop leaking the cycle collector on shutdown)
Tried to reland patch for bug 372960 (Make XPConnect traverse more JS edges), but Tinderbox is still going orange. Will probably back out again, seems related to CC performance issue. Tried to turn on jst's timing code, but that made Tinderbox go green so can't debug the issue then.
Made new patch for bug 372713 (Add cycle collection to RDF datasources) to address r- comments.
These are a bunch of safety checks that need to be removed in order to improve the performance: bug 373693 (Cycle collector makes AddRef about 6x slower) and bug 373694 (Cycle collector makes Release about 11x slower), not done yet.
Status of Pending CC Code in Bugzilla
- Add cycle collection to RDF datasources
- Make XPConnect traverse more JS edges
- Support cycle collection of refcounted non-xpcom objects (aka, the XBL patch)
- Make cycle collection suspect all native wrapper roots
- cycle collector shutdown dump based on known should-have-been-freed objects
Next Steps
- Graydon is working on ES4.
- Peter will take care of all the ifdefs and will measure before and after timings.
- Dbaron will continue to monitor performance.
Audio of This Meeting
- *NOT YET AVAILABLE* MP3 Format 10.6 MB
- You can subscribe to these meetings as a podcast using this RSS2 link. (Accountability Disclaimer: I didn't test this podcast to make sure it is compatible with anything other than iTunes. Sorry. :] )