Thunderbird/Security And Stability Releases/Rules

From MozillaWiki
Jump to navigation Jump to search

The Thunderbird 3.0.x releases are for security and stability updates. Typically these releases are restricted to security and stability fixes. The first few .x releases may include one or two regression fixes if necessary.

General Rules for approval

Patches for approval must:

  • Not affect strings in mail/locales and editor/ui.
  • Not affect idl interfaces (which would break binary compatibility).
  • The patch is not on a bug which has already been resolved as fixed for a Thunderbird 3.0 release.
  • Land on trunk before requesting approval. Preferably to have some time baking before approval is requested.
  • Be accompanied by a risk assessment as to the risk the patch poses and the reason we need to take it for the 3.0.* security releases when the approval is requested.

Patches are unlikely to be accepted if:

  • They are not affecting security or stability (in the first couple of point releases this may be relaxed by drivers if there are fixes for significant regressions).
  • They are high risk.
  • They have no tests (some patches may be accepted without tests if there is a good reason why there aren't any, and if they can be demonstrated to be well-tested, if you need support for writing tests, please ask in #maildev).

General Process for landing bugs on Thunderbird 3.0.x

(This only applies to patches affecting comm-*, mozilla-* patches should follow mozilla-* rules).

  1. Generate a patch for trunk and request reviews as per the standard process.
  2. Once reviews granted, land the patch on comm-central (if you don't have checkin privileges add checkin-needed to the keywords)
    • On checking the patch in the bug should be marked as FIXED, and the milestone field set to the next trunk milestone.
  3. Once the patch has baked for a few days:
    • request approval-thunderbird3.0.1 (by setting the flag to ?)
    • At the same time as requesting approval, explain the risk associated with the patch and why it should be taken for the security and stability branch.
  4. If approval is granted, land on comm-1.9.1 (more info on comm-central branches).
    • Once checked in, set the status-thunderbird3.0 field to '.1-fixed', '.2-fixed' as appropriate for the release the patch is being checked in for.

Status Tracking