DevTools/ReviewTips

< DevTools
Revision as of 16:47, 2 November 2011 by JoeWalker (talk | contribs) (Created page with " == General == * Ask for feedback early * Only ask for review when you believe that it's ready to land * Make sure you have tests where appropriate * Make sure the patch applies...")
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)

General

  • Ask for feedback early
  • Only ask for review when you believe that it's ready to land
  • Make sure you have tests where appropriate
  • Make sure the patch applies cleanly to fx-team

Other sources of hints and tips:

Headers

  • Make sure each file starts with the standard copyright header (see License Boilerplate)
    • For work funded by Mozilla, the 'Initial Developer of the Original Code' should be 'The Mozilla Foundation'.
    • Remember the year
    • The first letter of contributors names should be under the 'n' of 'contributors'
    • The original author of the code should have the string ' (original author)' after his/her email address

CSS

  • See [DevTools/CSSTips]

Reviewers:

  • dao

JavaScript

See:

Reviewers:

  • dcamp
  • msucan
  • robcee

Localization (l10n) / Properties

Reviewers:

  • dcamp
  • msucan
  • robcee