BMO/Splinter

q1/2-2012 splinter work

phase one - address current splinter pain-points

bugs that should be easy(ish) to fix, to be addressed before the rewrite.

patch parsing missing features

add now

• bug 652334 splinter doesn't support hg rename
• bug 695662 splinter does not show bzr renames

patch parsing bugs

only action quick fixes, more complex issues can wait for the PatchReader work

• bug 685645 splinter diff viewer gets confused by some diffs
• bug 709897 splinter doesn't like hg diffs where a file was copied and then modified
• bug 815531 splinter fails to display attachment 681995 correctly
• bug 823448 Show exact replacement of code and not only the addition
• bug 826214 New file with one line isn't shown

bugs

investigate and fix if easy

• bug 652500 Splinter creates a comment with code review notes in the wrong place
• bug 797840 Replying to a comment on Splinter always replies to the first comment

enhancements

fix now, all look easy

• bug 760989 Splinter should not require login
• bug 785314 splinter's routines which add review links to email need to be updated for html bugmail
• bug 821889 Make it so that Splinter shouts loudly when a patch introduces Windows line endings

fix if there's time

• bug 692431 Splinter doesn't clear drafts when publishing a review

phase two - rewrite splinter

rewrite to become more like a normal bugzilla perl/js extension, rather than a pure-js one. this paves the way for splinter to replace upstream's diff view

investigate using webkit's review system as a base instead of splinter

• • https://bugs.webkit.org/attachment.cgi?id=3046&action=review
  • simpler ui than splinter
  • simpler code than splinter
  • more features
  • comment context selection
  • side-by-side/unified views
  • preview
  • copy without line numbers
  • requires js --> yui conversion (http://www.jsrosettastone.com/ )
  • need to identify stuff that's in splinter but not in webkit's (file collapsing, etc)
  • need to sort out licensing, especially with upstream bugzilla as the target
  • need to look at existing bugs filed against the system (eg https://bugs.webkit.org/show_bug.cgi?id=43948 )
  • code @ http://trac.webkit.org/browser/trunk/Websites/bugs.webkit.org

implementation notes

• use PatchReader to parse diffs in perl
• fix any outstanding patchreader issues, push upstream
• output the patch content as full formed divs
• output splinter objects as json data
• use a new longdescs field (or extradata if possible) to indicate if a comment is a review, rather than parsing comments
• use yui3? (may have issues upstream)

ux notes

• rename "Splinter review" to just "Review"
• add support for interdiff
• add support for side-by-side and inline diffs