Add-ons/Reviewers/Guide/Team

From MozillaWiki
< Add-ons‎ | Reviewers‎ | Guide
Jump to: navigation, search

Once you have finished your first add-on review, you are part of our team. Welcome! Now you need to learn how we behave and communicate.

Communication Channels

There are 2 mailing lists related to our group:

  • Internal: All reviewers are subscribed to an internal mailing list. On this list we discuss add-on reviews and review policies. If you have questions about a review, you can ask them there. Queue status and reviewer contribution reports are sent weekly. Only members of the list can send messages to it, so it has fairly low activity.
  • Public: The other list, amo-editors AT mozilla DOT org, is public. Review emails sent to developers have this list in the Reply-To header, so any objections or comments about add-on reviews are sent there. It is normally a very active list, getting dozens of messages daily. Since most of the messages aren't really relevant to most reviewers, this list is opt-in. If you want to, just request to be added and you will be. Every now and then a review reply sent to this list will require your intervention, and in those cases an admin will add your email address to the conversation thread. If you don't want your email address to be shared to other developers, please indicate this to your guide.

For live communication we use the #addon-reviewers IRC channel.

Finally, we encourage you to join the Mozillians directory. If you're a reviewer, you can ask on the mailing list or IRC for someone to invite you and vouch for you. Adding the amo-editors tag to your account should make you visible on our Mozillians group.

Behavior

We put a great deal of trust in our review team, so we expect reviewers to handle themselves ethically and professionally. They shouldn't abuse their power, for personal gain or any other reason. The following list is not comprehensive, but should give you an idea of what the expectations are:

  • You must never review or moderate user reviews for add-ons you have contributed code to, or add-ons that directly compete with yours.
    • If you have contributed code to an AMO add-on, your reviewer account should be linked to that add-on, either as an owner or a developer. If you don't wish to be publicly visible as a contributor, AMO allows it to be hidden.
    • If it's not possible to do this for whatever reason, your contributions should be disclosed to the Mozilla Add-ons Team.
  • When performing reviews and communicating with add-on developers, please maintain a professional and courteous tone at all times. If a developer is being stubborn, offensive or otherwise uncooperative, don't reply and escalate the case to an admin.
  • The review tools must be used exclusively for performing add-on reviews. Any other unsolicited requests or questions to add-on developers are not allowed. You can use public contact information to approach developers as any regular user, but you should also disclose if you learned about the add-on while looking at it through the review tools.
  • You are encouraged to review add-ons you have looked at before. Having knowledge of the code is beneficial and saves time. However, you should refrain from exclusively dedicating your time to a small amount of add-ons, or reviewing too many versions of the same add-on consecutively (more than 4).
  • Sometimes, add-on developers will offer to show their appreciation for your time and assistance by offering a gift, such as a promotional t-shirt. Small gifts are allowed, but we require them to be disclosed to the Mozilla Add-ons Team.

Admins monitor the reviewer group regularly and remove reviewers who have been inactive for extended periods of time. While we appreciate all contributions, it's best that reviewers have regular activity so they are less likely to overlook things. Also, access to add-on code and our internal mailing list are privileges that should be limited to active contributors.

Enforcement

Unfortunately, there are times when we have to remove reviewers from this group because of egregious and/or frequent violations of reviewing guidelines. Reviewers will receive a warning if they are close to being put on probation. In probation, an admin will spot-check a reviewer’s activity for a month and remove them from the group if they continue making mistakes. If the reviewer improves, they will remain in the group conditionally for the next six months, provided they do not revert to making errors.

Here are the types of mistakes we track and their corresponding severity:

Most severe

These errors lead to a terrible developer experience, or security issues for users:

  • Approving an add-on that should have been rejected

Severe

These errors are not egregious but can lead to a bad developer experience if numerous:

  • Rejecting an add-on when it should have been approved
  • Rudeness or offensive language when addressing a developer

Minor

These errors are minor, but again not great if numerous:

  • Incoherent English
  • Unresponsive or not helpful when involved in conversation with developer

Removal of reviewing rights is rare and done only when we feel users may experience a security risk, developers are having a terrible experience, or the contributions are causing a drain on resources. If you have any questions or concerns, please contact us in one of the ways listed above.

Thanks for joining the team and supporting the add-on community, our developers and users appreciate your contributions!

Next: Complete Themes