The goal of the style guide is to try provide rules to write code that looks the same no matter what project. It is a guide and is always up for discussion by the team.
- Each file should have a completed copy of the MPL2 license block, immediately followed by an empty line.
- Each file should pass PEP8 except for line length, see below.
# Good def method(self, parameter) # Bad def method(self,parameter)
- Lines should try not to have more than 100 characters.
- Docstrings should conform to PEP0257 and should be on a single line wherever possible.
# Good def click_login(): """Clicks the login link.""" # Bad def click_login(): """ Clicks the login link. """
Where not possible, the first line should be a summary.
# Good def login(): """Logs in. Clicks the login link and then waits for the home page to load. """ # Bad def login(): """Logs in. Clicks the login link and then waits for the home page to load."""
- Indenting should be a soft tab (4 spaces) as common with in Python. Do not mix tabs and spaces!
- There should be no whitespace at the end of the file (as per PEP8).
- Comments should be on the line above. Remember to update comments when changing code so that code matches the comments.
- Class names should be in Pascal style as this is Python idiomatic.
# Good class TestThisSite: # Bad class test_this_site:
- All page objects should inherit from
- Page objects should not do asserts. This should be done within the test.
- Each page should be grouped within one module.
- If using multiple words to describe a module separate them with underscores '_'
- Timeout time should be taken from pytest-mozwebqa via
- Single quotes (') should be used instead of double (") throughout.
- Methods should have a single purpose.
- Methods should not contain logic that depends on properties of the page. The logic and expectations should be within the test, and adding this to the page object could guard your tests against genuine failures.
# Good def click_login(self) self.selenium.find_element(*self._login_locator).click() # Bad def click_login(self) if not self.is_user_logged_in: self.selenium.find_element(*self._login_locator).click() else: pass
- Locator variables should be prefixed with
_to show that it is private.
- Variables should be descriptive of the area and not clash with any properties.
- Should have a suffix of
- Accessing locators should be done through a property or method as this keeps the locator as read-only.
@property def search_term(self): return self.selenium.find_element(*self._search_box_locator).value
- We should use locators in the following order of preference (there will be exceptions):
- Class name
- CSS selector
- CSS locators should use whitespace for readability when using direct descendants.
# Good _my_locator = "css=#content > p > a" # Bad _my_locator = "css=#content>p>a"
- Use Python tuples to define locators:
# Good _my_locator = (By.ID, "content")
- Methods that perform actions on the page should indicate the action in the method name.
# Good def click_report_with_length(length) # Bad def report_length(length)
- Actions should wait for the appropriate action to complete. This could be an implicit or explicit wait. For example, clicking a login button might explicitly wait for a username field to be visible.
Advanced: Page Regions
In some circumstances, for example where a header/navigation is common across the website, we will use a page region. The page region is a child class of the base Page object, which is inherited by all page objects. This means that the navigation can be reached from any page object and herein lies the DRY!
A brief example:
class BasePage(Page): @property def header(self): return BasePage.HeaderRegion(self.testsetup) class HeaderRegion(Page): _login_link = (By.ID, "home") @def click_login(self): self.selenium.find_element(*self._login_link).click()
Referring to this page region with a property makes it very readable and concise from within the test. Clicking login during a test would be performed like this:
Another example where this might be used is on a search results page, the page region being the search results element.
- Module names should be called test_ and then behavioral areas.
- Test method signature should include mozwebqa to use pytest-mozwebqa plugin.
def test_example(self, mozwebqa):
- Test method names should always show the intent of the test case.
# Good def test_that_advanced_search_does_not_find_item(self, mozwebqa): # Bad def test_advanced_search(self, mozwebqa):
- Tests should handle the asserts -- not the page objects.
- Tests should use Python's native assert statement.
- Note that this is a change from our previous standard of using the UnittestZero package.
- When doing equivalency assertions, put the expected value first, followed by the actual value, for example:
assert 'expected' == 'actual' # good assert 'actual' == 'expected' # bad
- When doing negative equivalency, use != and put the unexpected value first, followed by the actual value, for example:
assert 'unexpected' != 'actual' # good assert 'actual' != 'unexpected' # bad
- To directly cause a test to fail raise an AssertionError with an appropriate message, for example:
- See pytest's documentation on asserts for more help.
Size of patches
To make sure that we can review your patch as quickly and efficiently as possibly we would like patches to have a single test in them and the necessary changes to the page objects. This also limits the chances of merge conflicts later.
Using new and old standards together
As we (and Selenium and automation) develop more knowledge some projects might fall behind the standards in this style guide. It can be tempting to want to fix all of the outdated style but in order to keep patches/pulls small (see above!) we are happy to have new and old standards of code sit side by side. As we regularly review and update tests the project will be brought completely up to our current standards.
Or if you prefer, log a GitHub issue to have a section of code addressed separately to the job you are doing.