QA/Places/Unified autocomplete

From MozillaWiki
< QA‎ | Places
Jump to: navigation, search

Feature Ownership & Status

Ownership

Dev Lead: Marco Bonardo

QA Lead: Andrei Vaida, :avaida on IRC

Release target: Firefox 36

Status

[LANDED] Nightly 34: first landed on

[DISABLED] Aurora 34: release target moved to Firefox 35

[DISABLED] Aurora 35: release target moved to Firefox 36

[ON TRACK] Aurora 43: signed-off

[ON TRACK] Beta 43: signed-off

[ON TRACK] RC 43: landed

Summary

Context

The awesomebar in Firefox Desktop has been so far driven by two autocomplete searches implemented by the Places component:

  • history: managing switch-to-tab, adaptive and browsing history, bookmarks, keywords and tags
  • urlinline: managing autoFill results

Some of the possible improvements suggested for the awesomebar's content include:

  • Better identify searches among the results
  • Allow the user to easily find favorite search engine
  • Always show the action performed by Enter/Go
  • Separate searches from history
  • Improve the styling to make each part more distinguishable

The decision to merge the existing components into a single new component called UnifiedComplete (toolkit/components/places/UnifiedComplete.js) was made because of the various architecture complications that would result from actually applying these improvements to the awesomebar.

Here are a few of the improvements currently available in Nightly 34's awesomebar:

  • The autoFill result will now always cope with the first popup entry. Though note the behavior didn't change, we will still autoFill up to the first '/'. * This means a new popup entry is inserted as the top match.
  • All initialization is now asynchronous, so the UI should not lag anymore at the first awesomebar search
  • The searches are serialized differently, responsiveness timing may differ, usually improve
  • Installed search engines will be suggested along with other matches to improve their discoverability
Note: See Marco Bonardo's blog post on Unified Autocomplete here.

Enabling the component

The UnifiedComplete component can be enabled by setting the following boolean pref to true:

browser.urlbar.unifiedcomplete

Note: this pref is true by default starting with Firefox 43.

References

Test Cases

Bug Work

All Dependencies
ID Summary Priority Status
810930 Disable autoFill when urlbar behavior is not the default -- RESOLVED
887864 Use a mozIStorageAsyncConnection in nsPlacesAutocomplete -- RESOLVED
951624 Breakdown: Show the action that will be triggered when pressing enter in a pre-selected dropdown entry -- RESOLVED
958188 Search Provider Top Suggestion P4 NEW
959573 Design the interaction between the UI for top search provider and the places database -- VERIFIED
993372 Port autocomplete and inline tests to unified autocomplete -- RESOLVED
995092 Ensure we can enable Unified Autocomplete in Nightly -- RESOLVED
995094 Post-facto review of UnifiedComplete -- RESOLVED
995095 Move the nsPlacesAutocomplete component to Suite (comm-central part) -- RESOLVED
1040335 Flip Unified Autocomplete pref once we merge to 34. -- VERIFIED
1040340 Use URI specs instead of nsIURIs in unifiedcomplete tests P5 NEW
1041421 UnifiedComplete: issues in preferences code -- RESOLVED
1041428 Fix query cancellation in UnifiedComplete.js. -- RESOLVED
1041429 Adopt template strings in UnifiedComplete -- RESOLVED
1041433 UnifiedComplete: Close connections on Sqlite.shutdown.addBlocker rather than TOPIC_SHUTDOWN -- RESOLVED
1041443 UnifiedComplete: What's _addFrecencyMatch sorting -- RESOLVED
1043923 Test failure 'controller.waitForPageLoad(URI=about:newtab, readyState=complete)' in /testAwesomeBar/testVisibleItemsMax.js P1 RESOLVED
1043942 UnifiedComplete disables inline autocomplete if urlbar behavior is not the default -- RESOLVED
1045105 Pre-select the first popup entry when autoFill suggests a match -- RESOLVED
1045283 Unified Autocomplete inline auto-fill results don't have a favicon when redirects/HSTS are involved P3 NEW
1045924 use foreign_count in unifiedcomplete -- RESOLVED
1045985 unified autocomplete broke my most frequently autocompleted items P3 RESOLVED
1046062 unified version of test_swap_protocol.js is disabled without a reason -- RESOLVED
1046074 Improve post-filtering of dupes in UnifiedComplete (through www. and finalCompleteValue) P3 ASSIGNED
1047613 Awesomebar-results-pane repeatedly opening up when typing a visited domain P1 VERIFIED
1047904 Autocompleted URL is also shown as first suggestion (duplication) -- RESOLVED
1048857 Input like "http:// fgfg" kills UnifiedComplete -- VERIFIED
1049506 Visible slowdown in autofilling url domains with unified complete enabled -- RESOLVED
1050683 UnifiedComplete is missing nsIAutoCompleteSearchDescriptor -- RESOLVED
1051047 Changes in locationbar aren't always executed with UnifiedComplete -- RESOLVED
1051830 Unexpected in-the-middle completion in the urlbar (e.g. "go >> google.com") -- VERIFIED
1059395 "http:// mozilla" only matches URLs that include 'http://' in the path/querystring P3 NEW
1059846 Location bar loads address including >> instead of just the replaced address -- VERIFIED

33 Total; 5 Open (15.15%); 22 Resolved (66.67%); 6 Verified (18.18%);


Verified Fixed bugs
ID Summary Priority Status
693808 Entering numbers or single words and then pressing Enter in the location bar should bring search results -- VERIFIED
751709 autoFill should obey history-only or bookmarks-only autocomplete options -- VERIFIED
993391 Places async transactions: Implement "move bookmarks" command -- VERIFIED
1003931 Right click option on bookmark menu not behaving properly -- VERIFIED
1034381 Enhance previous searches in awesomebar dropdown by removing URL -- VERIFIED
1036914 Log selections of awesomebar results that "are like" the url in the current search provider. -- VERIFIED
1039904 Changing the URL in a pinned tab opens new tab instead -- VERIFIED
1040335 Flip Unified Autocomplete pref once we merge to 34. -- VERIFIED
1042519 Characters followed by a single dot as a location bar input point to a server error page -- VERIFIED
1047433 Add "(engine) Search" label for past search results in the location bar -- VERIFIED
1047600 bug 982428 regressed using //foo to go to an intranet site -- VERIFIED
1048513 location bar: In Private Browsing mode Firefox shouldn't save browser.fixup.domainwhitelist. entries -- VERIFIED
1048857 Input like "http:// fgfg" kills UnifiedComplete -- VERIFIED
1051830 Unexpected in-the-middle completion in the urlbar (e.g. "go >> google.com") -- VERIFIED
1053245 A string of numbers entered in the address bar prompts user with infobar asking if they'd like to go to the number -- VERIFIED
1053357 Search terms with multiple spaces are displayed with plus signs in the location bar -- VERIFIED
1059846 Location bar loads address including >> instead of just the replaced address -- VERIFIED
1064776 disable unified autocomplete for Firefox 34 -- VERIFIED
1065265 Improve infrastructure dealing with moz-action: autocomplete results -- VERIFIED

19 Total; 0 Open (0%); 0 Resolved (0%); 19 Verified (100%);


Upcoming bug fixes
ID Summary Priority Status
951624 Breakdown: Show the action that will be triggered when pressing enter in a pre-selected dropdown entry -- RESOLVED
1040725 Enhance previous searches in awesomebar by appending a magnifying glass -- VERIFIED
1040923 Implement updated styling to Awesome Bar -- RESOLVED
1045283 Unified Autocomplete inline auto-fill results don't have a favicon when redirects/HSTS are involved P3 NEW
1047434 Handle multiple results for the same search terms -- RESOLVED
1047469 Implement search terms hilighting -- RESOLVED
1047613 Awesomebar-results-pane repeatedly opening up when typing a visited domain P1 VERIFIED
1054914 Deleting the autofilled portion of a URL should result in the first result being the current search engine -- RESOLVED
1066358 Improve how keyword autocomplete results are displayed -- VERIFIED
1067168 Entering "1.2.3.4/" in URL bar shouldn't cause a search. -- VERIFIED
1067888 Add autocomplete result type for searching via current search engine -- VERIFIED
1067896 Add autocomplete result type for searching via alias of a search engine -- VERIFIED
1067899 Add autocomplete result type for arbitrary URLs -- VERIFIED
1067903 Autoselect first autocomplete result when it's guaranteed to be a special result -- VERIFIED
1067921 Autocomplete can sometimes show "Visit moz-action:..." -- RESOLVED
1067922 Correctly handle path-like inputs like "t:" in autocomplete P3 NEW
1067935 Fork Toolkit autocomplete controller -- RESOLVED

17 Total; 2 Open (11.76%); 7 Resolved (41.18%); 8 Verified (47.06%);

Sign off

Criteria

  • All the test cases were executed.
  • All the blocker, critical, major bugs have been fixed.

Results

Aurora Sign-off

  • [DISABLED] Firefox 34 (2014-09-04) - UI implementation is incomplete.
  • [DISABLED] Firefox 35 (2014-10-21) - Feature is incomplete.
  • [DONE] Aurora 43 (2015-09-25).

Beta.png Beta Sign-off

  • [DONE] Beta 43 (2015-10-30).

Release.png Release Sign-off

  • [DONE] RC 43.0 (2015-12-04).