Confirmed users
425
edits
Web Testing/Automation/CodeReviewProcess: Difference between revisions
Jump to navigation
Jump to search
Web Testing/Automation/CodeReviewProcess (view source)
Revision as of 14:23, 9 September 2014
, 9 September 2014→At then end of the code review
| Line 29: | Line 29: | ||
===At then end of the code review=== | ===At then end of the code review=== | ||
Once the pull request has received the required number of positive reviews (usually one or two), squash your commits locally and push a new single commit to your fork to replace all of the commits that were created during the review process. | Once the pull request has received the required number of positive reviews (usually one or two), you should squash your commits locally if you are able to and then push a new single commit to your fork to replace all of the commits that were created during the review process. If you are not comfortable doing this squash then request that it be done by someone else by leaving a comment on the pull request. | ||
== Merging a pull request == | == Merging a pull request == | ||