Confirmed users
821
edits
(/* Remaining points and burndown chart) |
(/* Day 8: 21th August) |
||
| Line 388: | Line 388: | ||
* Will work on review comments and assigned bugs. | * Will work on review comments and assigned bugs. | ||
=== Day 8: | === Day 8: 21st August === | ||
====Steve==== | |||
* {{Bug|1184865}} - [Messages][NG] Replace some methods in MessageManager with messaging service in conversation view. | |||
** Landed, but I'll file a bug for the dataclone error. It might be the message event that broadcasting from shim but not handled. | |||
**:(Oleg) Yeah, I remember it was error while broadcasting event, so I didn't pay attention :) | |||
* {{Bug|1179628}} - [Messages][NG] Lay out Settings service structure | |||
** Start mozMobileConnections. | |||
* {{Bug|1180592}} - [Messages][NG] mozMobileConnections shim Implementation | |||
** Some idea about the mozMobileConnections shim and create a simple WIP for it. | |||
Today: | |||
* Layout for mozConnections shim | |||
* Testing with the conversation service patch | |||
* Confirm with Etienne about the profiling and make the list layout close to master. | |||
====Julien==== | |||
* mostly worked on system messages issue. I fixed the errors I had in SystemMessage subsystem in Gecko, and then I started studying the System app part. After discussing with Vivien I have good ideas to change things here but I don't want to break things :p | |||
:(Oleg) It's their fault if they don't have integration tests :D Just kidding. | |||
:(Julien) ;) I have test cases for my case, I'll try to do integration tests from them so that this doesn't break in the future. | |||
* did quick answers for {{Bug|1180592}} and did a quick pre-review for {{Bug|1169576}} | |||
Today: | |||
I want to: | |||
* review patches in review | |||
* work on the system messages issue | |||
If all this moves forward well, I could: | |||
* continue the prototype caching the thread list to a single db (including contacts/drafts/etc). | |||
====Oleg==== | |||
* {{Bug|1155534}} - [Messages][NG] Extract NewMessage view from Conversation view | |||
** No updates (in background). | |||
* {{Bug|1176976}} - [Messages][Drafts] Remove the draft saving/replacing action menu | |||
** Added support for saving draft with participants when all Conversation messages are removed (in background); | |||
** Added more integration tests and spend some time to figure out why my tests worked before rebase and didn't after :) So it seems after "activeThread" patch drafts are a broken on master - activeThread is not cleared when you leave Conversation. And when you enter conversation, then go to composer and save a draft - you'll have thread-bound draft instead. It's good that we'll have new tests that can catch this in the future :) | |||
** I'll think to add activeThread cleanup somewhere in afterLeave (and not to erase new one if we move from conversation to conversation). Or maybe we need separate bug? | |||
**:(Julien) I'm not sure I follow; we can discuss on IRC :) | |||
**:(Oleg) Sure. | |||
* {{Bug|1169576}} - [Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list | |||
** Not much updates here, was wrapping up simple MessageChannel benchmark app (in review); | |||
** Going to dive into WebIDE profiler land and check if I see something obvious there :) | |||
:(Julien) don't hesitate to ask me if you need anything here. I did my part of profiling during the meetup week :) | |||
:(Oleg) Yeah, I should have questions :) Thanks! | |||
Today: | |||
* Will handle review/feedback/need-info requests; Sorry concentrated on drafts patch yesterday, will handle review/ni? today. | |||
* Will work on review comments and assigned bugs. | |||
=== Day 9: 24th August === | === Day 9: 24th August === | ||
== Demos == | == Demos == | ||
== Retrospective == | == Retrospective == | ||