B2G/QA/Automation/Style Guide: Difference between revisions

B2G/QA/Automation/Style Guide (view source)

1,051 bytes removed , 3 November 2015

352

edits

@@ Line 14: / Line 14: @@
 = Use of Libraries =
-= Submitting and Reviewing Patches =
+= Submission and Review =
-== Submission ==
-To make sure that we can review your patch as quickly and efficiently as possibly we would like patches to have a single test in them and the necessary changes to the page objects. This also limits the chances of merge conflicts later.
-<br>
-Please refer to [https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Submitting_a_Gaia_patch this page] for gaia patch submission steps.
-== Review ==
-First of all, make sure above mentioned guidelines are not violated, and check for the following:
-<br>
-=== Look for transitions that are not waited on ===
-TBD - jlorenzo
-=== Check for change/removal of methods ===
-In order to make sure that the change is cascaded, `git grep` is your friend.
-TBD - jlorenzo
-=== Are the locators correct? Could they be improved?  ===
-TBD - jlorenzo
-=== Are the locators/methods used that were added? ===
-TBD - mwargers
-A linter would also help to enforce it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1186388
-=== Are workarounds explained in the code file? ===
-TBD - jlorenzo