canmove, Confirmed users
640
edits
Security/Firefox security bug fixing: Difference between revisions
Security/Firefox security bug fixing (view source)
Revision as of 19:39, 10 September 2019
, 10 September 2019sec-approval+ may not be for immediate landing
(short explanation why obfuscation isn't always a toxic anti-pattern) |
(sec-approval+ may not be for immediate landing) |
||
| Line 89: | Line 89: | ||
* How likely is this patch to cause regressions; how much testing does it need? | * How likely is this patch to cause regressions; how much testing does it need? | ||
3. | 3. When you get '''‘sec-approval+''' read the associated comment before landing. The patch approval may be conditional on waiting until a later date before landing depending on the severity of the bug and the complexity of the patch. For a severe bug with a more obvious and safe patch we want the narrowest possible window of time between when the patch is public and when the fix is shipped. For other patches we may want to wait until the next cycle if we're too close to the release date to take the regression risk. Come talk to us if the suggested date causes conflicts and we'll see if we can adjust the date or find someone to land the patches for you. | ||
===Landing tests=== | ===Landing tests=== | ||