Confirmed users
2,197
edits
TestEngineering/Performance/Onboarding: Difference between revisions
Jump to navigation
Jump to search
TestEngineering/Performance/Onboarding (view source)
Revision as of 11:10, 18 September 2019
, 18 September 2019no edit summary
No edit summary |
|||
| Line 1: | Line 1: | ||
= Meetings = | |||
{{:TestEngineering/Performance/Meetings}} | {{:TestEngineering/Performance/Meetings}} | ||
= Calendar = | |||
There's a Performance [https://calendar.google.com/calendar/embed?src=mozilla.com_9bk5f2rqdeuip38jbeld84kpqc%40group.calendar.google.com shared calendar] ([https://calendar.google.com/calendar/ical/mozilla.com_9bk5f2rqdeuip38jbeld84kpqc%40group.calendar.google.com/public/basic.ics iCal]), which is primarily used for PTO. | There's a Performance [https://calendar.google.com/calendar/embed?src=mozilla.com_9bk5f2rqdeuip38jbeld84kpqc%40group.calendar.google.com shared calendar] ([https://calendar.google.com/calendar/ical/mozilla.com_9bk5f2rqdeuip38jbeld84kpqc%40group.calendar.google.com/public/basic.ics iCal]), which is primarily used for PTO. | ||
= PTO = | |||
Add any PTO to the shared calendar (see above) so the team are aware. | Add any PTO to the shared calendar (see above) and [https://docs.google.com/document/d/1kHHimZH65Rg_Nzx_JfyPqeXL6ONTse0nG2t9Nkv4eOY/edit# team meeting notes] so the team are aware. During PTO please also update your name in Bugzilla's [https://bugzilla.mozilla.org/userprefs.cgi?tab=account user preferences] to indicate that you are away, and when you will return. | ||
= Groups = | |||
Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask. | Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask. | ||
* [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest perftest] is invite only, and used for team communications and setting up test accounts | * [https://groups.google.com/a/mozilla.com/forum/#!forum/perftest perftest] is invite only, and used for team communications and setting up test accounts | ||
| Line 17: | Line 17: | ||
* [https://groups.google.com/forum/#!forum/pi-monitoring pi-monitoring] is used to share regression summaries | * [https://groups.google.com/forum/#!forum/pi-monitoring pi-monitoring] is used to share regression summaries | ||
= Credentials = | |||
There's a shared [https://1password.com/ 1Password] vault for credentials that you may need to access. Please submit a request for 1Password from [https://mozilla.service-now.com/sp?id=sc_cat_item&sys_id=94530ae813805b007b5450782244b009&sysparm_category=018c96e84ff35200f004ef6d0210c7b4 The Hub]. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault. | There's a shared [https://1password.com/ 1Password] vault for credentials that you may need to access. Please submit a request for 1Password from [https://mozilla.service-now.com/sp?id=sc_cat_item&sys_id=94530ae813805b007b5450782244b009&sysparm_category=018c96e84ff35200f004ef6d0210c7b4 The Hub]. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault. | ||
= Additional equipment = | |||
You may need additional hardware such as mobile devices, laptops, etc. You can request this equipment from [https://mozilla.service-now.com/sp The Hub]. | You may need additional hardware such as mobile devices, laptops, etc. You can request this equipment from [https://mozilla.service-now.com/sp The Hub]. | ||
== GitHub | = Bugzilla = | ||
You will need to create an account in Mozilla's instance of Bugzilla. See [[BMO/UserGuide]] for how to get started. It's helpful to include your IRC/Slack handle in your name field prefixed by <code>:</code> so you can quickly be identified by other users of Bugzilla. Other details that can be helpful are your preferred pronouns, current timezone, and if you're currently on PTO. For example: | |||
Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021) | |||
= GitHub = | |||
We have a [https://github.com/orgs/mozilla/teams/fxperftest GitHub team] for simplifying access to repositories. All team members that belong to the [https://github.com/orgs/mozilla Mozilla organisation] should be added to this team as members. Team maintainers can add new members following the process [[GitHub#Team_Maintainers_.26_Project_Leads|documented here]]. Other contributors will need to be manually granted access to individual repositories as needed. | We have a [https://github.com/orgs/mozilla/teams/fxperftest GitHub team] for simplifying access to repositories. All team members that belong to the [https://github.com/orgs/mozilla Mozilla organisation] should be added to this team as members. Team maintainers can add new members following the process [[GitHub#Team_Maintainers_.26_Project_Leads|documented here]]. Other contributors will need to be manually granted access to individual repositories as needed. | ||
= Shared folder = | |||
We have a [https://drive.google.com/drive/u/0/folders/1EyeiuJYmivvY83BCicqeR4-59HRTU-ll shared folder] in Google Drive. | We have a [https://drive.google.com/drive/u/0/folders/1EyeiuJYmivvY83BCicqeR4-59HRTU-ll shared folder] in Google Drive. | ||
= Sheriffing = | |||
Performance sheriffs will need to complete the following: | Performance sheriffs will need to complete the following: | ||
| Line 40: | Line 45: | ||
* Join the [https://groups.google.com/a/mozilla.com/forum/#!forum/perf-sheriffs perf-sheriffs] Google Group | * Join the [https://groups.google.com/a/mozilla.com/forum/#!forum/perf-sheriffs perf-sheriffs] Google Group | ||
= Review policy = | |||
When you push a commit up for review, you should use the following syntax to request review from the [https://phabricator.services.mozilla.com/tag/perftest-reviewers/ perftest review group]: | When you push a commit up for review, you should use the following syntax to request review from the [https://phabricator.services.mozilla.com/tag/perftest-reviewers/ perftest review group]: | ||
r=#perftest | |||
A single r+ from one reviewer is required for the patch to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example: | A single r+ from one reviewer is required for the patch to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example: | ||
Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest,rwood | |||
When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname: | When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname: | ||
r=#perftest,rwood! | |||
This will add the patch to the shared review queue, but also block the review from landing pending Rob's approval. Requested changes by other reviewers will also block the review. | This will add the patch to the shared review queue, but also block the review from landing pending Rob's approval. Requested changes by other reviewers will also block the review. | ||
= Duties = | |||
Everyone on the team will be expected to carry out the following duties to ensure effective collaboration both within the team, and with other teams. | |||
== Code reviews == | |||
Visit [https://phabricator.services.mozilla.com/differential/ active revisions] in Phabricator every day to: | |||
* Review any '''Must Review''' and '''Ready to Review''' patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the <code>#perftest</code> review group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within 24 hours. | |||
* Follow up on any '''Waiting on Review''' patches by prompting appropriate team members for a review. | |||
* Review any '''Waiting on Authors''' patches and prompt the authors if there is an action they need to take. | |||
== Bugzilla requests == | |||
Visit the [https://bugzilla.mozilla.org/request.cgi request queue] in Bugzilla ever day and filter by your account to see all requests that have been submitted for you. All requests should receive a response within 5 days. | |||