TestEngineering/Performance/Onboarding

From MozillaWiki
Jump to: navigation, search

Meetings

Phonebook

The people directory is a secure place to quickly find your team members and easily discover new ones.

Please ensure your profile has:

  • photo (of you!)
  • username (this is included in your profile URL)
  • GitHub identity
  • #Bugzilla identity
  • IRC nick
  • Slack nick

Calendar

There's a Performance shared calendar (iCal), which is primarily used for PTO. Add this calendar to your google calendar by taking the iCal link and using it in the "Add Calendar -> From URL" section.

PTO

Add any PTO to the shared calendar (see above) and team meeting notes so the team are aware. During PTO please also update your name in Bugzilla's user preferences to indicate that you are away, and when you will return.

Groups

Feel free to sign up to the following groups, and post to them when you have something to share or questions to ask.

  • perftest is invite only, and used for team communications and setting up test accounts
  • performance is for general discussion and announcements
  • perfteam group is for the performance engineering team
  • perf-sheriffs is for discussions related to performance sheriffing
  • perftest-alerts is for alerts related to performance tests
  • pi-monitoring is used to share regression summaries

Credentials

There's a shared 1Password vault for credentials that you may need to access. Please submit a request for 1Password from The Hub. Once you have an account and the software set up (available on iOS, Android, Windows, macOS) you can be added to the team vault.

Additional equipment

You may need additional hardware such as mobile devices, laptops, etc. You can request this equipment from The Hub.

Bugzilla

You will need to create an account in Mozilla's instance of Bugzilla. See BMO/UserGuide for how to get started. It's helpful to include your IRC/Slack handle in your name field prefixed by : so you can quickly be identified by other users of Bugzilla. Other details that can be helpful are your preferred pronouns, current timezone, and if you're currently on PTO. For example:

 Dave Hunt [:davehunt] [he/him] ⌚BST (away until 1st January 2021)

GitHub

We have a GitHub team for simplifying access to repositories. All team members that belong to the Mozilla organisation should be added to this team as members. Team maintainers can add new members following the process documented here. Other contributors will need to be manually granted access to individual repositories as needed.

Shared folder

We have a shared folder in Google Drive.

Sheriffing

Performance sheriffs will need to complete the following:

Review policy

When you push a commit up for review, you should use the following syntax to request review from the perftest review group:

 r=#perftest

A single r+ from one reviewer is required for the patch to be allowed to be sent off for integration. More reviewers can pitch in on the same review, and Lando will in this case automatically rewrite the commit message to show who was involved signing off the patch, for example:

 Bug 1546611 - Fix "None" checks when validating test manifests; r=perftest,rwood

When you occasionally you have to single out individuals for specific topic expertise, you add an exclamation mark behind the nickname:

 r=#perftest,rwood!

This will add the patch to the shared review queue, but also block the review from landing pending Rob's approval. Requested changes by other reviewers will also block the review.

Duties

Everyone on the team will be expected to carry out the following duties to ensure effective collaboration both within the team, and with other teams.

Code reviews

Visit active revisions in Phabricator every day to:

  • Review any Must Review and Ready to Review patches. Pay particular attention to any patches that have yourself as the sole reviewer. Consider adding the #perftest review group for a wider audience of reviewers. All review requests should receive a response (not necessarily a complete review) within 24 hours.
  • Follow up on any Waiting on Review patches by prompting appropriate team members for a review.
  • Review any Waiting on Authors patches and prompt the authors if there is an action they need to take.

Bugzilla requests

Visit the request queue in Bugzilla every day and filter by your account to see all requests that have been submitted for you. All requests should receive a response within 5 days.