Confirmed users
3,337
edits
Code Review: Difference between revisions
→Tips and Tricks: Update checklist link
(→Tips and Tricks: Update checklist link) |
|||
| Line 33: | Line 33: | ||
* When responding to a review, rebase the patch first, then generate any responses to the review as a separate patch in mercurial. You can post that as the interdiff for the reviewer, and (when ready) hg qfold it into the original (rebased) patch. | * When responding to a review, rebase the patch first, then generate any responses to the review as a separate patch in mercurial. You can post that as the interdiff for the reviewer, and (when ready) hg qfold it into the original (rebased) patch. | ||
* hg diff -r qparent (perhaps aliased in .hgrc to qdiffall) is an easy way to get a rollup of all changes currently applied in the patch queue (such as base patch(es) plus interdiffs. | * hg diff -r qparent (perhaps aliased in .hgrc to qdiffall) is an easy way to get a rollup of all changes currently applied in the patch queue (such as base patch(es) plus interdiffs. | ||
* See https:// | * See https://firefox-source-docs.mozilla.org/contributing/Code_Review_FAQ.html for a checklist of what to look for while actually reviewing changes. | ||