Confirmed users
2,197
edits
Performance/Triage: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
|||
| Line 34: | Line 34: | ||
"resolution": "---", | "resolution": "---", | ||
"f1": "OP", | "f1": "OP", | ||
"f2": " | "f2": "cf_performance_impact", | ||
"o2": "equals", | "o2": "equals", | ||
"v2": "?", | "v2": "?", | ||
| Line 51: | Line 51: | ||
"o8": "notsubstring", | "o8": "notsubstring", | ||
"v8": "meta", | "v8": "meta", | ||
"f9": " | "f9": "cf_performance_impact", | ||
"o9": "isempty", | "o9": "isempty", | ||
"f10": "flagtypes.name", | "f10": "flagtypes.name", | ||
| Line 70: | Line 70: | ||
"resolution": "---", | "resolution": "---", | ||
"f1": "OP", | "f1": "OP", | ||
"f2": " | "f2": "cf_performance_impact", | ||
"o2": "equals", | "o2": "equals", | ||
"v2": "?", | "v2": "?", | ||
| Line 87: | Line 87: | ||
"o8": "notsubstring", | "o8": "notsubstring", | ||
"v8": "meta", | "v8": "meta", | ||
"f9": " | "f9": "cf_performance_impact", | ||
"o9": "isempty", | "o9": "isempty", | ||
"f10": "flagtypes.name", | "f10": "flagtypes.name", | ||
| Line 137: | Line 137: | ||
"o10": "notequals", | "o10": "notequals", | ||
"v10": "Performance", | "v10": "Performance", | ||
"f11": " | "f11": "cf_performance_impact", | ||
"o11": "isempty", | "o11": "isempty", | ||
"j1": "OR", | "j1": "OR", | ||
| Line 147: | Line 147: | ||
= Triage process = | = Triage process = | ||
== Introduction == | == Introduction == | ||
The goal of performance triage is to identify the extent to which bugs impact the performance of our products, and to move these bugs towards an actionable state. The goal is not to diagnose or fix bugs during triage. We triage bugs that have been nominated for triage and bugs in the Core::Performance component that do not have the performance project flag set. | The goal of performance triage is to identify the extent to which bugs impact the performance of our products, and to move these bugs towards an actionable state. The goal is not to diagnose or fix bugs during triage. We triage bugs that have been nominated for triage and bugs in the Core::Performance component that do not have the performance impact project flag set. | ||
During triage we may do any/all of the following: | During triage we may do any/all of the following: | ||
* Request further information from the reporter (such as a profile) | * Request further information from the reporter (such as a profile) | ||
* Set the performance project flag | * Set the performance impact project flag | ||
* Add performance keywords | * Add performance keywords | ||
* Move the bug to a more appropriate component | * Move the bug to a more appropriate component | ||
| Line 168: | Line 168: | ||
# Ask if others would prefer you to share your screen. This can be especially helpful for those new to triage. | # Ask if others would prefer you to share your screen. This can be especially helpful for those new to triage. | ||
# Open the [[#Performance triage|first triage query]] to show bugs nominated for triage or in the Core::Performance component without the performance project flag set. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps: | # Open the [[#Performance triage|first triage query]] to show bugs nominated for triage or in the Core::Performance component without the performance impact project flag set. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps: | ||
#* For defects: Determine if the bug is reproducible and actionable. If not, add a needinfo for the reporter asking for more information and move onto the next bug. We have a [[#New bug|template]] that you can modify as needed. | #* For defects: Determine if the bug is reproducible and actionable. If not, add a needinfo for the reporter asking for more information and move onto the next bug. We have a [[#New bug|template]] that you can modify as needed. | ||
#* For all bugs (including enhancements): | #* For all bugs (including enhancements): | ||
#** Set the [[#How do I determine the performance project flag?|performance project flag]]. | #** Set the [[#How do I determine the performance impact project flag?|performance impact project flag]]. | ||
#** Add the appropriate [[#How do I determine the performance keywords?|performance keywords]]. | #** Add the appropriate [[#How do I determine the performance keywords?|performance keywords]]. | ||
#** Move the bug to the correct [[#How do I determine the correct Bugzilla component?|Bugzilla component]]. | #** Move the bug to the correct [[#How do I determine the correct Bugzilla component?|Bugzilla component]]. | ||
| Line 180: | Line 180: | ||
# If time permits, open the [[#Recently opened bugs with performance keywords in the summary|third triage query]] to show recently opened bugs with performance related keywords in the summary. If any of these look like performance bugs, they can either be triaged the same way as bugs in the initial query or they can be [[#Bugzilla|nominated for triage]] in a subsequent meeting. | # If time permits, open the [[#Recently opened bugs with performance keywords in the summary|third triage query]] to show recently opened bugs with performance related keywords in the summary. If any of these look like performance bugs, they can either be triaged the same way as bugs in the initial query or they can be [[#Bugzilla|nominated for triage]] in a subsequent meeting. | ||
== How do I determine the performance project flag? == | == How do I determine the performance impact project flag? == | ||
The [[../Bugzilla#Project Flag|performance project flag]] is used to indicate a bug’s relationship to the performance of our products. It can be applied to all bugs, and not only defects. The [[#Triage calculator|triage calculator]] should be used to help determine the most appropriate value for this flag. In addition to setting the performance project flag, make sure to use the “Copy Bugzilla Comment” button and paste this as a comment on the bug. | The [[../Bugzilla#Project Flag|performance impact project flag]] is used to indicate a bug’s relationship to the performance of our products. It can be applied to all bugs, and not only defects. The [[#Triage calculator|triage calculator]] should be used to help determine the most appropriate value for this flag. In addition to setting the performance impact project flag, make sure to use the “Copy Bugzilla Comment” button and paste this as a comment on the bug. | ||
== How do I determine the performance keywords? == | == How do I determine the performance keywords? == | ||
| Line 190: | Line 190: | ||
= Triage calculator = | = Triage calculator = | ||
The [https://codepen.io/mstange/pen/eYeWrGr Performance | The [https://codepen.io/mstange/pen/eYeWrGr Performance Impact Calculator] was developed to assist in identifying and applying the [[../Bugzilla#Project Flag|performance impact project flag]] and [[../Bugzilla#Keywords|performance keywords]] consistently. If you have feedback or would like to suggest changes to this tool, please share these in the [https://chat.mozilla.org/#/room/#perf-triage:mozilla.org #perf-triage Matrix channel]. | ||
= Triage rotation = | = Triage rotation = | ||