Performance Triage

From MozillaWiki
Jump to: navigation, search


Idea.png
If you have any feedback/suggestions/questions regarding the performance triage process, you can share them in #perf-triage, or reach out to Dave Hunt or Frank Doty.

Nomination

Bugzilla

To (re)nominate a bug for triage, set the Performance Impact flag in Bugzilla to ?

This can be found by clicking Show Advanced Fields followed by Set bug flags when entering a new bug:

Bugzilla performance nomination on new bug form.png

Or by expanding the Tracking section when editing an existing bug:

Screenshot 2022-02-24 at 19.53.54.png

GitHub

To nominate a bug for triage, add the Performance label to an issue. This can be done by filing an new issue with the "Performance issue" template:

Screenshot of file a "Performance issue" template on GitHub

Or by opening an existing issue on GitHub and selecting the label from the right-hand bar:

Screenshot of adding a performance label on GitHub

Currently, only the following GitHub repositories are supported:

Queries

Performance triage

Full Query
ID Summary Status
1304389 Session Restore generates sustained large disk traffic [meta] NEW
1885382 Basically, Firefox is eating a bit too much RAM (on normal usage) UNCONFIRMED
1890261 The content inside the New Tab page is shaking after opening a new tab. NEW
1893367 excessive memory use UNCONFIRMED
1893481 Firefox uses all RAM when run for several days UNCONFIRMED
1893551 Firefox commit growing by 14MiB per second when used while Windows system disk is out of space NEW
1893697 Grabs all my memory on AI chatbot page - started with update around 4/19/24 UNCONFIRMED
1893881 randomly massive memory usage with browser freeze UNCONFIRMED
1894286 Multiple gigabytes of tiny detached windows UNCONFIRMED
1896500 Memory Leak on newest version. 14 task manager occurrences from one tab open using over a gig of memory. Laptop is overheating and only fix is reset computer. UNCONFIRMED
1897637 Firefox consumes 65 GB RAM UNCONFIRMED
1898645 FIrefox Uses more RAM the longer which it stays on regarless of activity. UNCONFIRMED
1900669 Mozilla is using too much memory, keeps crashing UNCONFIRMED
1900881 ASan Nightly memory leak on certain webpages UNCONFIRMED
1900883 app.retrium.com freezes browser and crashes tab when it finally reached a 502/504 NEW
1902691 Ram Usage over 3k UNCONFIRMED
1904184 Opening a page shows 150ms spent in json stuff that is categorized under "Network" jank NEW
1904273 Firefox using a large and unexpected amount of memory UNCONFIRMED

18 Total; 18 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Performance triage (pending-needinfo)

Full Query
ID Summary Status
1606631 Inefficient z-ordering of elements in the browser UI, causes large layers with current WebRender heuristics ASSIGNED
1805255 Firefox has 50% more soft page faults than Chrome running Speedometer 2 NEW
1870532 Firefox 120.0.1 grabs 100% of cpu resources and freezes UNCONFIRMED
1872368 Since the last update 121.0 Firefox uses insane amount of Ram 99% of my 32GB without any real reason and if it gets closed it buges out for 10 seconds spikes over the ram limit just to slowly close UNCONFIRMED
1872414 Firefox lags after latest update, high memory use (121.0 12-2023) UNCONFIRMED
1875547 Slow (single-threaded) PDF rendering for documents with lots of vector shapes NEW
1876708 firefox using 3.4gb of memory with a few tabs open UNCONFIRMED
1877007 extremely high CPU usage even with one tab open on the splash screen UNCONFIRMED
1879177 3 youtube tabs are using 7GB of RAM UNCONFIRMED
1879905 firefox consuming 2 GB of RAM with 8 tabs open UNCONFIRMED
1882916 Firefox consumes a lot of CPU and makes me Mac M2 hang for a good 15 seconds UNCONFIRMED
1882952 Firefox Browser Freezes when Opening Multiple Tabs UNCONFIRMED
1883246 firefox using large amount of memory UNCONFIRMED
1883475 huge amount of memory storage (constantly) idk why pls help/................................................................................................................................................. UNCONFIRMED
1883507 Memory usage is too high 23GB and up to 60% CPU usage. UNCONFIRMED
1883669 Memory Problem UNCONFIRMED
1884296 Firefox is using lots of memory when only having several tabs open UNCONFIRMED
1885796 Use to many Ram UNCONFIRMED
1891345 Enourmous RAM usage (60Gig) UNCONFIRMED
1891878 I believe that Mozilla Firefox has memory leak issues. UNCONFIRMED
1893080 Uses a lot of ram, literally a lot even for less number of tabs opened UNCONFIRMED
1893459 Memory Leak (Isolated Web Container) UNCONFIRMED

22 Total; 22 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Recently opened bugs with performance keywords in the summary

Full Query
ID Summary Status
1901501 After update, the Find things faster introduction popup is displayed even in kiosk mode UNCONFIRMED
1901594 Tab switching uses a lot of CPU time by writing session store NEW
1901708 Rendering of Tracemonkey PDF slower on Mac with hardware acceleration enabled NEW
1901798 Remove #ifndef ANDROID blocks after the ongoing glean performance impact on android gets addressed NEW
1901816 Look into improving download or delete all translations model download experience NEW
1901948 www.youtube.com - Performance issues with AMD specific devices NEW
1902047 Video freezes momentarily, sometimes audio de-sync when playing >1080p30 video fast (>2x speed) on Apple M1 Pro UNCONFIRMED
1902076 onnxruntime webgpu backend doesn't work in Firefox NEW
1902200 JS demo (https://www.fxhash.xyz/generative/26665) is ~2x slower in Nightly NEW
1902227 Consider applying upstream ffmpeg patches to fix Radeon AV1 va-api bug affecting mesa > 24.0.7+ (Stuttering, delays, frame drops) and to reduce memory usage for other drivers NEW
1902288 Check if we support 16 KB memory page sizes NEW
1902316 Firefox slow down WinAppDriver in catastrofic scale (in 100 times) UNCONFIRMED
1902352 A screen reader does not announce when a full page translation is completed NEW
1902567 Consider adding indicators that highlight (to the end-user) known perf cliffs - with, eval, generators etc. NEW
1902665 The Translation Beta accessible name is not announced by ORCA when opening the Select Translations panel on Ubuntu NEW
1902750 Consider connecting clearing the Translations "cache" as a part of Clear Data Service NEW
1902762 Update how clearing the cache works for Translations on Fenix NEW
1902828 Please include the local translation as an additional component UNCONFIRMED
1902846 Codepen demo (https://codepen.io/brownerd/pen/YydvvW?editors=1100) performs worse in Nightly (4600 draw calls per iteration) NEW
1902859 Improve Select Translations Multi-Locale Preferred Language Tests NEW
1902860 Firefox amdgpu 780M flickering Fedora 40 KDE UNCONFIRMED
1902867 WebGL aquarium - Firefox much slower than Edge (Ryzen 7 5700u) UNCONFIRMED
1903051 Massive parent process jank when hovering over a video in google drive. NEW
1903072 Make `about:translations` or else direct translations more accessible on Android NEW
1903088 Blob/File constructors should spill large blobs to (ideally quota-managed) disk storage to reduce memory usage NEW
1903102 Change usage of WebGPU to use vertex pulling transform (only meaningful for macOS/Metal) all the time NEW
1903396 WebExtension / port.postMessage Memory Leak UNCONFIRMED
1903420 Refactor Fast Rejection in Selector Matching NEW
1903484 Janky WebRender scrolling on spiegel.de when animated ad scrolls in. NEW
1903553 Talos tests do not catch frame building performance regressions NEW
1903554 Improve the slow frame summay in the profiler HUD NEW
1903557 Add telemetry for slow frame categories NEW
1903657 Remove Battery API (BatteryManager/navigator.getBattery) NEW
1903764 Have a performance test for shutdown NEW
1903766 Add service worker update perftests NEW
1903768 Excessive CPU Usage in Firefox for Android UNCONFIRMED
1903772 Subscribe and Login buttons are missing from the header on bohuslaningen.se with Strict ETP NEW
1904144 Restrict "Firefox Translations" extension to Firefox ESR 115 UNCONFIRMED
1904174 26GB of memory being used in the main process under gfx. GPU-process is not present. NEW
1904176 Allow SelectTranslationsPanel Footer Buttons To Expand the Panel Horizontally Instead of Vertically NEW
1904185 JS demo (https://codepen.io/Bupeldox/pen/rNgjrdQ) is 4.6x slower in Nightly NEW
1904254 100%+ CPU usage with latest version of Firefox on macOS Sonoma 14.5, app hangs when quitting and is hogging tons of resources UNCONFIRMED
1904259 Translator detects incorrect source language on website UNCONFIRMED
1904260 Translate hides elements on website UNCONFIRMED
1904289 Use VkImage for WebGPU presentation without readback on Linux NEW

45 Total; 45 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Triage process

Introduction

The goal of performance triage is to identify the extent to which bugs impact the performance of our products, and to move these bugs towards an actionable state. The goal is not to diagnose or fix bugs during triage. We triage bugs that have been nominated for triage and bugs in the Core::Performance component that do not have the performance impact project flag set.

During triage we may do any/all of the following:

  • Request further information from the reporter (such as a profile)
  • Set the performance impact project flag
  • Add performance keywords
  • Move the bug to a more appropriate component

Who is responsible for triage?

Everyone is welcome to take part in triage. By default, everyone on the performance team is enrolled in triage rotation, but we also have participants from outside the team.

How do I schedule a triage meeting?

If you are on triage duty, you will receive an invitation as a reminder to schedule the triage meeting on the shared performance calendar with the nominated sheriffs invited at a time that works for them. The responsibility of scheduling the meeting falls to the lead sheriff. Once a triage meeting has been scheduled, it’s a good idea to remove the reminder event from the calendar to avoid confusion. It’s a good idea to use the shared calendar, as this increases the visibility of the performance triage and allows other members of the team to contribute or observe the process.

What if a sheriff is unavailable?

The rotation script is not perfect, and doesn’t know when people are on PTO or otherwise unavailable. If the lead sheriff is available, it is their responsibility to either schedule the triage with the remaining available sheriff or to identify a suitable substitute for the unavailable sheriff(s). If the lead sheriff is unavailable, this responsibility passes onto the remaining available sheriffs.

How do I run a triage meeting?

The following describes the triage process to follow during the meeting:

  1. Ask if others would prefer you to share your screen. This can be especially helpful for those new to triage.
  2. Open the first triage query to show bugs nominated for triage or in the Core::Performance component without the performance impact project flag set. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps:
    • Bugs that look like tasks that were filed by members of the Performance team will generally need to be moved to the Core::Performance Engineering component.
    • For defects: Determine if the bug is reproducible and actionable. If not, add a needinfo for the reporter asking for more information, set the performance impact project flag to pending-needinfo, and then move onto the next bug. We have a template that you can modify as needed.
    • For all bugs (including enhancements):
  3. Open the second triage query to show bugs that are waiting further information to determine the performance impact. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps:
    • If the performance impact project flag was set to pending-needinfo less than 2 weeks ago, move onto the next bug.
    • If the performance impact project flag was set to pending-needinfo more than 2 weeks ago but less than 2 months ago, consider adding a needinfo for either: another reporter of the issue, someone with access to the appropriate platform(s) to attempt to reproduce the issue, or a relevant subject matter expert.
    • If the performance impact project flag was set to pending-needinfo more than 2 months ago, close the bug as inactive. You can modify the inactive bug template as needed.
  4. If time permits, open the third triage query to show recently opened bugs with performance related keywords in the summary. If any of these look like performance bugs, they can either be triaged the same way as bugs in the initial query or they can be nominated for triage in a subsequent meeting.

What if things don't go as expected?

Don't panic! The triage process is not expected to be perfect, and can improve with your feedback. Maybe the result of the triage calculator doesn't feel right, or you find a scenario that's not covered in these guidelines. In this case we recommend that you bring it up in #perf-triage, or consider scheduling a short meeting with some triage leads (you can see some recent leads in the triage rotation). If in doubt, leave a comment on the bug with your thoughts and move on. There's a chance someone will respond, but if not the next performance triage sheriffs may have some other ideas.

How do I determine the performance impact project flag?

The performance impact project flag is used to indicate a bug’s relationship to the performance of our products. It can be applied to all bugs, and not only defects. The triage calculator should be used to help determine the most appropriate value for this flag. In addition to setting the performance impact project flag, make sure to use the “Copy Bugzilla Comment” button and paste this as a comment on the bug.

If you do not have enough information to set the performance impact project flag, open a needinfo request against an appropriate individual (such as a reporter), and set the performance impact project flag to pending-needinfo.

For more information about what this flag, and it's settings mean see this blog post.

How do I determine the performance keywords?

There are several performance related keywords, which can be helpful to understand how our performance issues are distributed, or whenever there’s a concerted effort to improve a particular aspect of our products. The triage calculator may recommend keywords to set, and by typing “perf:” in the keywords field in Bugzilla, you will see the available options. Select all that apply to the bug.

How do I determine the correct Bugzilla component?

Ideally we would only have bugs in the Core::Performance component that are the responsibility of the engineers in the performance team. For performance bugs to have the best chance of being fixed, it's important to assign them to the correct component. In some cases the correct component will be obvious from the bug summary, description, or steps to reproduce. In other cases, you may need to do a bit more work to identify the component. For example, if there's a profile associated with the bug, you could see where the majority of time is being spent using the category annotations.

How do I read a performance profile?

It's useful to be able to understand a profile generated by the Firefox Profiler, and hopefully someone in the triage meeting will be able to help. If you find an interesting profile, or just want to understand how to use them to analyse a performance problem, we encourage you to post a link to the profile (or bug) in #joy-of-profiling where someone will be happy to help. The profile may even be analysed during one of the regular "Joy of Profiling" open sessions that can be found on the Performance Office Hours calendar.

Triage calculator

The Performance Impact Calculator was developed to assist in identifying and applying the performance impact project flag and performance keywords consistently. If you have feedback or would like to suggest changes to this tool, please share these in the #perf-triage Matrix channel.

Triage rotation

The sheriffs are allocated on a weekly basis, which is published here. The rotation is generated by this script.

Templates

New bug

This template is included in the description for new bugs opened in the Core::Performance component. If a bug is opened in another component and then moved to Core::Performance, this template can be used as needed to request additional information from the reporter.

### Basic information

Steps to Reproduce:


Expected Results:


Actual Results:


---

### Performance recording (profile)

Profile URL:
(If this report is about slow performance or high CPU usage, please capture a performance profile by following the instructions at https://profiler.firefox.com/. Then upload the profile and insert the link here.)

#### System configuration:

OS version:
GPU model:
Number of cores: 
Amount of memory (RAM): 

### More information

Please consider attaching the following information after filing this bug, if relevant:

 - Screenshot / screen recording
 - Anonymized about:memory dump, for issues with memory usage
 - Troubleshooting information: Go to about:support, click "Copy text to clipboard", paste it to a file, save it, and attach the file here.

---

Thanks so much for your help.

Moved to Core::Performance

This bug was moved into the Performance component. Reporter, could you make sure the following information is on this bug?

 - For slowness or high CPU usage, capture a profile with http://profiler.firefox.com/ , upload it and share the link here.
 - For memory usage issues, capture a memory dump from about:memory and attach it to this bug.
 - Troubleshooting information: Go to about:support, click "Copy raw data to clipboard", paste it into a file, save it, and attach the file here.

Thank you.

No longer able to reproduce

This bug doesn’t seem to happen anymore in current versions of Firefox. Please reopen or file a new bug if you see it again.

No response from reporter

With no answer from the reporter, we don’t have enough data to reproduce and/or fix this issue. Please reopen or file a new bug with more information if you see it again.

Expected behaviour

This is expected behavior. Please reopen or file a new bug if you think otherwise.

Website issue

According to the investigation, this is a website issue. Please reopen or file a new bug if you think otherwise.