Performance Triage

From MozillaWiki
Jump to: navigation, search


Idea.png
If you have any feedback/suggestions/questions regarding the performance triage process, you can share them in #perf-triage, or reach out to Dave Hunt or Frank Doty.

Nomination

Bugzilla

To (re)nominate a bug for triage, set the Performance Impact flag in Bugzilla to ?

This can be found by clicking Show Advanced Fields followed by Set bug flags when entering a new bug:

Bugzilla performance nomination on new bug form.png

Or by expanding the Tracking section when editing an existing bug:

Screenshot 2022-02-24 at 19.53.54.png

GitHub

To nominate a bug for triage, add the Performance label to an issue. This can be done by filing an new issue with the "Performance issue" template:

Screenshot of file a "Performance issue" template on GitHub

Or by opening an existing issue on GitHub and selecting the label from the right-hand bar:

Screenshot of adding a performance label on GitHub

Currently, only the following GitHub repositories are supported:

Queries

Performance triage

Full Query
ID Summary Status
1238503 [e10s] Elements on page don't immediately respond to page scrolling with mouse wheel ASSIGNED
1304389 Session Restore generates sustained large disk traffic [meta] NEW
1766181 Firefox becomes really slow to respond/switch to on MacBook Pro M1 Max UNCONFIRMED
1885382 Basically, Firefox is eating a bit too much RAM (on normal usage) UNCONFIRMED
1890261 The content inside the New Tab page is shaking after opening a new tab. NEW
1891878 I believe that Mozilla Firefox has memory leak issues. UNCONFIRMED
1893367 excessive memory use UNCONFIRMED
1893481 Firefox uses all RAM when run for several days UNCONFIRMED
1893551 Firefox commit growing by 14MiB per second when used while Windows system disk is out of space NEW
1893697 Grabs all my memory on AI chatbot page - started with update around 4/19/24 UNCONFIRMED
1893881 randomly massive memory usage with browser freeze UNCONFIRMED
1894286 Multiple gigabytes of tiny detached windows UNCONFIRMED
1896500 Memory Leak on newest version. 14 task manager occurrences from one tab open using over a gig of memory. Laptop is overheating and only fix is reset computer. UNCONFIRMED
1897637 Firefox consumes 65 GB RAM UNCONFIRMED
1898319 firefox slows down, needs relaunch to restore throughput UNCONFIRMED
1900669 Mozilla is using too much memory, keeps crashing UNCONFIRMED
1900881 ASan Nightly memory leak on certain webpages UNCONFIRMED
1900883 app.retrium.com freezes browser and crashes tab when it finally reached a 502/504 NEW
1901468 React rerenders are very slow UNCONFIRMED
1902691 Ram Usage over 3k UNCONFIRMED
1904184 Opening a page shows 150ms spent in json stuff that is categorized under "Network" jank NEW
1904273 Firefox using a large and unexpected amount of memory UNCONFIRMED
1904284 Opening https://colorjs.io/ keeps the parent-process very busy for 4+seconds, spending tons of time in network-y IPC. This results in stutter while scrolling REOPENED
1905038 connect.mozilla.org causes Firefox become unresponsive requiring "end task" UNCONFIRMED
1905784 Latest Update has destroyed performance UNCONFIRMED
1906276 theweathernetwork.com - The map is populated slow compared to Chrome NEW
1906726 Fenix pageload progress bar can take multiple times longer to complete than Chrome (e.g. 50 seconds vs 10 seconds) NEW
1907701 Opening reddit posts spends a lot of time on the parent process NEW
1907708 Firefox no long scrolls with middle-mouse wheel unless window is raised to top level UNCONFIRMED
1907716 Firefox used up most of my system RAM UNCONFIRMED

30 Total; 30 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Performance triage (pending-needinfo)

Full Query
ID Summary Status
1805255 Firefox has 50% more soft page faults than Chrome running Speedometer 2 NEW
1870532 Firefox 120.0.1 grabs 100% of cpu resources and freezes UNCONFIRMED
1875547 Slow (single-threaded) PDF rendering for documents with lots of vector shapes NEW
1876708 firefox using 3.4gb of memory with a few tabs open UNCONFIRMED
1877007 extremely high CPU usage even with one tab open on the splash screen UNCONFIRMED
1879177 3 youtube tabs are using 7GB of RAM UNCONFIRMED
1879905 firefox consuming 2 GB of RAM with 8 tabs open UNCONFIRMED
1882916 Firefox consumes a lot of CPU and makes me Mac M2 hang for a good 15 seconds UNCONFIRMED
1882952 Firefox Browser Freezes when Opening Multiple Tabs UNCONFIRMED
1883246 firefox using large amount of memory UNCONFIRMED
1883475 huge amount of memory storage (constantly) idk why pls help/................................................................................................................................................. UNCONFIRMED
1883507 Memory usage is too high 23GB and up to 60% CPU usage. UNCONFIRMED
1883669 Memory Problem UNCONFIRMED
1884296 Firefox is using lots of memory when only having several tabs open UNCONFIRMED
1885796 Use to many Ram UNCONFIRMED
1891345 Enourmous RAM usage (60Gig) UNCONFIRMED
1893080 Uses a lot of ram, literally a lot even for less number of tabs opened UNCONFIRMED
1893459 Memory Leak (Isolated Web Container) UNCONFIRMED

18 Total; 18 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Recently opened bugs with performance keywords in the summary

Full Query
ID Summary Status
1906882 gpu drawing 200 watts watching video on any resolution past 360p UNCONFIRMED
1906921 Slack tabs hung up for minutes in LSObject::StoreDatabase NEW
1907135 We seem to fall back to software WebRender on Android if the GPU process is killed too many times NEW
1907139 Large images that are scaled down are slow to paint repeatedly with SWGL NEW
1907149 Remove full page translations Nimbus configurations NEW
1907224 Uncaptured WebGPU error without device target: Not enough memory left to request device NEW
1907244 Lots of jank when pinch zooming/panning on test case UNCONFIRMED
1907266 Canvas performance regression if Firefox is built with GCC/PGO NEW
1907364 ProxyResolution thread can use significant CPU on high request documents NEW
1907381 Expanding the video preview on Netflix is a bit janky and appears to spend time in JS NEW
1907408 Slow load of Firefox View NEW
1907411 WebGPU: <https://shinylasers.com/playground>'s default example does not run NEW
1907457 Hit MOZ_CRASH(RenderBundle[Id(4,1,vk)] does not exist) at /builds/worker/checkouts/gecko/third_party/rust/wgpu-core/src/storage.rs:113 NEW
1907513 Animated gif freezes when you're not interacting with page, with `transform-style:preserve-3d;` and `transform:translate3d(0,0,0);` on ancestors NEW
1907597 Dropdown menus aren't translated NEW
1907632 Missing translate pop-up in Firefox 128 UNCONFIRMED
1907728 recovery.jsonlz4 is not created ("out of memory") UNCONFIRMED
1907771 Certain websites are not translated despite language tag UNCONFIRMED
1907834 Code selection causes the browser to hang at 100% CPU load with Windows Text Cursor Indicator enabled UNCONFIRMED
1907842 Use ICU4X for nsIDNService::IsLabelSafe NEW
1907929 Memory leak when accessibility is not force disabled UNCONFIRMED
1908056 Slack huddles are not working anymore with Firefox 128 on MacOS UNCONFIRMED
1908257 15+ second janks of Main Process Mainthread when scrolling with mouse wheel NEW
1908276 3D CSS Circles demo is very slow in Firefox NEW
1908286 Canvas demo is slower in Nightly (d2d/gpu/skia) compared to Chrome NEW
1908365 Dwitter canvas demo is slower with gpu-canvas compared to skia-canvas (time is spent in WPF) NEW
1908541 Very high memory and cpu usage on new instalation of firefox and windows UNCONFIRMED
1908542 [SPIKE] Skylight - improve performance by pre-fetching template queries and pre-populating the cache NEW
1908550 Add translation support for CSS `content` property UNCONFIRMED
1908585 Disable overlay only for slow present video NEW
1908782 Align gear button beta label in translation panel NEW
1908916 Promote `webgpu:shader,execution,memory_model,weak:*` CTS tests to tier 2 NEW
1908999 Sticky description text in Android Full Page Translations Global Settings NEW
1909000 Missing translation button / download of languages not possible UNCONFIRMED
1909083 JS demo (https://www.fxhash.xyz/generative/slug/fit) is more 2x slower in Nightly NEW
1909123 Precision touchpad scrolling is far jankier/stuttery than it should be NEW
1909152 Multiple share sheets opened if tapping fast on the share button from the address bar NEW
1909154 Multiple menus opened if tapping fast on toolbar's 3dot menu NEW
1909168 Implement a fast-path for `Element.insertAdjacentHTML` when trusted types are disabled NEW

39 Total; 39 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Triage process

Introduction

The goal of performance triage is to identify the extent to which bugs impact the performance of our products, and to move these bugs towards an actionable state. The goal is not to diagnose or fix bugs during triage. We triage bugs that have been nominated for triage and bugs in the Core::Performance component that do not have the performance impact project flag set.

During triage we may do any/all of the following:

  • Request further information from the reporter (such as a profile)
  • Set the performance impact project flag
  • Add performance keywords
  • Move the bug to a more appropriate component

Who is responsible for triage?

Everyone is welcome to take part in triage. By default, everyone on the performance team is enrolled in triage rotation, but we also have participants from outside the team.

How do I schedule a triage meeting?

If you are on triage duty, you will receive an invitation as a reminder to schedule the triage meeting on the shared performance calendar with the nominated sheriffs invited at a time that works for them. The responsibility of scheduling the meeting falls to the lead sheriff. Once a triage meeting has been scheduled, it’s a good idea to remove the reminder event from the calendar to avoid confusion. It’s a good idea to use the shared calendar, as this increases the visibility of the performance triage and allows other members of the team to contribute or observe the process.

What if a sheriff is unavailable?

The rotation script is not perfect, and doesn’t know when people are on PTO or otherwise unavailable. If the lead sheriff is available, it is their responsibility to either schedule the triage with the remaining available sheriff or to identify a suitable substitute for the unavailable sheriff(s). If the lead sheriff is unavailable, this responsibility passes onto the remaining available sheriffs.

How do I run a triage meeting?

The following describes the triage process to follow during the meeting:

  1. Ask if others would prefer you to share your screen. This can be especially helpful for those new to triage.
  2. Open the first triage query to show bugs nominated for triage or in the Core::Performance component without the performance impact project flag set. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps:
    • Bugs that look like tasks that were filed by members of the Performance team will generally need to be moved to the Core::Performance Engineering component.
    • For defects: Determine if the bug is reproducible and actionable. If not, add a needinfo for the reporter asking for more information, set the performance impact project flag to pending-needinfo, and then move onto the next bug. We have a template that you can modify as needed.
    • For all bugs (including enhancements):
  3. Open the second triage query to show bugs that are waiting further information to determine the performance impact. The bugs are sorted from oldest to newest. For each bug in the list, follow these steps:
    • If the performance impact project flag was set to pending-needinfo less than 2 weeks ago, move onto the next bug.
    • If the performance impact project flag was set to pending-needinfo more than 2 weeks ago but less than 2 months ago, consider adding a needinfo for either: another reporter of the issue, someone with access to the appropriate platform(s) to attempt to reproduce the issue, or a relevant subject matter expert.
    • If the performance impact project flag was set to pending-needinfo more than 2 months ago, close the bug as inactive. You can modify the inactive bug template as needed.
  4. If time permits, open the third triage query to show recently opened bugs with performance related keywords in the summary. If any of these look like performance bugs, they can either be triaged the same way as bugs in the initial query or they can be nominated for triage in a subsequent meeting.

What if things don't go as expected?

Don't panic! The triage process is not expected to be perfect, and can improve with your feedback. Maybe the result of the triage calculator doesn't feel right, or you find a scenario that's not covered in these guidelines. In this case we recommend that you bring it up in #perf-triage, or consider scheduling a short meeting with some triage leads (you can see some recent leads in the triage rotation). If in doubt, leave a comment on the bug with your thoughts and move on. There's a chance someone will respond, but if not the next performance triage sheriffs may have some other ideas.

How do I determine the performance impact project flag?

The performance impact project flag is used to indicate a bug’s relationship to the performance of our products. It can be applied to all bugs, and not only defects. The triage calculator should be used to help determine the most appropriate value for this flag. In addition to setting the performance impact project flag, make sure to use the “Copy Bugzilla Comment” button and paste this as a comment on the bug.

If you do not have enough information to set the performance impact project flag, open a needinfo request against an appropriate individual (such as a reporter), and set the performance impact project flag to pending-needinfo.

For more information about what this flag, and it's settings mean see this blog post.

How do I determine the performance keywords?

There are several performance related keywords, which can be helpful to understand how our performance issues are distributed, or whenever there’s a concerted effort to improve a particular aspect of our products. The triage calculator may recommend keywords to set, and by typing “perf:” in the keywords field in Bugzilla, you will see the available options. Select all that apply to the bug.

How do I determine the correct Bugzilla component?

Ideally we would only have bugs in the Core::Performance component that are the responsibility of the engineers in the performance team. For performance bugs to have the best chance of being fixed, it's important to assign them to the correct component. In some cases the correct component will be obvious from the bug summary, description, or steps to reproduce. In other cases, you may need to do a bit more work to identify the component. For example, if there's a profile associated with the bug, you could see where the majority of time is being spent using the category annotations.

How do I read a performance profile?

It's useful to be able to understand a profile generated by the Firefox Profiler, and hopefully someone in the triage meeting will be able to help. If you find an interesting profile, or just want to understand how to use them to analyse a performance problem, we encourage you to post a link to the profile (or bug) in #joy-of-profiling where someone will be happy to help. The profile may even be analysed during one of the regular "Joy of Profiling" open sessions that can be found on the Performance Office Hours calendar.

Triage calculator

The Performance Impact Calculator was developed to assist in identifying and applying the performance impact project flag and performance keywords consistently. If you have feedback or would like to suggest changes to this tool, please share these in the #perf-triage Matrix channel.

Triage rotation

The sheriffs are allocated on a weekly basis, which is published here. The rotation is generated by this script.

Templates

New bug

This template is included in the description for new bugs opened in the Core::Performance component. If a bug is opened in another component and then moved to Core::Performance, this template can be used as needed to request additional information from the reporter.

### Basic information

Steps to Reproduce:


Expected Results:


Actual Results:


---

### Performance recording (profile)

Profile URL:
(If this report is about slow performance or high CPU usage, please capture a performance profile by following the instructions at https://profiler.firefox.com/. Then upload the profile and insert the link here.)

#### System configuration:

OS version:
GPU model:
Number of cores: 
Amount of memory (RAM): 

### More information

Please consider attaching the following information after filing this bug, if relevant:

 - Screenshot / screen recording
 - Anonymized about:memory dump, for issues with memory usage
 - Troubleshooting information: Go to about:support, click "Copy text to clipboard", paste it to a file, save it, and attach the file here.

---

Thanks so much for your help.

Moved to Core::Performance

This bug was moved into the Performance component. Reporter, could you make sure the following information is on this bug?

 - For slowness or high CPU usage, capture a profile with http://profiler.firefox.com/ , upload it and share the link here.
 - For memory usage issues, capture a memory dump from about:memory and attach it to this bug.
 - Troubleshooting information: Go to about:support, click "Copy raw data to clipboard", paste it into a file, save it, and attach the file here.

Thank you.

No longer able to reproduce

This bug doesn’t seem to happen anymore in current versions of Firefox. Please reopen or file a new bug if you see it again.

No response from reporter

With no answer from the reporter, we don’t have enough data to reproduce and/or fix this issue. Please reopen or file a new bug with more information if you see it again.

Expected behaviour

This is expected behavior. Please reopen or file a new bug if you think otherwise.

Website issue

According to the investigation, this is a website issue. Please reopen or file a new bug if you think otherwise.