Confirmed users
729
edits
Security/ReviewTopics: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
|||
| Line 54: | Line 54: | ||
* If so, what is the proposal's relationship to their work? Do you depend on others' work, or vice-versa? | * If so, what is the proposal's relationship to their work? Do you depend on others' work, or vice-versa? | ||
* Are you updating, copying or changing functional areas maintained by other groups? How are you coordinating and communicating with them? Do they "approve" of what you propose? | * Are you updating, copying or changing functional areas maintained by other groups? How are you coordinating and communicating with them? Do they "approve" of what you propose? | ||
== C and C++ == | |||
* Did you minimize use of unsafe languages? | |||
* Did you minimize and isolate use of low-level constructs (manual allocation, manual refcounting, union tricks such as bit-stealing, and pointer arithmetic)? | |||
* Are new C++ files on the no-compiler-warnings list? | |||
* Are new C++ classes annotated for Mozilla's dehydra analyses? | |||
* Do you use [http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/CheckedInt.h CheckedInt] where integer overflows could be an issue? | |||
* Does the code use assertions to make it easier to catch bugs? | |||
* Are the safety-critical invariants clear in the code and in your mind? | |||
* What would make you more confident in the code's safety? | |||