Confirmed users
729
edits
Security/ReviewTopics: Difference between revisions
Jump to navigation
Jump to search
→C and C++
No edit summary |
|||
| Line 56: | Line 56: | ||
== C and C++ == | == C and C++ == | ||
* Did you minimize and isolate use of low-level constructs (manual allocation, manual refcounting, union tricks such as bit-stealing, and pointer arithmetic)? | * Did you minimize and isolate use of low-level constructs (manual allocation, manual refcounting, union tricks such as bit-stealing, and pointer arithmetic)? | ||
* Are new C++ files on the no-compiler-warnings list? | * Are new C++ files on the no-compiler-warnings list? | ||
| Line 62: | Line 61: | ||
* Do you use [http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/CheckedInt.h CheckedInt] where integer overflows could be an issue? | * Do you use [http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/CheckedInt.h CheckedInt] where integer overflows could be an issue? | ||
* Does the code use assertions to make it easier to catch bugs? | * Does the code use assertions to make it easier to catch bugs? | ||
* Are the safety-critical invariants | * Are the safety-critical invariants documented? | ||
* What would make you more confident in the code's safety? | * What would make you more confident in the code's safety? | ||