Confirmed users
729
edits
Security/ReviewTopics: Difference between revisions
Jump to navigation
Jump to search
→C and C++
| Line 57: | Line 57: | ||
== C and C++ == | == C and C++ == | ||
* Did you minimize and isolate use of low-level constructs (manual allocation, manual refcounting, union tricks such as bit-stealing, and pointer arithmetic)? | * Did you minimize and isolate use of low-level constructs (manual allocation, manual refcounting, union tricks such as bit-stealing, and pointer arithmetic)? | ||
* | * Does your code [http://mxr.mozilla.org/mozilla-central/search?string=FAIL_ON_WARNINGS build without warnings]? | ||
* Are new C++ classes annotated for Mozilla's dehydra analyses? | * Are new C++ classes annotated for Mozilla's dehydra analyses? | ||
* Do you use [http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/CheckedInt.h CheckedInt] where integer overflows could be an issue? | * Do you use [http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/CheckedInt.h CheckedInt] where integer overflows could be an issue? | ||