Confirmed users
137
edits
QA/Execution/Web Testing/Docs/Automation/StyleGuide: Difference between revisions
QA/Execution/Web Testing/Docs/Automation/StyleGuide (view source)
Revision as of 13:17, 3 October 2011
, 3 October 2011→Size of patches
(added page region) |
|||
| Line 141: | Line 141: | ||
= Size of patches = | = Size of patches = | ||
To make sure that we can review your patch as quickly and efficiently as possibly we would like patches to have 1 test in them and the necessary changes to the Page Objects. This also limits the chances of merge conflicts later. | To make sure that we can review your patch as quickly and efficiently as possibly we would like patches to have 1 test in them and the necessary changes to the Page Objects. This also limits the chances of merge conflicts later. | ||
== Using new and old standards together == | |||
As we (and Selenium and automation) develop more knowledge some projects might fall behind the standards in this style guide. It can be tempting to want to fix all of the outdated style but in order to keep patches/pulls small (see above!) we are happy to have new and old standards of code sit side by side. As we regularly review and update tests the project will be brought completely up to our current standards. | |||
Or if you prefer, log a Pivotal job or an issue to have a section of code addressed separately to the job you are doing. | |||