272
edits
Thunderbird:CodeCleanup: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
|||
| Line 75: | Line 75: | ||
<span class="highlightblue">+ NS_IF_ADDREF(*aIdentity = m_identity);</span> | <span class="highlightblue">+ NS_IF_ADDREF(*aIdentity = m_identity);</span> | ||
== Validating Input Arguments == | == Validating Input Arguments & Return Values == | ||
Use NS_ENSURE_ARG_POINTER to validate argument pointers instead of explicitly validating the argument: | Use NS_ENSURE_ARG_POINTER to validate argument pointers instead of explicitly validating the argument: | ||
| Line 91: | Line 91: | ||
<span class="highlightred">- if (!m_identities) return NS_ERROR_FAILURE;</span> | <span class="highlightred">- if (!m_identities) return NS_ERROR_FAILURE;</span> | ||
<span class="highlightblue">+ NS_ENSURE_TRUE(m_identities, NS_ERROR_FAILURE);</span> | <span class="highlightblue">+ NS_ENSURE_TRUE(m_identities, NS_ERROR_FAILURE);</span> | ||
I see a surprising amount of return value code that looks like: | |||
<span class="highlightred">- if (!*_retval) return NS_ERROR_FAILURE; | |||
- return NS_OK;</span> | |||
<span class="highlightblue">+ return (*retval) ? NS_OK : NS_ERROR_FAILURE</span> | |||
== nsISupportsArray == | == nsISupportsArray == | ||