272
edits
Thunderbird:CodeCleanup: Difference between revisions
Jump to navigation
Jump to search
→Validating Input Arguments & Return Values
No edit summary |
|||
| Line 97: | Line 97: | ||
- return NS_OK;</span> | - return NS_OK;</span> | ||
<span class="highlightblue">+ return (*retval) ? NS_OK : NS_ERROR_FAILURE</span> | <span class="highlightblue">+ return (*retval) ? NS_OK : NS_ERROR_FAILURE</span> | ||
There's no need to check for a failure code and a null value: | |||
nsCOMPtr<nsIMsgIncomingServer> server = do_QueryInterface(aNntpServer, &rv); | |||
<span class="highlightred">- if (NS_FAILED(rv)) return rv; | |||
- if (!server) return NS_ERROR_FAILURE;</span> | |||
<span class="highlightblue">+ NS_ENSURE_SUCCESS(rv, rv);</span> | |||
== nsISupportsArray == | == nsISupportsArray == | ||