DXR UI Refresh: Difference between revisions

Jump to navigation Jump to search
(refactor)
(→‎Please help refactor these.: Land Erik's chunk)
Line 45: Line 45:
=== Please help refactor these. ===
=== Please help refactor these. ===


==== More Trees, More Often ====
* Index multiple trees (starting with comm-central and mozilla-aurora, the most commonly used ones on MXR. The UX branch has been requested, too.) (some impact from IT, possibly) - this is the dependency for turn-off-MXR
* Index multiple trees (starting with comm-central and mozilla-aurora, the most commonly used ones on MXR. The UX branch has been requested, too.) (some impact from IT, possibly) - this is the dependency for turn-off-MXR
* Fix UI bloopers.
** Needing to put delimiters around a regex even when entered into the Advanced Search Regex field
** Astonishing search behavior. Move to a line-based search, as proposed in https://github.com/mozilla/dxr/pull/161#issuecomment-25201532.
** Optional case sensitivity
** etc., etc., etc.
* Remove the C++ assumptions from the core so we can support structured queries on other languages. Python keeps coming up. Java and Scala did once as well. People mentioned JS a long time ago.
* In the new UI, keep a text-only representation or some other way to be usable from custom search plugins or URL-bar keywords.
* permanent code links i.e. code links to a particular hg changeset, not to "tip", so that I can paste code links on a bug and they stay valid. Currently I fall back to hg.mozilla.org for that use case
* "Right now I think mxr updates from mozilla-central faster than daily. I've used that on a number of occasions to figure out what has broken my build/patch."
* "Right now I think mxr updates from mozilla-central faster than daily. I've used that on a number of occasions to figure out what has broken my build/patch."
* "One of the neat things with mxr and multiple trees is that when viewing a file on say mozilla-central I can easily switch to the mozilla-aurora version to see how it looks there, this is really useful for figuring out how a bug affects different branchs. Bonus points might include a file diff between the trees
 
==== UI bloopers ====
* Needing to put delimiters around a regex even when entered into the Advanced Search Regex field
* Astonishing search behavior. Move to a line-based search, as proposed in https://github.com/mozilla/dxr/pull/161#issuecomment-25201532.
* Optional case sensitivity
 
==== Searching ====
* A way to semantically include double quotes in the search string: the parser shouldn't always eat them.
* Docs (mostly user-facing)
* Docs (mostly user-facing)
* Remove the C++ assumptions from the core so we can support structured queries on other languages. Python keeps coming up. Java and Scala did once as well. People mentioned JS a long time ago.
==== Time ====
* DXR permanent code links i.e. code links to a particular hg changeset, not to "tip", so that I can paste code links on a bug and they stay valid. Currently I fall back to hg.mozilla.org for that use case.
* DXR permanent code links i.e. code links to a particular hg changeset, not to "tip", so that I can paste code links on a bug and they stay valid. Currently I fall back to hg.mozilla.org for that use case.
* Easy access to hg annotate, as in mxr (could be better than mxr even, by integrating into the existing view instead of being a separate view).
* Blame integrated into main file view
* A way to semantically include double quotes in the search string: the parser shouldn't always eat them.
 
==== Other ====
* "One of the neat things with mxr and multiple trees is that when viewing a file on say mozilla-central I can easily switch to the mozilla-aurora version to see how it looks there, this is really useful for figuring out how a bug affects different branches. Bonus points might include a file diff between the trees
* In the new UI, keep a text-only representation or some other way to be usable from custom search plugins or URL-bar keywords.
 
* Let us structurally query stuff that gets #ifdef'd out on x86, like ARM stuff.
* Let us structurally query stuff that gets #ifdef'd out on x86, like ARM stuff.
* Direct results: some love them, some hate them (because they just want to see the file pathname (don't we show that with the file? Is it bothersome because it's slow to load?)
* Direct results: some love them, some hate them (because they just want to see the file pathname (don't we show that with the file? Is it bothersome because it's slow to load?)
Line 98: Line 105:
* "cycleCollection" on the right side may or may not do something useful. In most cases it just ignores all the stuff, so it might be better to not have it at all.
* "cycleCollection" on the right side may or may not do something useful. In most cases it just ignores all the stuff, so it might be better to not have it at all.
* How to mark certain range of code on particular revision?
* How to mark certain range of code on particular revision?


==WIP==
==WIP==
Confirmed users
574

edits

Navigation menu