Confirmed users
9,511
edits
Web Testing/Automation/CodeReviewProcess: Difference between revisions
Jump to navigation
Jump to search
Web Testing/Automation/CodeReviewProcess (view source)
Revision as of 23:42, 7 November 2013
, 7 November 2013→During the code review
| Line 26: | Line 26: | ||
* Read and respond to all comments made by reviewers. | * Read and respond to all comments made by reviewers. | ||
* When making changes to your code in response to comments, create a new commit for the changes and push it individually to Github. Do not squash commits at this point as it makes it much harder for your reviewers to see what you have done to address their comments. | * When making changes to your code in response to comments, create a new commit for the changes and push it individually to Github. Do not squash commits at this point as it makes it much harder for your reviewers to see what you have done to address their comments. | ||
* After pushing a new commit add a comment to the pull request as | * After pushing a new commit add a comment to the pull request as GitHub will not automatically inform anyone of the fact that you have pushed a new commit. | ||
===At then end of the code review=== | ===At then end of the code review=== | ||