|
|
| Line 16: |
Line 16: |
|
| |
|
| Where possible try to review apps in queue order, prioritizing the apps at the top of the queue. Sometimes apps at the top of the queue are waiting for more information from the developer or are blocked on some other issue, so if you see a note in the app history and you don't know how to resolve the blocker, just skip to the next app. | | Where possible try to review apps in queue order, prioritizing the apps at the top of the queue. Sometimes apps at the top of the queue are waiting for more information from the developer or are blocked on some other issue, so if you see a note in the app history and you don't know how to resolve the blocker, just skip to the next app. |
|
| |
| == Testing Procedure - Hosted webapps ==
| |
| Generally we go as many steps as possible to test the App, rather stopping at the first issue and rejecting. I.e. in the steps below 'reject' doesn't mean reject immediately, just that the reason should be noted down and it shouldn't be approved after you've exhausted the steps below.
| |
|
| |
| Apps that are multi-platform (more than one of Desktop, Android, FirefoxOS) should be tested on all supported platforms. (The slight exception is if the app appears to work on Desktop and Android Mobile its not always necessary to test on an Android Tablet).
| |
|
| |
| See the [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria Marketplace Review Criteria] for details of what we allow and don't allow in Apps for listing on Marketplace. The steps below outline the brief procedure, not the policy.
| |
|
| |
| * Check the app has a '''sensible name, developer name, summary, description and icon'''. The description should be extensive enough for a user to understand what the app does (you may need to revisit this after launching the app). If not, reject.
| |
| * Have a quick look at the '''app manifest''' (the 'View' link next to the manifest url). If the manifest obviously isn't valid JSON/isn't found it won't install anyway. The [https://developer.mozilla.org/docs/Apps/Manifest manifest spec] should be consulted if you aren't sure about syntax. Any issues, reject.
| |
| * Take note of any '''requested permissions''' in the manifest. There is a [[Marketplace/Reviewers/Apps/Permissions|Security Checklist]] of available APIs and what they might be used/abused for. There are only a few APIs are available to hosted/non-privileged apps (alarms, desktop-notification, geolocation, fmradio)
| |
| * Press the install button. It will install natively so on Desktop you have to go find it in your Applications folder, start menu or desktop. On mobile platforms a shortcut will appear on your homescreen.
| |
| * Check the '''app's shortcut has an icon'''. The default rocketship icon is not allowed any more. If not, reject (there is a canned response). There is an occasional issue on Windows where sometimes the icon shown is cached from previous installs or appears broken at first so if it seems to be missing open the properties dialog and see if an icon is shown in the dialog.
| |
| * '''Launch the app'''. If the app doesn't launch as you would expect (just a random website, 404, directory listing, etc) then its likely that they need to specify a launch_path. Reject - there is a canned response.
| |
| * Give the app a '''quick try''' and see what experience a new user would have.
| |
| * Some apps require a login. If its straightforward you should register as a new user (to see what experience an actual user would have). If the app requires paid credentials; specific details; or isn't in a language you can understand sufficiently you can request a username & password - there is a canned response - with Request Information.
| |
| * All links load within the App unless explicitly specified otherwise so we need to check the app doesn't have any links (often in a navigation bar) that take the user out of the App 'experience' and strand them in a normal website (remember there is no back or home button in an app!). If there are such links then reject and explain they need to add the target="_blank" parameter to launch the link externally (in Firefox proper)
| |
| * A common issue on FirefoxOS is 'download halted' during installation - this is most often due to a broken appcache, either because it doesn't exist. You can check the manifest at [http://manifest-validator.com/ manifest-validator.com]
| |
| * If an app is '''Paid''' then check the receipt has been checked by the app - look next to the price on the review page. If not we should recommend they do that (its not a requirement). There is a canned response.
| |
| * Its important to note that we don't make any relevance or quality judgements about how the app ''looks'' in an App Review, only that it functions correctly. The [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria review criteria] document should be consulted. You can make suggestions about how to improve the app though if you notice anything that would make it better.
| |
|
| |
| If there is anything that requires Admin/Staff attention you can request a super review. This will remove the app from the current queue and place it in the Escalation queue.
| |
|
| |
|
| == Testing Procedure - Packaged Apps == | | == Testing Procedure - Packaged Apps == |