Marketplace/Reviewers/Apps/Guide/AppsQueue: Difference between revisions

Jump to navigation Jump to search

Marketplace/Reviewers/Apps/Guide/AppsQueue (view source)

Revision as of 21:36, 25 April 2014

3,180 bytes removed ,  25 April 2014
→‎Testing Procedure - *Privileged* Packaged Apps
Line 16: Line 16:


Where possible try to review apps in queue order, prioritizing the apps at the top of the queue. Sometimes apps at the top of the queue are waiting for more information from the developer or are blocked on some other issue, so if you see a note in the app history and you don't know how to resolve the blocker, just skip to the next app.
Where possible try to review apps in queue order, prioritizing the apps at the top of the queue. Sometimes apps at the top of the queue are waiting for more information from the developer or are blocked on some other issue, so if you see a note in the app history and you don't know how to resolve the blocker, just skip to the next app.
== Testing Procedure - *Privileged* Packaged Apps ==
''These should '''only''' be reviewed by Marketplace Staff currently.''
The procedure is similar to [[#Testing_Procedure_-_Hosted_webapps|hosted apps]].  Currently packaged apps are only supported on FirefoxOS.  Packaged App installation requires [[Marketplace/Reviewers/Apps/InstallingReviewerCerts|adding additional certificates]] to the phone.
See the [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria Marketplace Review Criteria] for details of what we allow and don't allow in Apps for listing on Marketplace.  The steps below outline the brief procedure, not the policy.
* Check the app has a sensible name, summary, description and icon.  The description should be extensive enough for a user to understand what the app does (you may need to revisit this after launching the app). If not, reject.
* The manifest url (view) link only contains some details from the actual manifest, which is inside the (zip) package.  To download the package for offline inspection, etc, click the 'package_path' link - this shouldn't be routinely necessary.
* In the version table at the bottom of the view load the validation report and inspect any warnings/errors.
* Then inspect the app contents via the 'contents' link.
* The first file should be the manifest. 
* Take note of any requested permissions in the manifest.  There is a [[Marketplace/Reviewers/Apps/Permissions|Security Checklist]] of available APIs and what they might be used/abused for. 
* Read the code in all the files one by one, in particular the .js files (thankfully inline js and external files aren't allowed by the CSP), paying attention to how any permissions requested are used.
** If the code is minified or obfuscated then readable source should be requested via info request (there is canned response)
* It may be necessary to search for an inspect different parts of the files, or other files, to establish how a particular piece of code is used.  The validator is your friend as it highlights possible issues, but beware of false positives, and false negatives!
* Launch the app on the device and give the app a quick try and see what experience a new user would have. 
* Some apps require a login.  If its straightforward you should register as a new user (to see what experience an actual user would have).  If the app requires paid credentials; specific details; or isn't in a language you can understand sufficiently you can request a username & password - there is a canned response - with Request Information.
* If an app is '''Paid''' then check the receipt has been checked by the app - look next to the price on the review page.  If not we should recommend they do that (its not a requirement).  There is a canned response.
* Its important to note that we don't make any relevance or quality judgements about how the app ''looks'' in an App Review, only that it functions correctly.  The [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria review criteria] document should be consulted. You can make suggestions about how to improve the app though if you notice anything that would make it better.
Adora
Confirmed users
236

edits

Retrieved from "https://wiki.mozilla.org/Special:MobileDiff/969206"

Navigation menu