DevTools/ReviewTips: Difference between revisions
< DevTools
Jump to navigation
Jump to search
(Created page with " == General == * Ask for feedback early * Only ask for review when you believe that it's ready to land * Make sure you have tests where appropriate * Make sure the patch applies...") |
No edit summary |
||
| Line 1: | Line 1: | ||
== General == | == General == | ||
| Line 8: | Line 7: | ||
Other sources of hints and tips: | Other sources of hints and tips: | ||
* [http://www.brianbondy.com/mozilla/cheatsheet/] | * [http://www.brianbondy.com/mozilla/cheatsheet/ Brian Bondy's Cheatsheet] | ||
* [https://wiki.mozilla.org/Firefox/Get_Involved] | * [https://wiki.mozilla.org/Firefox/Get_Involved FX-Team's 'Get Involved' Page] | ||
== Headers == | == Headers == | ||
| Line 21: | Line 20: | ||
== CSS == | == CSS == | ||
* See [ | * See [CSSTips] | ||
Reviewers: | Reviewers: | ||
| Line 29: | Line 28: | ||
See: | See: | ||
* [https://developer.mozilla.org/en/JavaScript_style_guide] | * [https://developer.mozilla.org/en/JavaScript_style_guide JavaScript Style Guide] | ||
* [https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide] | * [https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide Mozilla Coding Style Guide] | ||
Reviewers: | Reviewers: | ||
Revision as of 16:49, 2 November 2011
General
- Ask for feedback early
- Only ask for review when you believe that it's ready to land
- Make sure you have tests where appropriate
- Make sure the patch applies cleanly to fx-team
Other sources of hints and tips:
Headers
- Make sure each file starts with the standard copyright header (see License Boilerplate)
- For work funded by Mozilla, the 'Initial Developer of the Original Code' should be 'The Mozilla Foundation'.
- Remember the year
- The first letter of contributors names should be under the 'n' of 'contributors'
- The original author of the code should have the string ' (original author)' after his/her email address
CSS
- See [CSSTips]
Reviewers:
- dao
JavaScript
See:
Reviewers:
- dcamp
- msucan
- robcee
Localization (l10n) / Properties
Reviewers:
- dcamp
- msucan
- robcee