Gaia/SMS/Scrum/2.1S4: Difference between revisions

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to navigation Jump to search
Line 103: Line 103:


=== Day 3: 4st September ===
=== Day 3: 4st September ===
====Steve====
* {{Bug|1060727}} - [CMAS] Duplicated notifications in system tray when dismiss the attention screen by tapping on home button
** Landed on master and create a follow up {{Bug|1062104}} for future system changes
* {{Bug|1048841}} -  [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
** Waiting for the QC's reply. If they takes the gecko patch, we might need to provide the corresponding  gaia patch to fix the profiling result
* {{Bug|983172}} -  Parsing jpeg header information for downsampling the image for thumbnail
** It's time to finish this patch anyway. Will also apply the square thumbnail visual changes as well.
**: (Oleg) I also see we have one more bug with incorrect attachment alignment
**: (Steve) Yes, I saw it too. Do you think we should separate them and fix?
**: (Oleg) I guess we should (if we need to uplift this to v2.0), I see that reporter says it happens for v2.0 too, so I can take a look what broke this and then we can decide :)
**: (Steve) Hmm ,it would be reasonable  to separate them if it's 2.0 blocker...
**: (Oleg) Btw, do you plan to uplift patch for {{Bug|983172}} to v2.1?
**: (Steve) I think we should. Memory leak is an irresistible  reason ;) Yep!
**: (Oleg) I also think so! So if we uplift it and fix for wrong alignment is one-liner or so, we can bundle it with your patch for v2.1. So I'll figure out what the reason for this alignment issue
Bunch of review
* Clean up more review.
Today:
* {{Bug|983172}} for the first
====Oleg====
* {{Bug|1048717}} - [Messages][Refresh] Display call button at the header of single recipient thread
** Prepared patch and sent it for review (in review);
** Left some concern about non-valid numbers on Github.
* {{Bug|1061682}} - [Messages] Header shows wrong icons for back\close actions
** Verified that bug is fixed, asked Yan to ask for approval to uplift it in v2.1 :)
* {{Bug|1061710}} - [Flame][SMS] Unable to send sms
** I believe Steve is right that the following bug is the reason for this bug and for the one that Loli noticed, so tracking "{{Bug|1061510}} - [B2G] JavaScript Error: "ReadOnlyError: A mutation operation was attempted in a READ_ONLY transaction.".
**: (Steve) Ya, there are bunch of bugs related to this issue(Anything related to settings DB is broken :p)
**: (Oleg) Yep, this can break everything :)
* {{Bug|1059233}} - [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view
** I see "storage is null" in the gallery when the issue happens, after that I can't even open gallery - "no memory card" error is displayed, attached logcat and redirected to Gaia::Gallery to reconfirm.
**: (Steve) So it's only reproducible while no memory card inserted?
**: (Oleg) Mm, I don't have memory card to check, but it always worked before and works after reboot...
**: (Steve) Ya, I think so, but I can check for the memory card inserted scenario
**: (Oleg) That would be nice, thanks!
Other:
* Cleaned up review queue! :)
Today:
* Will handle review comments for the patches that currently in review;
* Will deal with review\feedback requests;
====Julien====
* Absent/no report


=== Day 4: 5th September ===
=== Day 4: 5th September ===

Revision as of 11:57, 4 September 2014

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1061491)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
983172 Steve Chung [:steveck] Parsing jpeg header information for downsampling the image for thumbnail --- No cf_feature-b2g [sms-most-wanted][p=2] FIXED
1048717 Oleg Zasypkin [:azasypkin] [Messages][Refresh] Display call button at the header of single recipient thread --- No cf_feature-b2g [p=1] FIXED
1053952 Oleg Zasypkin [:azasypkin] [Messages][Refactoring] Delete all messages at once when deleting threads --- No cf_feature-b2g [p=1] FIXED
1059233 Steve Chung [:steveck] [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view --- No cf_feature-b2g [LibGLA,TD91659,QE1, B][p=1] DUPLICATE

4 Total; 4 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Remaining points and burndown chart

google chart api url for Sprint 2.1S4

Burndown chart
Remaining points
Start
Day 2
Day 3
Day 4
Day 5
Day 6
Day 7
Day 8
Day 9
Day 10
End


SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-2.1S4")

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1053964 Oleg Zasypkin [:azasypkin] [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode --- No cf_feature-b2g [sms-most-wanted][sms-sprint-2.1S4] FIXED
1063970 Oleg Zasypkin [:azasypkin] [Messages][Refresh] Update styles of phone and url links located inside messages --- No cf_feature-b2g [sms-sprint-2.1S4] FIXED

2 Total; 2 Open (100%); 0 Resolved (0%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Resolution
960800 Luke Chang [:lchang] (inactive) [B2G][SMS][RTSP] RTSP link doesn't appear as hyperlink when SMS is received 2.0M+ --- FIXED
981052 Jorge Prudencio [:jorgep] [Messages] We should ask for confirmation when the user tries to delete an outgoing message --- --- FIXED
983172 Steve Chung [:steveck] Parsing jpeg header information for downsampling the image for thumbnail --- --- FIXED
995035 Eitan Isaacson [:eeejay] Invisible UI elements are visible to screen reader 2.1+ --- FIXED
1023259 Goutam(:goutamnair) [Flame][v1.4][Gaia::SMS] The contact number is shown incompletely in the contact detail screen of SMS conversion when the contact phone label is more than 19 characters. --- --- FIXED
1038176 Julien Wajsberg [:julienw] [Meta] SMS app launch latency regressed in v2.0 2.0+ --- FIXED
1048717 Oleg Zasypkin [:azasypkin] [Messages][Refresh] Display call button at the header of single recipient thread --- 2.2+ FIXED
1053952 Oleg Zasypkin [:azasypkin] [Messages][Refactoring] Delete all messages at once when deleting threads --- --- FIXED
1055355 Eitan Isaacson [:eeejay] [SMS] Make recipients field and suggestions accessible --- --- FIXED
1059053 Paco Rampas [:paco] [Messages][SMS] Icon in Message report is truncated 2.1+ --- FIXED
1059233 Steve Chung [:steveck] [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view --- --- DUPLICATE
1060727 Steve Chung [:steveck] [CMAS] Duplicated notifications in system tray when dismiss the attention screen by tapping on home button 2.1+ --- FIXED
1061491 [meta] SMS subteam sprint 2.1S4 --- --- FIXED
1061682 Yan Or [Messages] Header shows wrong icons for back\close actions --- --- FIXED
1063041 (no longer active) Inline the activity options used in the SMS app in order to make it easier to automatically extract the activity arguments from the source code --- --- FIXED
1063256 Théo Chevalier Need new strings for "{{n]} selected", due to new UX --- --- FIXED
1063970 Oleg Zasypkin [:azasypkin] [Messages][Refresh] Update styles of phone and url links located inside messages --- --- FIXED

17 Total; 17 Open (100%); 0 Resolved (0%); 0 Verified (0%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 3rd September

Oleg

  • bug 1061150 - [Messages][Refresh] Change outgoing message background to #fff
    • Prepared patch for background and bubble box-shadow, got r+, landed (landed).
  • bug 1048717 - [Messages][Refresh] Display call button at the header of single recipient thread
    • Started to work on this (in progress);
    • Noticed that if we have invalid number (like sender equals to string, in my case operator sends messages with sender === 'FehlerInfo'), we can't easily validate number, so we display call option, but if user tap on it - nothing will happen as telephony activity is just rejected. Talked to Rik about it, probably solution for that will be "bug 1032273 - [v2.1] Bug: Tapping "Call" launches Phone but does not dial" where we call directly from SMS + probably some shared with Dialer\Emergence Call error handling and number validation code.
  • bug 1061215 - [Messages][Refactoring] Improve handling of remaining chars counter
    • Follow-up for subject handling patch, have a WIP (in progress).
  • bug 1061682 - [Messages] Header shows wrong icons for back\close actions
    • Noticed that regression caused by the latest gaia-header patch (checkin-needed, v2.1?)
  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • Landed (landed).
  • bug 1061710 - [Flame][SMS] Unable to send sms
    • Was investigating, it's hard to reproduce but still possible. There is the same problem I saw some time ago with CMAS - settings.createLock.get doesn't return, it just hangs somewhere, for that reason MultiSimAction button doesn't work - neither executes send nor shows correct sim number.
    • I believe there are other apps affected by this, will look for similar bugs, otherwise will try to find good STR.
    • Just noticed Steve's reference to might have caused this "bug 1061510 - [B2G] JavaScript Error: "ReadOnlyError: A mutation operation was attempted in a READ_ONLY transaction.".

Other:

  • Reviewed CMAS duplicated notification bug, r+'d
  • Added Demos to wiki page.

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Day 3: 4st September

Steve

  • bug 1060727 - [CMAS] Duplicated notifications in system tray when dismiss the attention screen by tapping on home button
    • Landed on master and create a follow up bug 1062104 for future system changes
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Waiting for the QC's reply. If they takes the gecko patch, we might need to provide the corresponding gaia patch to fix the profiling result
  • bug 983172 - Parsing jpeg header information for downsampling the image for thumbnail
    • It's time to finish this patch anyway. Will also apply the square thumbnail visual changes as well.
      (Oleg) I also see we have one more bug with incorrect attachment alignment
      (Steve) Yes, I saw it too. Do you think we should separate them and fix?
      (Oleg) I guess we should (if we need to uplift this to v2.0), I see that reporter says it happens for v2.0 too, so I can take a look what broke this and then we can decide :)
      (Steve) Hmm ,it would be reasonable to separate them if it's 2.0 blocker...
      (Oleg) Btw, do you plan to uplift patch for bug 983172 to v2.1?
      (Steve) I think we should. Memory leak is an irresistible reason ;) Yep!
      (Oleg) I also think so! So if we uplift it and fix for wrong alignment is one-liner or so, we can bundle it with your patch for v2.1. So I'll figure out what the reason for this alignment issue

Bunch of review

  • Clean up more review.

Today:

Oleg

  • bug 1048717 - [Messages][Refresh] Display call button at the header of single recipient thread
    • Prepared patch and sent it for review (in review);
    • Left some concern about non-valid numbers on Github.
  • bug 1061682 - [Messages] Header shows wrong icons for back\close actions
    • Verified that bug is fixed, asked Yan to ask for approval to uplift it in v2.1 :)
  • bug 1061710 - [Flame][SMS] Unable to send sms
    • I believe Steve is right that the following bug is the reason for this bug and for the one that Loli noticed, so tracking "bug 1061510 - [B2G] JavaScript Error: "ReadOnlyError: A mutation operation was attempted in a READ_ONLY transaction.".
      (Steve) Ya, there are bunch of bugs related to this issue(Anything related to settings DB is broken :p)
      (Oleg) Yep, this can break everything :)
  • bug 1059233 - [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view
    • I see "storage is null" in the gallery when the issue happens, after that I can't even open gallery - "no memory card" error is displayed, attached logcat and redirected to Gaia::Gallery to reconfirm.
      (Steve) So it's only reproducible while no memory card inserted?
      (Oleg) Mm, I don't have memory card to check, but it always worked before and works after reboot...
      (Steve) Ya, I think so, but I can check for the memory card inserted scenario
      (Oleg) That would be nice, thanks!

Other:

  • Cleaned up review queue! :)

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Julien

  • Absent/no report

Day 4: 5th September

Day 5: 8th September

Day 6: 9th September

Day 7: 10th September

Day 8: 11th September

Day 9: 12th September

Day 10: 15th September

Demos

Retrospective