Gaia/SMS/Scrum/FxOS-S3

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1179700)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
1162030	Julien Wajsberg [:julienw]	[Messages][NG] Figure out how navigation works	---	No cf_feature-b2g	[p(FxOS-S4)=2][p(FxOS-S3=3][p(2.2S13)=2][sms-sprint-2.2S14]	FIXED
1169573	Steve Chung [:steveck]	[Messages][NG] Lay out Messaging service structure	---	No cf_feature-b2g	[p(FxOS-S3)=2][p(2.2S14)=1]	FIXED
1169576	Oleg Zasypkin [:azasypkin]	[Messages][NG] Implement Conversation service: method for streaming joined threads and drafts list	---	No cf_feature-b2g	[p(FxOS-S5)=3][p(FxOS-S4)=3][p(FxOS-S3)=3]	FIXED
1175503	Oleg Zasypkin [:azasypkin]	[Messages][NG] Get rid of direct ConversationView dependencies from Compose component	---	No cf_feature-b2g	[p=1]	FIXED
1179628		[Messages][NG] Lay out Settings service structure	---	No cf_feature-b2g	[p=1]	WONTFIX
1179705	Oleg Zasypkin [:azasypkin]	[Messages][NGA] Upgrade to latest version of threads.js	---	No cf_feature-b2g	[p=2]	FIXED

6 Total; 6 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Remaining points and burndown chart

google chart api url for Sprint FxOS-S3

Burndown chart

	Remaining points
Start	12
Day 2	12
Day 3	12
Day 4	12
Day 5	10
Day 6	10
Day 7	9
Day 8	9
Day 9
Day 10
Day 11
Day 12
Day 13
End

SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-FxOS-S3")

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Resolution
958105	Steve Chung [:steveck]	[Messages][Drafts] Creating a draft should not change the thread's timestamp	---	No cf_feature-b2g	[sms-most-wanted][sms-sprint-FxOS-S3]	FIXED
1176976	Oleg Zasypkin [:azasypkin]	[Messages][Drafts] Remove the draft saving/replacing action menu	---	No cf_feature-b2g	[sms-sprint-FxOS-S8 p=1][sms-sprint-FxOS-S3][sms-sprint-FxOS-S4]	FIXED
1180593	Steve Chung [:steveck]	[Messages][NG] Reorganize settings methods for settings service and views separately	---	No cf_feature-b2g	[sms-sprint-FxOS-S3]	FIXED
1181136	Julien Wajsberg [:julienw]	[Messages] When sending a MMS in airplane mode, the display stays in "sending" state after the error	---	No cf_feature-b2g	[sms-papercuts][sms-sprint-FxOS-S3]	FIXED

4 Total; 4 Open (100%); 0 Resolved (0%); 0 Verified (0%);

All SMS issues tracked for this sprint (target milestone)

Bugzilla link

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Resolution
1082052	Julien Wajsberg [:julienw]	[Messages][Refactoring] Return a Promise from SMIL.parse	---	---	FIXED
1153883	anubhav.worklinux	[Messages] Use sinon to fix mozContacts.find results directly in tests	---	---	FIXED
1165765	Julien Wajsberg [:julienw]	Intermittent Gij Automation Error: mozprocess timed out after 330 seconds running ['make', 'test-integration', 'REPORTER=mocha-tbpl-reporter', 'TEST_MANIFEST=./shared/test/integration/tbpl-manifest.json', 'NODE_MODULE_SRC=npm-cache', 'VIRTUALENV_EXISTS=1'	---	---	FIXED
1179700		SMS sprint FxOS-S3	---	---	INCOMPLETE
1180593	Steve Chung [:steveck]	[Messages][NG] Reorganize settings methods for settings service and views separately	---	---	FIXED

5 Total; 5 Open (100%); 0 Resolved (0%); 0 Verified (0%);

Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: July 3rd

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Get some feedbacks, will reply or ask more question and update for review.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Trying to summarize our thought about the Settings service (or object)
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • Create a small patch for some early feedback. Basically want to figure out how we deal with the active thread and current thread ID once we have the conversation service.
• Gave some comments about the new message extraction.

Today:

• Update messaging service prototype.
• Reply some more thought about settings part.
• Update the patch about reducing the use of Threads in conversation view.

Julien

• gave feedback to Steve's patches, this is looking good !
• moved forward the navigation (bug 1162030): now this is mostly working in non-split mode, today I'll work on split mode and ask feedback !

Today: I want to:

• do asked reviews
• move forward navigation

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

It was day of reviews :)

• bug 1179088 - Stop defining non-configurable properties on windows in Gaia, again
  • Reviewed, r+'ed (landed).
• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • Received feedback, replied to questions and filed smaller bugs to proceed with the split (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Didn't have much time for this yesterday, working on unit tests (in progress).
• bug 1153888 - [Messages] Contacts.findBy and other Contacts.* functions should never return "null".
  • Reviewed, r+'ed (landed).
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Left feedback, mostly nits, otherwise looks good.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Spent some time to see what we have in Settings and MobileOperator to better understand issue we have, replied at Bugzilla.
• bug 1178712 - [Message]When we launch Message from a contact details view for the second time, device does not enter the compose view, but enters a view where there is only a title "message".
  • Didn't have time to investigate further, it's out of sprint, so maybe take a look when have some free time (in background).

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 3: July 6th

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Polish the patch with unit test for another review.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Add more thoughts on the bugzilla. In short, maybe we can split settings into simUtilsService for service part and rest of settings for view.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • Add some questions based on the feedbacks.
• Gave some thought for the mozMobileMessage API v2 .

Today:

• Update messaging service prototype.
• Reply some more thought about settings part.
• Update the patch about reducing the use of Threads in conversation view.

Julien

• mostly worked on the navigation patch (bug 1162030); this is working now, I'm adding few comments and I'll ask feedback this morning.
• read about Bevis' proposal for new MobileMessaging API and gave some feedbacks.

Today: I want to:

• ask feedback on navigation patch
• think about the system messages issue
• do asked reviews
• pick another sprint bug

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Updated related unit tests, testing will be ready for review soon (in progress, almost ready for review).
• bug 1178712 - [Message]When we launch Message from a contact details view for the second time, device does not enter the compose view, but enters a view where there is only a title "message".
  • No updates (in background).

Other:

• Roughly went through Bevis's proposal, left some preliminary feedback - will ready carefully today.

Today:

• Will pick up next sprint bug;
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 4: July 7th

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Polish the patch with unit test for another review, and not sure how we could start the test.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • We decided to split the 2 methods into views and create settings service, mozSettings shim and mozMobileConnections shim separately.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • Work on the bug 958105 for draft timestamp issue first.
• bug 958105 - [Messages][Drafts] Creating a draft should not change the thread's timestamp
  • Will give a patch to ignore the timestamp change while updateThread for draft case.

Today:

• Update messaging service prototype.
• Feedback for navigation work.
• Patch for draft timestamp fix.
• Reply some more thought about settings part.
• Update the patch about reducing the use of Threads in conversation view.

Julien

• mostly worked on the navigation patch (bug 1162030); added more comments, did some final changes, add comments on github, asked feedback.
• reviewed a contributor patch for bug 1153883 (rewrite some unit tests using sinon)
• gave more feedback to Bevis' proposal for new MobileMessaging API

Today: I want to:

• do reviews for sprint bugs
• think about the system messages issue
• pick another sprint bug

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Prepared for review (in review).
• bug 1179705 - [Messages][NGA] Upgrade to latest version of threads.js
  • Started migration, activity shim is successfully migrated since threads has built-in Window endpoint as I wished (without fast-path though, but onmessage/postMessage is fine) :)

    (Julien) and if we need a fastpath we can implement our own fastpath endpoint, I think

    (Oleg) True :) Just wanted to note that it's good that we can migrate to new lib with minimal effort and if we want even faster solution we can implement our own endpoint as you say.

  • Streams are extracted to a separate plugin file and since there can be more plugins I'd suggest to change our lib structure. How about "lib/bridge/bridge(or core?).js" and "lib/bridge/plugins/(stream or smth new if introduced)/...js"?

    (Steve) Maybe simply move the plugins into specific folder and still leave main script in "lib/bridge/"?

    (Oleg) What folder do you have in mind?

    (Steve) "lib/bridge/plugins/" like you said?

    (Oleg) Sorry didn't get :) "still leave main script in "lib/bridge/"?" ---> Not sure what you meant here, either leave script where it's now or ...? Maybe we can talk on IRC if it's better :)

• bug 1172902 - [Messages][NG] Use SimpleOfflineCache to cache all app resources
  • Looks like all _current_, dependencies are resolved now, will see if everything works now (in background).

Other:

• Reading Bevis's proposal, one thing that bothers me is that outgoing messages are "transactions" and incoming messages are "some other thing", honestly don't really like that. Trying to wrap up my mind on how it can be generalized if possible at all.....

  (Julien) Aren't incoming messages also transactions?

  (Oleg) "(BVS 7/7) The difference is that for incoming message, it's not a transaction but a message temporarily stored in Gecko. The scenario is" - I'm referring to this explanation... I was imagine that we'll have single method to retrieve all "pending" transactions (including not flushed incoming messages, not downloaded MMS's), but I see it's not the case now.

  (Julien) Yep I agree with you, we need to clarify this

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 5: July 8th

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Working on the unit test with nullify the worker related API for testing. BTW I found that we could not freeze the service after mixin because the service and client is not set before init();

    (Oleg) yep, I fixed this, should land soon. We'll be able to only "seal" though. (bug 1179705)

• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Create bugs for shim and method splitting.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • Rebase the patch after 958105 landed.
• bug 958105 - [Messages][Drafts] Creating a draft should not change the thread's timestamp
  • Landed, clean up the timestamp changes in inbox and conversation view.
• Just a glance for navigation work patch, will review again today.

Today:

• Update messaging service prototype.
• Feedback for navigation work.
• Update the patch about reducing the use of Threads in conversation view.

Julien

Note: today we have Mozilla's leadership in the office, with a meeting this afternoon -- not sure I'll be able to move things forward this afternoon.

• mostly did reviews:
  • bug 1175503: get rid of dependencies between ConversationView and Compose
  • bug 958105: stop changing the thread's timestamp when it has a draft (makes other NGA code easier)
  • bug 1179705: upgrade to newer version of threads.js
• gave feedback on bug 1180149: the edge gestures behavior was stealing focus and as a result we couldn't send a message at the first click. Was happening especially on Sony Z3C, not much on Flame.

  (Oleg) \0/ I guess the only thing that is left is some space above and at the left side of the send button we discussed some time ago, but it's not that common to tap there :)

  (Julien) yeah, I tried manually and I think only the space above could make issues (when we have a multiline message and because there is no visual separation for the button, I think it's possible that the user clicks above). Just before the meeting I wanted to see (once again) what mouse/touch handlers we have on the space above, because that's what the event fluffing is looking at.

  (Steve) IIRC etienne fixed related issue before? Didn't look into the patch yet.

  (Oleg) " IIRC etienne fixed related issue before?" - yeah, I think it's the same one :) "what mouse/touch handlers we have on the space above" - aren't that click handlers on button and attach containers to support "activate" event?

  (Julien) Etienne told me it was a silly mistake in his logic :) he was doing the logic to not steal the focus but there was a wrong ordering of the code. About "activate": yes llikely, I want to dig deeper, but this is less important now.

• worked on bug 1181136 during transport: race condition for quick errors when sending MMS messages
• started thinking and coding for bug 1169576 (implementation of getThreads in service)

Today: I want to:

• handle comments for the navigation patch
• move forward bug 1169576
• do reviews for sprint bugs
• think about the system messages issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Received review, fixed comments, will remove CSS email recipient fix and ask for review (in progress).
• bug 1179705 - [Messages][NGA] Upgrade to latest version of threads.js
  • Finished patch and got r+, fixed nit and waiting for green Treeherder to land (almost landed).
• bug 1172902 - [Messages][NG] Use SimpleOfflineCache to cache all app resources
  • No updates since yesterday (in background).

Other:

• Few more questions on Bevis's proposal;
• Looking into Julien's patch for "bug 1162030 - [Messages][NG] Figure out how navigation works"
  • Sorry for the delay! It's quite big new piece of code - so trying to understand and left for today to have fresh mind, looking at the moment :)

    (Julien) no problem, it's both big, new, and important :) That's why I tried to leave comments as much as possible too.

    (Oleg) Comments are good :)

Today:

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 6: July 9th

Steve

• PTO for some urgent matters, will be online with very limited bandwidth.
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Still on unit test, will try to finish it today.

    (Julien) you can tell if you want that I take over :)

    (Steve) Oh, it's fine, just need to rewrite part of the tests imported from message_manager_test

    (Julien) OK !

• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Will do bug 1180593 first
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • Restart the patch after draft issue resolved
• Review the navigation patch and an issue that failed to update the correct status.

Today:

• Update messaging service prototype.
• Feedback for navigation work.
• Update the patch about reducing the use of Threads in conversation view.

Julien

Note: major part of the day was spent with Mozilla's leadership that was in the office...

• did a first implementation for bug 1169576 (implementation of getThreads in service), but I need mozMobileMessage layout before moving forward.
• did a simple patch for bug 1181763 that impacts our send button (event fluffing bug) and asked review

Today: I want to:

• handle comments for the navigation patch
• do reviews for sprint bugs
• think about the system messages issue
• move forward bug 1169576

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Prepared for the next round of review (in review).
  • Filed "bug 1181490 - [Messages][Recipients] Email recipient is misaligned in "edit" mode".
• bug 1179705 - [Messages][NGA] Upgrade to latest version of threads.js
  • Landed (landed).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • Added spec provided by Jenny, want to provide patch for the short term solution i.e. remove dialogs :) One more step forward NewMessage split (in progress).

Other:

• Few more questions on Bevis's proposal;
• Finished looking into "bug 1162030 - [Messages][NG] Figure out how navigation works" and left some feedback, mostly nits and questions.

Today:

• Looks like there is no any unassigned/actionable sprint bug for now, will pick up "bug 1176976";

  (Julien) the more I think of this, the more I think that if we don't have the dialogs anymore, maybe we don't need to run beforeLeave before changing the URL in the navigation patch. But maybe we can refine all this later too.

  (Oleg) Yeah, let's how it looks like when I remove them to make patch less risky :)

• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 7: July 10th

Steve

• Not in office due to Typhoon, but will still online with some update as much as I can.

  (Julien) stay safe !

  (Oleg) You should like working from home as much as I do :D

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Patch update for review with test added, I also change the way of returning error because I feel the error from shim should be treat as error as well. The original way of the error return will be in service promise resolve and it seems wrong semantically.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Will do bug 1180593 first
• bug 1180593 - [Messages][NG] Reorganize settings methods for settings service and views separately
  • Start to split the getSimNameByIccId/getOperatorByIccId to view.
• bug 1167144 - [Messages] Reduce the use of Threads.active and Threads currentId in conversation view.
  • will move to background
• Review the navigation patch and an issue that failed to update the correct status.

Today:

• Update messaging service prototype.
• Feedback for navigation work.
• Settings method clean up.
• Update the patch about reducing the use of Threads in conversation view.

Julien

• especially worked on navigation (bug 1162030): fixed easy comments, and reworked how setReady is used.
• did a last review for bug 1175503 (dependencies between Compose and ConversationView)
• did a last review for bug 1153883 (use of sinon in our contacts test)

Today: I want to:

• handle comments for the navigation patch
• do reviews for sprint bugs
• think about the system messages issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1175503 - [Messages][NG] Get rid of direct ConversationView dependencies from Compose component
  • Got r+, landed (landed).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • Tried to generalize related code as much as possible, have several questions, so prepared WIP patch and asked for feedback (awaiting feedback).

Other:

• Finished looking into and left some feedback, mostly nits and questions.

Today:

• Look into Julien's replies/clarifications in "bug 1162030 - [Messages][NG] Figure out how navigation works".
• Will pick up next bug if I have free cycles;
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 8: July 13th

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Reply some feedback and try to give a test about the returning promise from service method.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Will do bug 1180593 first
• bug 1180593 - [Messages][NG] Reorganize settings methods for settings service and views separately
  • Ongoing; splitting the getSimNameByIccId/getOperatorByIccId to view.
• Review the navigation patch.

Today:

• Update messaging service prototype.
• Feedback for navigation work.
• Settings method clean up.

Julien

Note: tomorrow is french holiday.

• especially worked on navigation (bug 1162030):
  • fixed activities: now I save a draft and recall it from inside the composer.
• gave a first feedback on bug 1176976 (remove draft dialogs)
• gave a first feedback on bug 1169573 (MessagingService layout)

Today: I want to:

• move forward the navigation patch -- I really hope to be ready for a first review, but maybe that will be too much work.
• think about the system messages issue

If all this moves forward well, I could:

• continue the prototype caching the thread list to a single db (including contacts/drafts/etc).
• I'd like to work on the deduplication logic for network alerts, it seems important for users (bug 1067938)

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • Received feedback, trying to cover drafts functionality with more tests (needed some refactoring in test infrastructure to support new view-acessors paradigm), will fix comments and ask for review (in progress).
• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Reviewed, left some comments at GitHub.

Today:

• Will pick up next bug if I have free cycles;
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Day 9: July 14th

Steve

• bug 1169573 - [Messages][NG] Lay out Messaging service structure
  • Update the patch for another review. will give a test about the returning promise from service method.
• bug 1179628 - [Messages][NG] Lay out Settings service structure
  • Will do bug 1180593 first
• bug 1180593 - [Messages][NG] Reorganize settings methods for settings service and views separately
  • Ongoing; splitting the getSimNameByIccId/getOperatorByIccId to view.
• Give some thought for navigation patch.

Today:

• Update messaging service prototype.
• Settings method clean up.

Oleg

• bug 1155534 - [Messages][NG] Extract NewMessage view from Conversation view
  • No updates (in background).
• bug 1176976 - [Messages][Drafts] Remove the draft saving/replacing action menu
  • Fixed comments, finishing integration tests, still thinking about "draft saved banner" issue with separated views (in progress).

Today:

• Will pick up next SW bug if I have free cycles;
• Will handle review/feedback/need-info requests;
• Will work on review comments and assigned bugs.

Julien

• Holiday in France