Confirmed users
837
edits
DevTools/Code Review Checklist: Difference between revisions
DevTools/Code Review Checklist (view source)
Revision as of 11:35, 20 October 2016
, 20 October 2016A note about Mozilla license header
m (Pbrosset moved page DevTools Code Review Checklist to DevTools/Code Review Checklist: Moving to under the DevTools context) |
(A note about Mozilla license header) |
||
| Line 7: | Line 7: | ||
* Commit message says what is being changed and why as described here : http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/commits.html#write-detailed-commit-messages | * Commit message says what is being changed and why as described here : http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/commits.html#write-detailed-commit-messages | ||
* Patch applies locally to current sources with no merge required | * Patch applies locally to current sources with no merge required | ||
* Check that every new file introduced by the patch has proper Mozilla license header : https://www.mozilla.org/en-US/MPL/headers/ | |||
= Manual testing = | = Manual testing = | ||