Security/Tracking protection/Bug triage: Difference between revisions
Jump to navigation
Jump to search
(Move the Tech Evangelism: Desktop part to the second section and mention removing the tp-needsrepro tag.) |
(Move non-critical tasks to the second section.) |
||
| Line 4: | Line 4: | ||
#* Platform bugs should be moved into '''Toolkit::Safe Browsing''' | #* Platform bugs should be moved into '''Toolkit::Safe Browsing''' | ||
#* Server-side bugs should be moved into '''Cloud Services::Server: Shavar''' | #* Server-side bugs should be moved into '''Cloud Services::Server: Shavar''' | ||
# Breakage bugs should block one of these meta bugs: | # Breakage bugs should block one of these meta bugs: | ||
#* <tt>tppaywall</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock]) | #* <tt>tppaywall</tt> if TP is triggering a paywall / adblocker detection script (e.g. [https://github.com/sitexw/FuckAdBlock FuckAdBlock]) | ||
| Line 12: | Line 11: | ||
#* <tt>trackingprotection</tt> otherwise | #* <tt>trackingprotection</tt> otherwise | ||
# Close paywall-related bugs as <tt>WONTFIX</tt>. | # Close paywall-related bugs as <tt>WONTFIX</tt>. | ||
# Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization. | # Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization. | ||
# Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug (see next section). | # Add the '''tp-needsrepro''' whiteboard tag if the problematic resource is not mentioned in the bug (see next section). | ||
| Line 27: | Line 25: | ||
Someone looking at the [https://bugzilla.mozilla.org/buglist.cgi?list_id=13780003&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=tp-needsrepro&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Tracking%20Protection&product=Firefox <tt>tp-needsrepro</tt> bugs] should: | Someone looking at the [https://bugzilla.mozilla.org/buglist.cgi?list_id=13780003&status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=tp-needsrepro&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=Tracking%20Protection&product=Firefox <tt>tp-needsrepro</tt> bugs] should: | ||
# Ensure the URL of the broken page is in the URL field | |||
# Close any unreproducible bugs with <tt>WORKSFORME</tt>. | # Close any unreproducible bugs with <tt>WORKSFORME</tt>. | ||
# Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as <tt>DUPLICATE</tt> of one another. | |||
# Find the blocked resource(s) responsible for the breakage (using [https://addons.mozilla.org/firefox/addon/umatrix/ uMatrix]) and add it to the '''user story''' field. | # Find the blocked resource(s) responsible for the breakage (using [https://addons.mozilla.org/firefox/addon/umatrix/ uMatrix]) and add it to the '''user story''' field. | ||
# Tag bugs with the category that causes the breakage in the '''whiteboard''' field (use [https://github.com/mozilla-services/shavar-list-creation/blob/master/disconnect_mapping.py this mapping] for Twitter, Google and Facebook resources in the ''Disconnect'' category): | # Tag bugs with the category that causes the breakage in the '''whiteboard''' field (use [https://github.com/mozilla-services/shavar-list-creation/blob/master/disconnect_mapping.py this mapping] for Twitter, Google and Facebook resources in the ''Disconnect'' category): | ||
Revision as of 23:33, 21 June 2018
As bugs come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:
- Move misplaced bugs into the right component:
- Platform bugs should be moved into Toolkit::Safe Browsing
- Server-side bugs should be moved into Cloud Services::Server: Shavar
- Breakage bugs should block one of these meta bugs:
- tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
- tpvideo if TP is blocking the playing of videos
- tplogin if TP is breaking the login/registration flow of a site (including SSO providers)
- tpimages if TP is blocking necessary/useful images (excluding display ads)
- trackingprotection otherwise
- Close paywall-related bugs as WONTFIX.
- Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
- Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
- For feature requests and bugs that require a product decision:
- Tag with the tp-product whiteboard tag.
- NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
- Set a priority on the bug:
- tp-needsrepro: P3
- tp-product: --
- tp-entitylist: P2
Reproducing bugs
Someone looking at the tp-needsrepro bugs should:
- Ensure the URL of the broken page is in the URL field
- Close any unreproducible bugs with WORKSFORME.
- Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
- Find the blocked resource(s) responsible for the breakage (using uMatrix) and add it to the user story field.
- Tag bugs with the category that causes the breakage in the whiteboard field (use this mapping for Twitter, Google and Facebook resources in the Disconnect category):
- tp-ads for the Advertising category
- tp-analytics for the Analytics category
- tp-social for the Social category
- tp-content for the Content category (only part of the strict list)
- Remove the tp-needsrepro tag.
- Move the bug to Tech Evangelism: Desktop and reset the priority to --.