Security/Tracking protection/Bug triage: Difference between revisions

Revision as of 12:54, 27 August 2018

Once the bugs are fully triaged, there should be:

As bugs come into the Firefox::Tracking Protection component, the bug triage owner should follow these steps:

Move misplaced bugs into the right component:
- Platform bugs should be moved into Toolkit::Safe Browsing
- Server-side bugs should be moved into Cloud Services::Server: Shavar
Breakage bugs should block one of these meta bugs:
- tppaywall if TP is triggering a paywall / adblocker detection script (e.g. FuckAdBlock)
- tpvideo if TP is blocking the playing of videos
- tplogin if TP is breaking the login/registration flow of a site (including SSO providers)
- tpimages if TP is blocking necessary/useful images (excluding display ads)
- tpcomments if TP is blocking the display of comments
- trackingprotection otherwise
Close paywall-related bugs as WONTFIX (look at this comment for an example).
Add the tp-entitylist whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.
Add the tp-needsrepro whiteboard tag if the problematic resource is not mentioned in the bug (see next section).
For feature requests and bugs that require a product decision:
1. Tag with the tp-product whiteboard tag.
2. NEEDINFO :pdol with a suggested decision (typically P3 or WONTFIX).
Set a priority on the bug:
- tp-needsrepro: P3
- tp-product: --
- tp-entitylist: P2

Someone looking at the tp-needsrepro bugs should:

Ensure the URL of the broken page is in the URL field
Close any unreproducible bugs with WORKSFORME.
Mark bugs that have the same root cause (e.g. Facebook videos are blocked on site X) as DUPLICATE of one another.
Find the blocked resource(s) responsible for the breakage (using uMatrix) and add it to the user story field.
Tag bugs with the category that causes the breakage in the whiteboard field (use this mapping for Twitter, Google and Facebook resources in the Disconnect category):
- tp-ads for the Advertising category
- tp-analytics for the Analytics category
- tp-social for the Social category
- tp-content for the Content category (only part of the strict list)
Remove the tp-needsrepro tag.
Move the bug to Tech Evangelism: Desktop and reset the priority to --.

@@ Line 17: / Line 17: @@
 #* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1470298&hide_resolved=1 tplogin]</tt> if TP is breaking the login/registration flow of a site (including SSO providers)
 #* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1470301&hide_resolved=1 tpimages]</tt> if TP is blocking necessary/useful images (excluding display ads)
-#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1101005&hide_resolved=1 trackingprotection]</tt> otherwise
+#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1470301&hide_resolved=1 tpcomments]</tt> if TP is blocking the display of comments
+#* <tt>[https://bugzilla.mozilla.org/showdependencytree.cgi?id=1486425&hide_resolved=1 trackingprotection]</tt> otherwise
 # Close paywall-related bugs as <tt>WONTFIX</tt> (look at [https://bugzilla.mozilla.org/show_bug.cgi?id=1449319#c2 this comment] for an example).
 # Add the '''tp-entitylist''' whiteboard tag if the breakage could be mitigated by expanding the entity whitelist to linked domains owned by the same organization.