Gaia/SMS/Scrum/2.1S3

From MozillaWiki
< Gaia‎ | SMS‎ | Scrum
Jump to: navigation, search

List of bugs

SMS issues handled by the SMS subteam (blocks the sprint bug 1055470)

Bugzilla link

ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1035762 Oleg Zasypkin [:azasypkin][⏰UTC+1] [B2G][SMS] support 24 hour time format --- [p=1] FIXED
1041765 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] Thread view redesign --- [p=2] FIXED
1048841 Steve Chung [:steveck] [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup) --- [p(2.1S3)=1][p(2.1S2)=2][c=startup p= s= u=] WONTFIX

3 Total; 0 Open (0%); 1 Resolved (33.33%); 2 Verified (66.67%);


Remaining points and burndown chart

google chart api url for Sprint 2.1S3

Burndown chart
Remaining points
Start 9
Day 2 9
Day 3 9
Day 4 9
Day 5 8
Day 6 8
Day 7 7
Day 8 7
Day 9 4
Day 10 1
End 1


SMS issues handled by the SMS subteam outside of the sprint (contains whiteboard "sms-sprint-2.1S3")

ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Resolution
1048845 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] Compose Panel refresh (subject behavior change) --- [p=2][sms-sprint-2.1S3] FIXED
1054004 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded" 2.0+ [sms-sprint-2.1S3] FIXED
1056044 Oleg Zasypkin [:azasypkin][⏰UTC+1] Make MockL10n.readyState as "complete" by default --- [sms-sprint-2.1S3] FIXED
1057996 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Tests] ThreadUI unit tests aren't run if full --- [sms-sprint-2.1S3] FIXED
1061150 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages][Refresh] Change outgoing message background to #fff --- [sms-sprint-2.1S3] FIXED

5 Total; 0 Open (0%); 5 Resolved (100%); 0 Verified (0%);


All SMS issues tracked for this sprint (target milestone)

Bugzilla link

ID Assigned to Summary Blocking b2g Feature b2g Resolution
976678 David Garcia [:davidg][retired] [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep. --- --- FIXED
1011604 Wilson Page [:wilsonpage] [Messages] Update to use <gaia-header> --- --- FIXED
1030925 Steve Chung [:steveck] Support for Visual Refresh in Messaging --- 2.1 FIXED
1035762 Oleg Zasypkin [:azasypkin][⏰UTC+1] [B2G][SMS] support 24 hour time format --- 2.1 FIXED
1041765 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] Thread view redesign --- 2.1 FIXED
1041912 Michael Henretty [:mikehenrty][:mhenretty] [SMS] Customize Status Bar Color --- --- FIXED
1048841 Steve Chung [:steveck] [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup) --- --- WONTFIX
1054004 Oleg Zasypkin [:azasypkin][⏰UTC+1] [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded" 2.0+ --- FIXED
1054911 Wei Gao (Spreadtrum) [dolphin] When we set message outgoing to always ask, it is chaos about which sim should be used to resend failed message. 1.4+ --- FIXED
1055470 [meta] SMS subteam sprint 2.1S3 --- --- FIXED

10 Total; 0 Open (0%); 5 Resolved (50%); 5 Verified (50%);


Sprint planning

Minutes are on a separate page.

Daily meetings

Day 2: 20th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Building the emulator and trying to send the fake cellbroadcast(but not working) Still checking with gecko devs about the environment setting
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Still waiting for the gecko WIP for the batch threads return and rendering

Bunch of review

  • bug 1052424 - [Messages] Cursor should be in the "to" field by default while forwarding messages
    • A failed case is entering the view from contact, init recipient without focus on recipient again will focus on wrong place in recipient, but we need ux input first because we may need to focus on compose instead.
  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • After playing for a while, it works great overall! Will take a deep look later.

Today:

  • Clean review queue.
  • Figure out how to make the fake cellbroadcast work

Julien

  • On PTO till September 15th

Oleg

  • bug 1054004 - [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded"
    • Got feedback+ for the simplest patch, will ask for review once try is green (in review).
  • bug 1053964 - [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode
    • Got feedback+, will handle review comments and ask for review (in progress)
  • bug 976091 - [Messages][DSDS] Show the SIM information in the message bubble
    • Reviewed, r+'d (landed).
  • bug 1041765 - [Messages] Thread view redesign
    • Rebased on the latest master, put on hold until not-downloaded spec part is ready (in progress, awaiting for VD).

Other:

  • Was experimenting with caching html markup for the first 10 threads in local storage. It looks faster (http://1drv.ms/VCQWmf), but it needs much more care than Contacts app. Discussed with Julien yesterday evening, we'd rather avoid landing something like this for 2.0 and 2.1, but will probably work on that idea in background as the last resort. The main idea behind this is to cache 10-thread-markup on 'moz-app-load', and either remove it totally once something changes (the easiest and less error prone version) or be smarter and resave\rebuilt this part of markup on change (more complex option).

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with a11y review\feedback requests;
  • Will pick up next bug from list planned for the sprint (presumably 12/24 hours bug).

Day 3: 21st August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Fire a bug about the lack of cellbroad cast system message(bug 1055994), and testing with their WIP. Everything seems fine.
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Gecko WIP is workable now, it's time to apply on gaia and see the result.
      (Oleg) I cross the fingers :)
  • bug 1053359 - [CMAS] Add the application to production builds and remove it from homescreen
    • Before bug 1055994 ready, I could try to hide the application icon first.

Bunch of review

  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • Some feedback give. It works great!
      (Oleg) Thanks for review! I'll try to handle review comments so that it can be landed in 2.1

Today:

  • Clean review queue.
  • Clean up the testing code and unused styling in network-alert
  • Hide the network-alert icon

Tomorrow: Will take PTO

Julien

  • On PTO till September 15th

Oleg

  • bug 1054004 - [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded"
    • Fixed unit tests and asked for review (in review).
  • bug 1056044 - Make MockL10n.readyState as "complete" by default
    • Tiny fix to make testing the code that uses "mozL10n.readyState" easier, got r+ (waiting for green Try to land).
  • bug 1035762 - [B2G][SMS] support 24 hour time format
    • Almost ready, updating unit tests (in progress);
    • When adding "window.ontimeformatchnage" to startup.js noticed that basically everything that we do in l10n.ready callback here isn't needed for the first thread panel, so it looks like it can be lazily loaded, no big win, but anyway. I've extracted it to the separate file (as some stuff is shared between l10n.ready and window.ontimeformatchange) and will ask for review today.
      (Steve) Ya, things in l10n.ready could be lazyloaded safely and I did try it for performance improvement, but just like you side the effect is trivial :p Anyway I still think it's a good move to do this, but we might need to plan it "smarter" if someday we will need it in threadist view.
      (Oleg) yep
  • bug 1053968 - Clean up mozL10n API use in SMS
    • Reviewed, asked to fix some indentation and unit tests nits (in progress);
    • Was curious and asked :gandalf why they favour "getAttribute('data-l10n-id')" over "dataset.l10nId" as noticed that "getAttribute" is more performant (http://jsperf.com/dataset-vs-getattribute-and-setattribute/3). So here is excerpt from :gandalf's answer just for the record :)
      • use DOM's setAttribute when you have l10nId
      • use mozL10n's setAttributes when you have l10nArgs as well
      • two reasons against dataset:
        • First one is that the current attribute names will change when we will standardize mozL10n as a WebAPI to l10n-id and l10n-attrs.
        • Second is the performance. :) (:(Oleg) can't say though it really matters in our SMS case)
  • bug 1055356 - [SMS] Threads view Unread indicator and contact photo are not screen reader friendly
    • Reviewed, overall it's good, but patch broke thread "draft" indicator, asked to fix.
  • bug 1041765 - [Messages] Thread view redesign
    • (Oleg) Steve, could you please ask Fang about not-downloaded part spec? I forgot to ask on yesterdays meeting :(
      (Steve) Ok, no problem
      (Oleg) Thanks!

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with a11y review\feedback requests;

Luke

  • bug 1045493 - [Messages] It's impossible to activate recipients input field once all recipients were deleted in expanded mode
    • requested for approval
  • bug 1052424 - [Messages] Cursor should be in the "to" field by default while forwarding messages
    • have a V1 patch

Today:

  • bug 1052424 - [Messages] Cursor should be in the "to" field by default while forwarding messages
    • need to fix the behavior in the activity path

Day 4: 22nd August

Steve

  • On PTO today

Julien

  • On PTO till September 15th

Oleg

  • bug 1054004 - [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded"
    • Got r+, landed in master (landed);
    • Since master patch can't be directly applied to v2.0 due to conflicts in unit tests, prepared v2.0 patch (waiting for Try);
  • bug 1056044 - Make MockL10n.readyState as "complete" by default
    • Landed (landed).
  • bug 1035762 - [B2G][SMS] support 24 hour time format
    • Rebased on the latest master (there was mozL10n cleanup patch that affected this patch too), still working on unit tests.
  • bug 1053968 - Clean up mozL10n API use in SMS
    • Reviewed once again, looks good, r+'d (landed).
  • bug 1055356 - [SMS] Threads view Unread indicator and contact photo are not screen reader friendly
    • Reviewed once again, everything is good now except that draft icon is still missing, asked to fix (in progress).
  • bug 1041765 - [Messages] Thread view redesign
    • Fang provided the last missing part of the spec for not-downloaded MMS, so now we're ready to finish it.
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Per :wilsonpage it was really urgent, so tried to review it carefully, first version of the patch broke some stuff:
    • our close\back behaviour for Report panel in normal mode and for the rest cases in Activity mode;
    • Header and button styles in Edit mode for ThreadListUI and ThreadUI;
    • Accessibility of back/close buttons, so we can't use app navigation with screen reader - as found out it's blocked with "bug 887541 - Implement web components event retargeting."

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Day 5: 25th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Since cellbroadcast system message is landed, will create a WIP about CMAS for Oleg testing
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Current gecko solution doesn't need any gaia changes, so waiting for gecko patch in bug 1057915
      (Oleg) great that we don't need gaia changes for now!
      (Steve) yeah, but the performance seems still not as good as we expected... Will keep tracking on this.
  • bug 1053359 - [CMAS] Add the application to production builds and remove it from homescreen
    • Landed on master.

Bunch of review

  • Will review and 24h format and Gabriele's wappush patch today

Today:

  • Start to review the important item .
  • Create a WIP for network-alert

Julien

  • On PTO till September 15th

Oleg

  • bug 1054004 - [Messages] There is a possible race condition between navigator.mozL10n.ready and "DOMContentLoaded"
    • v2.0 patch is landed too as well as dependent bug (landed);
  • bug 1035762 - [B2G][SMS] support 24 hour time format
    • Prepared patch and asked for review (in review).
  • bug 1041765 - [Messages] Thread view redesign
    • Applied latest not-donwloaded spec from Fang, testing, hopefully it will be ready for review today, or tomorrow as the latest (in progress).
  • bug 1055356 - [SMS] Threads view Unread indicator and contact photo are not screen reader friendly
    • Will review today once again (in review).
  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • Fixed comments and asked for not urgent review :)
  • bug 1053964 - [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode.
    • Fixed Julien's comments and asked Steve for not urgent review. It can be helpful to have this one especially that gaia-header is coming and patch broke this behaviour several times :(
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Reviewed two times, will review today once again. I'm still concerned whether we have to wait for accessibility dependency (close/back button don't work in screen reader mode) to be landed first..
      (Oleg) Steve, what do you think?
      (Steve) Well... maybe we don't have to wait for screen reader's issue if follow up bug is already created.
      (Oleg) ok, because Wilson is really eager to land it as soon as possible :)
      (Steve) I know they are eager to land this component, so I redirect the review since I took PTO. Does the gaia header fine without the screen reader issue?
      Looks fine, styles have changed though (for edit mode too), but they want to fix\adjust it in follow up for all apps altogether. And I don't really like the latest patch, will think if I can propose some improvements (from code style PoV)
      (Steve) Great! I'll take a look as well if I have time later, thanks!
      (Oleg) Great, thanks!

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Luke

  • bug 1052424 - [Messages] Cursor should be in the "to" field by default while forwarding messages
    • got feedback from UX and will follow up

Today:

  • N/A (need to help partner support first)

Day 6: 26th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Create a WIP that able to run on simulator, will finish the rest of testing if not serious problem in overall structure.
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Some misleading performance result make the firstpanelDone time looks worse than it should be. We might need to modify the first panel count to match the aggressiveness value(it does not change the actual result anyway) We have 2 options to modify this aggressiveness in gaia settings(after 1057915 landed). One is put it in build time for customization(someone need to maintains this value per device and UX changes), one is set in run time that we compute the max list count per panel at first and write to settings DB(Write to settings DB is async action and gecko might still get the old value for aggressiveness setting).
      (Oleg) 2nd option (run-time computation) sounds more attractive to me, but I don't have much knowledge\experience in such changes yet :)
      (Steve) Ok, I will explain more in the patch.
      (Oleg) ok, thanks!

Bunch of review

  • Reviewing and 24h format patch
    • Looks great and even with additional issue addressed, thanks!
  • Gabriele's wappush patch
    • Still got some small issues in promise structure changes. Would need another round of review.

Today:

  • Start to review the important item .
  • Create a WIP for network-alert

Julien

  • On PTO till September 15th

Oleg

  • bug 1041765 - [Messages] Thread view redesign
    • Still in progress, should send it for review today (in progress).
  • bug 1055356 - [SMS] Threads view Unread indicator and contact photo are not screen reader friendly
    • Reviewed, looks fine now, r+'d (landed).
  • bug 995035 - Invisible UI elements are visible to screen reader
    • Reviewed, also looks fine to me except one thing in code. Asked Steve on GitHub to get one more experienced opinion.
      (OIeg) Steve, could you please take a look at my question for this patch on GitHub?
      (Steve) ok, will reply on github later
      (Oleg) Thanks!
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Reviewed once again, proposed some changes to reduce burden with gaia-header manipulation (close/back button in normal and activity mode).
    • Apart from that noticed only one thing that a bit bothers me, with applied patch when we navigate from Report\Participant panels to Thread panel, header title updates a bit slowly than in master, haven't found reason for that, maybe will ask Wilson what can be a reason for that.
    • While proposing changes noticed that we have broken unit tests that looks like I missed while reviewing l10n cleaning patch from :gandalf :( Filed bug below to fix this:
  • bug 1057996 - [Messages][Tests] ThreadUI unit tests aren't run if full
    • Sent to review (in review).
  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Started to look into that, set up emulator and figured out that I need to change message id in cbs pdu hex string :) Now it's fine. Looks good for now!
      (Steve) Sorry I forgot to mention that :p We need to change to message ID with CMAS specific HEX for showing the screen.
      (Oleg) Yep, it's fine, started to look into code and everything became clear :)

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Luke

  • N/A (partner support)

Today:

  • bug 1054833 - [Messages][SMS] Red Exclamation circle of Invalid contact in Recipient list is not round, bottom cut off a little bit

Day 7: 27th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Add test cases and suggestions for next round of review. Should be able for review today.
    • Create a follow up for icon issue.
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Will utilize current small patch (save fixing but not much improvement ) with refined firstViewCount number for review.
  • bug 1039955 - [Messages] circular activity issue: "Call" is not functioning when tapping the number on sms which is brought up by sending sms from call log
    • Another circular activity issue, seems we need to provide a general solution for it but no good idea currently... we could not know the callee app and leaveActivity properly. Any idea for this?
      (Oleg) mmm, will try to think about this too :) No idea for now
      (Steve) A simpler solution is we always leave activity after sending. I think it's much safer that only allow user stay in composer. Long term solution is system should avoid circular activity and force to close message case if we open the callee activity.
      (Oleg) Yeah, I guess the best option we have for now. What was the rationale initially about staying in the app after we share something?
      (Steve) Sorry I can't catch up what you said
      (Oleg) Sorry, I mean when sharing support was implemented in SMS, why after send we forward user to thread view and doesn't close activity automatically. Yeah, there are pros and cons of this. Hard to say what is the right behaviour here. Probably we had some UX requirements on that initially.
      (Steve) Just discuss with Jenny and Alive, will update on bugzilla

Bunch of review

  • Reviewing and 24h format patch
    • R+, nice job! Thanks!
  • bug 1057996 - [Messages][Tests] ThreadUI unit tests aren't run if full
    • R+, just some small nits

Today:

  • Start to review the important item .
  • Create a WIP for network-alert

Julien

  • On PTO till September 15th

Oleg

  • bug 1041765 - [Messages] Thread view redesign
    • Writing unit tests, yesterday noticed that something changed in Gecko very recently and margin-right for the float-right element doesn't work as expected on latest builds of Firefox and B2G (there is no margin-right for outgoing messages anymore :(. Will try to find out what happened, create reduced test case if needed.
      (Steve) Wow , do you have bug# for this?
      (Oleg) Haven't found yet, pinged you on IRC to double check reduced test case
  • bug 995035 - Invisible UI elements are visible to screen reader
    • Will review again today.
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Will make final review today, but it would be great to get Steve feedback on this before landing :)
  • bug 1057996 - [Messages][Tests] ThreadUI unit tests aren't run if full
    • Got r+, waiting for tree to open to land this.
  • bug 1035762 - [B2G][SMS] support 24 hour time format
    • Got r+, waiting for tree to open to land this.
  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Left feedback, looks good!

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;
  • Will look into nomination "bug 1059057 - "(+0)" mistakenly appear on the main view of Message app"

Luke

  • bug 1054833 - [Messages][SMS] Red Exclamation circle of Invalid contact in Recipient list is not round, bottom cut off a little bit
    • had workaround patch but need further investigation

Today:

  • bug 1054833 - [Messages][SMS] Red Exclamation circle of Invalid contact in Recipient list is not round, bottom cut off a little bit

Day 8: 28th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Add test cases and suggestions for next round of review. Should be able for review today.
    • Create a follow up for icon issue.
  • bug 1051795 - [CMAS] Handle the setting that enables/disables CMAS alerts
    • Start some study for how to get the correct value. We will need serviceID to fetch the right one(cmas.enalbed will store in settings DB as an object)
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • No progress yet, will find some free time for it.
  • bug 1039955 - [Messages] circular activity issue: "Call" is not functioning when tapping the number on sms which is brought up by sending sms from call log
    • After some discussion with UX, they tend to let system control the activity flow, so Alive will give a patch for that. But we will still need to save draft every time when opening another window activity.

Bunch of review

  • gaia header component
    • Find a regression that we will create a header element in JS, so we could not remove the original header css unless we fix js part as well. Maybe we should keep the header css for a while and create a follow up bug to fix js part.
      (Oleg) Mmm didn't get it sorry :)
      (Steve) It's ok, this changes are not small so it normal that we missing some part ;)
      (Oleg) is it related to removed "headers.css" or ?
      (Steve) No, in sms.css that we override the BB header styling
      (Oleg) Ah, yes I've asked Wilson to remove unrelated CSS changes as they broke some stuff :) On IRC :) Sorry, looks like he haven't updated it yet
      (Steve) Well, he actually remove some unrelated CSS, but just one of them is still in used
      (Oleg) the latest excerpt from IRC:
      (Oleg) I'm not sure about [data-type="list"] header, I guess we need this but don't need [data-type="list"] gaia-header? same here form[role="dialog"][data-type="action"].contact-prompt > header
      (wilsonpage) What you want me to change?
      (Oleg) I think that just updating rules that needed for gaia-header would the easiest and safest option.
      (Oleg) Sorry, it was too late that I forgot to duplicate it on Github :(
      (Steve) Ah, it's fine . BTW, does it runs correctly on desktop nightly as well? My layout (about the header)was broken in many place, but maybe my nightly is too old
      (Oleg) Haven't checked, but will look now and if it's so - will ping wilson
      (Steve) Thanks!
      (Oleg) Mmm, just checked - looks fine, where do you see issues? So that I can look precisely
      (Steve) tap on the header which has contact info, and it will popup a option menu. If contact has photo, it will also shows the photo on menu header(But the header height is fixed)
      (Oleg) I see, probably it's because of latest CSS changes. Will check... But the header itself, navigation, Report and Participants panels look fine, right?
      (Steve) The header applied gaia-header looks fine for now (except the delay of font size change... )
      (Oleg) I sometime see slight delay in updating header content when navigating from report\participants to thread panel
      (Steve) Me too, and I'm thinking that if it getting worse on low end device like buri or other s
      (Oleg) That concerns me too for 2.1, for 2.2 I hope we divide headers and this problem will go away, that the only reason why I didn't block on this, do you think we should block?
      (Steve) No, I think there is no need to block this.
      (Oleg) Ok, thanks, Wilson will be happy :)
      (Steve) They are also eager to land this before FL ;)
      (Oleg) Yeah, but to be honest I'd rather do it after :) No user-facing improvements only possible regressions :)
      (Steve) Well it's always the problem to decide the priority of the features
      (Oleg) yep
  • Many smaller review and question reply

Today:

  • Start to review the important item. Thread refresh is first one
  • Create a WIP for network-alert

Julien

  • On PTO till September 15th

Oleg

  • bug 1041765 - [Messages] Thread view redesign
    • Created reduced test case for the Gecko regression "bug 1059167 - Right floated element with defined width doesn't respect right margin" (already in review).
    • Asked for early feedback while we're waiting for Gecko dependency. Everything should work, I'm just worried about two things, code that determines "error/pending" status (I left few comments about my concerns at github) and increased sticky header height, it looks fine to me, but perhaps I need to confirm with UX\VD (awaiting for feedback).
  • bug 995035 - Invisible UI elements are visible to screen reader
    • Reviewed, still needs some work, in particular Report and Participants panels aren't visible to screen reader :)
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Reviewed, left minor comments and asked Steve for final feedback. Looks like Gecko accessibility dependency is resolved, but didn't have chance to check (awaiting for feedback).
  • bug 1057996 - [Messages][Tests] ThreadUI unit tests aren't run if full
    • Landed (landed).
  • bug 1035762 - [B2G][SMS] support 24 hour time format
    • Landed (landed).
  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Looking into it right now.
  • bug 1059057 - "(+0)" mistakenly appear on the main view of Message app
    • Checked that it's not regression and not gaia::sms issue, it's caused by some problems in pseudo-locale vs plurals code, :flod redirected it to gaia:l10n.
  • bug 1053952 - [Messages][Refactoring] Delete all messages at once when deleting threads
    • Rebased on latest master, asked for not urgent review.

Today:

  • Will handle review comments for the patches that currently in review (+ a11y comments on subject handling patch from Eitan);
  • Will deal with review\feedback requests; CMAS patch is in priority.

Luke

  • N/A

Today:

  • N/A (need to support partner's issues)

Day 9: 29th August

Steve

  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • Suggestio addressed and landed in master
      (Oleg) just to not forget, looks like data-l10n-id for btn ok is outdated in attention.html and some weird tab symbol in notification.html for "initial-scale" property
      (Steve) Oh, right... sorry for the missing :(
      (Oleg) It's ok, we have settings patch :) I guess we should ideally land everything today? :(
      (Steve) I think the branching day is next Tuesday, but not sure if they will close tree to blocking new commit after Friday
      (Oleg) I hope they won't
  • bug 1051795 - [CMAS] Handle the setting that enables/disables CMAS alerts
    • Patch is ok on emulator, will request review once the unit test ready(mocking settings costs me hours :-/ ).
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • No progress yet, will find some free time for it.

Bunch of review

  • bug 1041765 - [Messages] Thread view redesign
    • Early feedback for the 1st round, and it looks great! Will review again later
  • Seems some regression in SIM switch data connection case... will take a look later
    (Oleg) Yeah, I believe it's because of "bug 1058585 - [B2G][RIL][Flame] fail to switch default data connection"
  • Many smaller review and question reply

Today:

  • Start to review the important item. Thread refresh is first one
  • Create a WIP for network-alert

Julien

  • On PTO till September 15th

Oleg

  • bug 1041765 - [Messages] Thread view redesign
    • Fixed review comments and asked for review since dependency bug is resolved (haven't checked with the latest pvt build yet) (in review).
  • bug 1011604 - [Messages] Update to use <gaia-header>
    • Advised on what CSS rules should be updated for gaia-header, no more, no less (ready for landing).
  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • R+'d, looks good! Just few nits and strange behavior with removing emergency alert notifications from notification tray.
  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • Handled a11y comments from Eitan (in review).

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;

Day 10: 1st September

Steve

  • bug 1051795 - [CMAS] Handle the setting that enables/disables CMAS alerts
    • Landed in the last minute. Create a follow up bug 1060727 the address the remaining attention screen behavior. Yay!
  • bug 1060727 - [CMAS] Duplicated notifications in system tray when dismiss the attention screen by tapping on home button
    • Will try to close the window while visibility change to hidden. Just test it and it should work. But the problem is when screen off by pressing power key. The app will be closed in this case... Discussing with Jenny to see if she accept this change.
      Will it be closed in this case? - phone is locked, screen is off, we receive CMAS, screen is on, but user doesn't see it and screen goes off again
      (Steve) I think it shouldn't screen off after a timeout with attention screen case
      (Oleg) Heh, it will drain battery and then phone will definitely off screen and everything else :)
      (Steve) hmm, you wouldn't expect your alarm only rings for 30 sec :p Just give it a try now - It will still timeout after a while :-/
      (Oleg) I've seen recently in gaia-dev discussion about Home press events, do you know if it's possible for us to use it? 'Hardware Key Event' - subject of email thread. Oh, no it's only for system app :(
      (Steve) yeah... They didn't want other apps to hack this event anyway :-/
      (Oleg) Yeah, then ideally attention screen should allow us to configure Home\Power press behaviour.
  • bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup)
    • Start it again today or tomorrow.

Bunch of review

  • Review the compose refresh patch again. Some other issues there but we could creating another follow up for that.
  • Reviewd a11y patch.

Today:

  • Try to address CMAS issue today(if possible)

Julien

  • On PTO till September 15th

Oleg

  • bug 1041765 - [Messages] Thread view redesign
    • Got r+, landed (landed).
      (Steve) I forgot to set ui-review first :p They prefers white outgoing bubble background. So they will create a follow up for this...
      (Oleg) Ha, ok :) With blocking v2.1 I guess. There is a bad contrast, I agree with them
  • bug 1051793 - [CMAS] Plug in real CMAS input to the CMAS application
    • R+'d, looks good! (landed)
  • bug 1048845 - [Messages] Compose Panel refresh (subject behavior change)
    • Got r+, looking into improving the way we handle data-counter as Steve suggested, doing it in the scope of this bug if not too much changes, otherwise will move to follow-up.
  • bug 1053964 - [Messages][Tests] Add marionette JS test case to verify close\back button behaviour when app is in activity mode
    • Rebased on the latest master, updated tests so they work with new gaia-header now (in review).

Today:

  • Will handle review comments for the patches that currently in review;
  • Will deal with review\feedback requests;
  • Will add Demos for my landed patches.

Demos

bug 1035762: Support 24 hour time format

Thread List panel (Inbox)

Thread panel

Report panel

bug 1041765: Thread view redesign

bug 1048845: Compose Panel refresh (subject behavior change)

bug 1051793: [CMAS] Plug in real CMAS input to the CMAS application

Running on the real device video: https://www.youtube.com/watch?v=IQd2nqSHZwY&list=UUkM1XSMB9c0p9684qCa6ZAA

Retrospective

What was good in the last sprint

  • I'd say we made it! :) Two big pieces are in, CMAS and part of new VR.
    • Yeah, we still meet the 2.1 feature request even we had less resource before FL

What was bad in the last sprint

  • Rush for FL date, don't like it soooo much, it would be great if we can align it with our sprint;
    • I think the uncertain part is the actual FL date. I still saw patch landed on Monday, which mean we really don't need to rush on Friday and Saturday
    • Yeah, right, we just need some clear dates for important milestones
  • Specific to me: it's first time when I had a lot of review requests :) So needed some time to used to it.
    • No worry, you will be more familiar with this :p I'm not so used to reviewing so much patches even now LOL :)
    • For sure! :)
  • Some delay of patch review and feedback because of FL
  • Didn't cover all the new created bugs that related to message app. Just curious how many time did he(julien) spent for new bugs triaging/nomination
    • Yeah, good question :)
    • Maybe we could do better in next sprint.
    • Sure, I also will try to be more active on this
    • Do you think it's easy for new comer to know how to contribute? I mean, there' some new contributor asking for taking the bug, but they seems have no proper document to do so.
    • I have mixed feelings, from one side I think we have enough docs and links that you and eventually me shared with potential contributors that were asking to be assigned. But after that they disappeared - I revised that links and it seems they're fine. But why they don't ask follow-up questions - I'm not sure. Another problem is difficulties with development in browser - eg. as new contributor I'd expect to build gaia then run it and see homescreen - but it doesn't work currently. Did we mention somewhere that developer should go directly to app://sms.gaiamobile.org? So my main point is that a bit difficult to understand what is really wrong when we don't have any feedback from them.
    • Well, since they are contributor, it's quite hard to push them as responsible as we do. But things we could do is providing the clear information, friendly development environment...and so one, otherwise they just leaves for other interesting stuffs(if developing firefox os is too painful to them)
    • We can try to build lightweight step-by-step guide for them (at least for SMS for now) with more pictures and less text :)
    • Maybe it's a good idea, and put it on sms wiki or more proper place. We can simply told the new developers to refer the wiki link before contribution
    • Yeah, plus when we fill "mentor" field we can put this link in comment in advance with "welcome message". And keep it up to date all the time. Let's try then.. If I have some time, I'll try to setup VM with environment and share it
    • Cool! that would be awesome  :)
    • Deal! :)

Any questions

  • Do we really need to shift to 1 or 2 days earlier so QA? Since I confirmed with QA that they actually don't have to signoff for anything...

Actions for next sprint

  • Clarify the branching schedule
  • Try to prepare VM with gaia dev environment to make contributions easier
  • Collect thoughts for Gaia SMS app step-by-step development\contribution.